Event filtering items

[Peter Peterson]

These tasks were discovered when using SEQ_31276.

For FilterEventsHighFrequency

• Have it inherit from DeprecatedAlgorithm rather than just having a comment in the algorithm description

For GenerateEventsFilter:

• The TimeType variable is unclear in its usage/meaning
• When splitting using SampleTemp from 276 to 288 in steps of 1, the tables generated start at 275.5 degrees rather than 276.
• Change the name of the parameter SplittersInformationWorkspace to InformationWorkspace
• Both the OutputWorkspace and the SplittersInformationWorkspace should agree on the common column heading of WorkspaceGroup and the values should match rather than be one off (information starts from zero, output starts from one)
• For the run being used, there are several rows in the OutputWorkspace that have zero time between the start and stop (rows 3 through 7 in my test). They should not appear.

For FilterEvents

• Events that are not filtered should go into a workspace named OutputWorkspaceBaseName_unfiltered
• Similar to GenerateEventsFilter, change the name of SplittersInformationWorkspace
• Change InputSplittersWorkspace to SplitterWorkspace

[Wenduo Zhou]

Fix a bug. Refs #6348.

Changeset: 3d3518bcaa28ae36a27158ffbdb14008d246e772

[Wenduo Zhou]

Inherit from DeprecationAlgorithm. Refs #6348.

Changeset: f355a16107bd3f720bb6ed05d9c3ae3a17e40753

[Wenduo Zhou]

Fix some issues. Refs #6348.

1. Rename property TimeType to UnitOfTime, and expand the doc;
2. Redfine default value of LogValueTolerance;
3. Fix a bug related to define the log value intervals;
4. Rename property SplittersInformationWorkspace to

InformationWorkspace;

Changeset: e6ae4383269c06edd0b0003a32ee2c3b66a18d9d

[Wenduo Zhou]

This works for me: Both the OutputWorkspace and the SplittersInformationWorkspace should agree on the common column heading of WorkspaceGroup and the values should match rather than be one off (information starts from zero, output starts from one)

This works for me: For the run being used, there are several rows in the OutputWorkspace that have zero time between the start and stop (rows 3 through 7 in my test). They should not appear.

[Wenduo Zhou]

Modify due to renaming algorithms called. Refs #6348.

FilterByTime2 calls GenerateEventsFilter and FilterEvents. As some properties of those 2 algorithms changed, Some modification is made to FilterByTime2 accordingly.

Changeset: 5be14375f847248f16a2a126279e0542d7506692

[Wenduo Zhou]

Fixed some issues. Refs #6348.

1. Rename property SplittersInformationWorkspace to

InformationWorkspace.

2. Rename InputSplittersWorkspace to SplitterWorkspace
3. Rename the output unfiltered workspace to

OutputWorkspaceBaseName_unfiltered.

Changeset: e07890b14f25452f6d7eb240f59a223ebb964188

[Wenduo Zhou]

Fix a bug. Refs #6348.

Changeset: 71be56ead7fec8b911a1fdbb7009284f50505651

[Wenduo Zhou]

Inherit from DeprecationAlgorithm. Refs #6348.

Changeset: 56f1fcf7cf66b2a91196a99d664bc17eb149b5d4

[Wenduo Zhou]

Fix some issues. Refs #6348.

1. Rename property TimeType to UnitOfTime, and expand the doc;
2. Redfine default value of LogValueTolerance;
3. Fix a bug related to define the log value intervals;
4. Rename property SplittersInformationWorkspace to

InformationWorkspace;

Changeset: 2f024e334896e82dbadd6a218eba24bfea73a7cd

[Wenduo Zhou]

Modify due to renaming algorithms called. Refs #6348.

FilterByTime2 calls GenerateEventsFilter and FilterEvents. As some properties of those 2 algorithms changed, Some modification is made to FilterByTime2 accordingly.

Changeset: adace7fe9303b8c076806358186069899b67445b

[Wenduo Zhou]

Fixed some issues. Refs #6348.

1. Rename property SplittersInformationWorkspace to

InformationWorkspace.

2. Rename InputSplittersWorkspace to SplitterWorkspace
3. Rename the output unfiltered workspace to

OutputWorkspaceBaseName_unfiltered.

Changeset: 9c1f0a94d8defeadf0d60ca0f6c977030ce7fd89

[Wenduo Zhou]

Do some renaming. Refs #6348.

1. Replace output workspace "OutputWorkspaceBaseName_-1" to

"OutputWorkspaceBaseName_unfiltered";

2. Rename property SplitterInformationWorkspace to InformationWorkspace;
3. Rename property InputSplittersWorkspace to SplitterWorkspace. Changeset: 4ea3a2b83985ddd7c70d34e14d352da2c6117ba0

[Wenduo Zhou]

Add some comments to unit tests. Refs #6348.

Changeset: 82cd4fc27050349f73e754c13b4dda1aee996143

[Wenduo Zhou]

Add some comments to unit tests. Refs #6348.

Changeset: f8ae64e41e5aabca57618df0fddf8173b50776da

[Wenduo Zhou]

Problem: "When splitting using SampleTemp from 276 to 288 in steps of 1, the tables generated start at 275.5 degrees rather than 276. "

Solution: It is about the default value of LogValueTolerance. Setting it to 0 explicitly will solve the problem.

[Peter Peterson]

This was done correctly.

[Stuart Campbell]

This ticket has been transferred to github issue ​7194