Ticket #6371 (closed: fixed)
Custom interface for looking at rocking curves
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.5 |
| Component: | MantidPlot | Keywords: | LiveData, ADARA |
| Cc: | Blocked By: | #6314, #6369, #6398 | |
| Blocking: | Tester: | Vickie Lynch |
Description
This will use the RockingCurve workflow algorithm and so will mainly be concerned with generating the inputs needed for that.
In addition, it will need to manage the process of doing it from live data and handling display of the curve, including allowing for changing of the variable viewed and the normalisation.
Change History
comment:4 Changed 8 years ago by Russell Taylor
Re #6371. First parts of GUI for dealing with rocking curves.
Changeset: 0e1eb6967bd15cf546ebe30944a81cfe90df7431
comment:5 Changed 8 years ago by Russell Taylor
Re #6371. Allow WorkspaceSelector to choose no workspace.
I.e. to work with optional workspace properties by adding an empty entry, if indicated by the relevant property ("Optional").
Changeset: ab7cc117f685452592b20480b726ea403289e08a
comment:6 Changed 8 years ago by Russell Taylor
Re #6371. Now essentially complete for offline analysis.
Changeset: 0f8dec714865e3fa9078e19b3f616674966f2afa
comment:8 Changed 8 years ago by Russell Taylor
Re #6371. First steps in using live data stream.
Changeset: 8648cfb4e140c9040f9a79c7a113027a3596d472
comment:9 Changed 8 years ago by Russell Taylor
- Milestone changed from Release 2.4 to Release 2.5
Moving to next iteration. Note that the registration of the interface remains commented out so there is no way for a user to access it.
comment:10 Changed 8 years ago by Russell Taylor
Re #6371. Rename Rocking Curve -> Step Scan.
Done for both the interface and the underlying workflow algorithm.
Changeset: b21ed597b64507987fc1c55bcfe03a27c926c53d
comment:11 Changed 8 years ago by Russell Taylor
Re #6371. Forgot to update the test.
It's late.....
Changeset: a20a4bb0ffbaa4364413c325d8eeda8ffb4919f3
comment:12 Changed 8 years ago by Russell Taylor
Re #6371. Check whether the input table is empty, fail if it is.
The algorithm previously would fail, but with a cryptic error message at the point it tried to create the output workspace. This is more obvious.
Changeset: 56307ceaadf0dab14038020978d444d5ab71f80e
comment:13 Changed 8 years ago by Russell Taylor
Re #6371. Don't remove the row for scan_index=1 if it's the only one.
Changeset: 22bbd6b9a5ae74ec10dbdfbf848bde08de4c785e
comment:14 Changed 8 years ago by Russell Taylor
Re #6371. Add code to allow use with live data.
Changeset: fb143450e8947721306ebe6399cd80794292609f
comment:15 Changed 8 years ago by Russell Taylor
Re #6371. Well it worked for me...
Changeset: e824827099b07d69fdf95ca252750a60a6bbdcdd
comment:16 Changed 8 years ago by Russell Taylor
Re #6371. Check whether the input table is empty, fail if it is.
The algorithm previously would fail, but with a cryptic error message at the point it tried to create the output workspace. This is more obvious.
Changeset: 56307ceaadf0dab14038020978d444d5ab71f80e
comment:17 Changed 8 years ago by Russell Taylor
Re #6371. Don't remove the row for scan_index=1 if it's the only one.
Changeset: 22bbd6b9a5ae74ec10dbdfbf848bde08de4c785e
comment:18 Changed 8 years ago by Russell Taylor
Re #6371. Add code to allow use with live data.
Changeset: fb143450e8947721306ebe6399cd80794292609f
comment:19 Changed 8 years ago by Russell Taylor
Re #6371. Well it worked for me...
Changeset: e824827099b07d69fdf95ca252750a60a6bbdcdd
comment:20 Changed 8 years ago by Russell Taylor
Re #6371. Left in a local testing line by mistake.
Also temporarily remove check that logs have more than one value for testing live client.
Changeset: cff5b488266ebdcf80c601f0c4d9e81576436a21
comment:21 Changed 8 years ago by Russell Taylor
Re #6371. Temporarily remove assert while testing live.
Changeset: e766e6d2589b166afba1598e37fd19c3a11888d1
comment:22 Changed 8 years ago by Russell Taylor
Re #6371. Always enable live button pending debugging of that code.
Changeset: dd5148fe0f60c16d4dbba10b115fd49196bc5c47
comment:23 Changed 8 years ago by Russell Taylor
Re #6371. Temporarily remove assert while testing live.
Changeset: e766e6d2589b166afba1598e37fd19c3a11888d1
comment:24 Changed 8 years ago by Russell Taylor
Re #6371. Always enable live button pending debugging of that code.
Changeset: dd5148fe0f60c16d4dbba10b115fd49196bc5c47
comment:25 Changed 8 years ago by Russell Taylor
Re #6371. Check whether the input table is empty, fail if it is.
The algorithm previously would fail, but with a cryptic error message at the point it tried to create the output workspace. This is more obvious.
Changeset: 56307ceaadf0dab14038020978d444d5ab71f80e
comment:26 Changed 8 years ago by Russell Taylor
Re #6371. Don't remove the row for scan_index=1 if it's the only one.
Changeset: 22bbd6b9a5ae74ec10dbdfbf848bde08de4c785e
comment:27 Changed 8 years ago by Russell Taylor
Re #6371. Add code to allow use with live data.
Changeset: fb143450e8947721306ebe6399cd80794292609f
comment:28 Changed 8 years ago by Russell Taylor
Re #6371. Well it worked for me...
Changeset: e824827099b07d69fdf95ca252750a60a6bbdcdd
comment:29 Changed 8 years ago by Russell Taylor
Re #6371. Left in a local testing line by mistake.
Also temporarily remove check that logs have more than one value for testing live client.
Changeset: cff5b488266ebdcf80c601f0c4d9e81576436a21
comment:30 Changed 8 years ago by Russell Taylor
Re #6371. Temporarily remove assert while testing live.
Changeset: e766e6d2589b166afba1598e37fd19c3a11888d1
comment:31 Changed 8 years ago by Russell Taylor
Re #6371. Always enable live button pending debugging of that code.
Changeset: dd5148fe0f60c16d4dbba10b115fd49196bc5c47
comment:32 Changed 8 years ago by Russell Taylor
Re #6371. Check whether the input table is empty, fail if it is.
The algorithm previously would fail, but with a cryptic error message at the point it tried to create the output workspace. This is more obvious.
Changeset: 56307ceaadf0dab14038020978d444d5ab71f80e
comment:33 Changed 8 years ago by Russell Taylor
Re #6371. Don't remove the row for scan_index=1 if it's the only one.
Changeset: 22bbd6b9a5ae74ec10dbdfbf848bde08de4c785e
comment:34 Changed 8 years ago by Russell Taylor
Re #6371. Add code to allow use with live data.
Changeset: fb143450e8947721306ebe6399cd80794292609f
comment:35 Changed 8 years ago by Russell Taylor
Re #6371. Well it worked for me...
Changeset: e824827099b07d69fdf95ca252750a60a6bbdcdd
comment:36 Changed 8 years ago by Russell Taylor
Re #6371. Left in a local testing line by mistake.
Also temporarily remove check that logs have more than one value for testing live client.
Changeset: cff5b488266ebdcf80c601f0c4d9e81576436a21
comment:37 Changed 8 years ago by Russell Taylor
Re #6371. Temporarily remove assert while testing live.
Changeset: e766e6d2589b166afba1598e37fd19c3a11888d1
comment:38 Changed 8 years ago by Russell Taylor
Re #6371. Always enable live button pending debugging of that code.
Changeset: dd5148fe0f60c16d4dbba10b115fd49196bc5c47
comment:39 Changed 7 years ago by Russell Taylor
Re #6371. Be sure to call the derived class create method.
Changeset: 2419d632511a9bedbae9f3548708ea7a7afec2e6
comment:40 Changed 7 years ago by Russell Taylor
Re #6371. Reset some things when deselecting the live listener.
Changeset: ca2a4f29e6b6f30a8528933b6d0005fffda15f0c
comment:41 Changed 7 years ago by Russell Taylor
Re #6371. Final log value is considered to last to end of run.
Also add back in check that keeps logs that don't change out of the result.
Changeset: 1d64d733f1b6e9c959fa7cb1bbf67c7adbb6c5d2
comment:42 Changed 7 years ago by Russell Taylor
Re #6371. Be sure to call the derived class create method.
Changeset: 2419d632511a9bedbae9f3548708ea7a7afec2e6
comment:43 Changed 7 years ago by Russell Taylor
Re #6371. Reset some things when deselecting the live listener.
Changeset: ca2a4f29e6b6f30a8528933b6d0005fffda15f0c
comment:44 Changed 7 years ago by Russell Taylor
Re #6371. Final log value is considered to last to end of run.
Also add back in check that keeps logs that don't change out of the result.
Changeset: 1d64d733f1b6e9c959fa7cb1bbf67c7adbb6c5d2
comment:45 Changed 7 years ago by Russell Taylor
Re #6371. Lower logging level for monitor check.
The live stream doesn't have monitors, so we don't want to normally see this log message over and over.
Changeset: 3904f8256c2a72b0059b64c6a56f92e850bb0e63
comment:46 Changed 7 years ago by Russell Taylor
Re #6371. Add a test for the last change to this algorithm.
Confirmed that without the fix, this test would fail.
Changeset: 2c83215addbe14093d8848099c9b9e57703c7e8f
comment:47 Changed 7 years ago by Russell Taylor
Re #6371. Remove temp file that I added mistakenly some months ago.
Changeset: 672d7ded5de625b7c1f9d24bb6958c664861ad93
comment:48 Changed 7 years ago by Russell Taylor
Re #6371. Improve some error messages.
Changeset: c843c1c8fa3df1a3f0a0396fcbe73df8d79b6139
comment:49 Changed 7 years ago by Russell Taylor
Re #6371. Some protection against an empty log.
Changeset: a83b4489a9c57d93f20e0463875ec3170f2852fe
comment:50 Changed 7 years ago by Russell Taylor
Re #6371. Lower logging level for monitor check.
The live stream doesn't have monitors, so we don't want to normally see this log message over and over.
Changeset: 3904f8256c2a72b0059b64c6a56f92e850bb0e63
comment:51 Changed 7 years ago by Russell Taylor
Re #6371. Add a test for the last change to this algorithm.
Confirmed that without the fix, this test would fail.
Changeset: 2c83215addbe14093d8848099c9b9e57703c7e8f
comment:52 Changed 7 years ago by Russell Taylor
Re #6371. Remove temp file that I added mistakenly some months ago.
Changeset: 672d7ded5de625b7c1f9d24bb6958c664861ad93
comment:53 Changed 7 years ago by Russell Taylor
Re #6371. Improve some error messages.
Changeset: c843c1c8fa3df1a3f0a0396fcbe73df8d79b6139
comment:54 Changed 7 years ago by Russell Taylor
Re #6371. Some protection against an empty log.
Changeset: a83b4489a9c57d93f20e0463875ec3170f2852fe
comment:55 Changed 7 years ago by Russell Taylor
Re #6371. Further improvement to error messages.
Changeset: d3077b4810f5a8b9d3b0f8445c9cdb98abf65f35
comment:56 Changed 7 years ago by Russell Taylor
Re #6371. Forgot about the test for previous commit.
Changeset: e8b3532f82c598b1578d13a5c3b696d76b9d9b6b
comment:57 Changed 7 years ago by Russell Taylor
Re #6371. Be sure not to try and use an empty proton charge log.
Changeset: 1b32b1934ce1b5ed3a75681c2e3b9740eba9c8ae
comment:58 Changed 7 years ago by Russell Taylor
Re #6371. Forgot about the test for previous commit.
Changeset: e8b3532f82c598b1578d13a5c3b696d76b9d9b6b
comment:59 Changed 7 years ago by Russell Taylor
Re #6371. Be sure not to try and use an empty proton charge log.
Changeset: 1b32b1934ce1b5ed3a75681c2e3b9740eba9c8ae
comment:60 Changed 7 years ago by Russell Taylor
Re #6371. Include only varying logs in the combobox.
Changeset: 19a748b65058869b38bf9f0e1ee9aace12bb9ebf
comment:61 Changed 7 years ago by Russell Taylor
Re #6371. Include only varying logs in the combobox.
Changeset: 19a748b65058869b38bf9f0e1ee9aace12bb9ebf
comment:62 Changed 7 years ago by Russell Taylor
Re #6371. Minor changes - better memory management in test.
Changeset: c62c509620c3a883555caa368382f73363010096
comment:63 Changed 7 years ago by Russell Taylor
Re #6371. Tests for getFirst/LastPulseTime.
Changeset: f4439aec3b4921eb7f2b079c71ce84b98b1a958e
comment:64 Changed 7 years ago by Russell Taylor
Re #6371. Tidy up of getFirst/LastPulseTime.
The (!log) tests were redundant - the previous lines will throw if the property isn't there.
Changeset: b61425fd5784b98f510129e4eb50822808303e44
comment:65 Changed 7 years ago by Russell Taylor
Re #6371. Add busy cursors when running algorithms.
My experience so far is that running the algorithms is fairly fast. This leads me to think that I may not need to run things asynchronously.
Changeset: 8ee72d8273f866170491f41f07c77b57972b51d4
comment:66 Changed 7 years ago by Russell Taylor
Re #6371. Minor changes - better memory management in test.
Changeset: c62c509620c3a883555caa368382f73363010096
comment:67 Changed 7 years ago by Russell Taylor
Re #6371. Tests for getFirst/LastPulseTime.
Changeset: f4439aec3b4921eb7f2b079c71ce84b98b1a958e
comment:68 Changed 7 years ago by Russell Taylor
Re #6371. Tidy up of getFirst/LastPulseTime.
The (!log) tests were redundant - the previous lines will throw if the property isn't there.
Changeset: b61425fd5784b98f510129e4eb50822808303e44
comment:69 Changed 7 years ago by Russell Taylor
Re #6371. Add busy cursors when running algorithms.
My experience so far is that running the algorithms is fairly fast. This leads me to think that I may not need to run things asynchronously.
Changeset: 8ee72d8273f866170491f41f07c77b57972b51d4
comment:70 Changed 7 years ago by Russell Taylor
Re #6371. Check whether the input table is empty, fail if it is.
The algorithm previously would fail, but with a cryptic error message at the point it tried to create the output workspace. This is more obvious.
Changeset: 56307ceaadf0dab14038020978d444d5ab71f80e
comment:71 Changed 7 years ago by Russell Taylor
Re #6371. Don't remove the row for scan_index=1 if it's the only one.
Changeset: 22bbd6b9a5ae74ec10dbdfbf848bde08de4c785e
comment:72 Changed 7 years ago by Russell Taylor
Re #6371. Add code to allow use with live data.
Changeset: fb143450e8947721306ebe6399cd80794292609f
comment:73 Changed 7 years ago by Russell Taylor
Re #6371. Well it worked for me...
Changeset: e824827099b07d69fdf95ca252750a60a6bbdcdd
comment:74 Changed 7 years ago by Russell Taylor
Re #6371. Left in a local testing line by mistake.
Also temporarily remove check that logs have more than one value for testing live client.
Changeset: cff5b488266ebdcf80c601f0c4d9e81576436a21
comment:75 Changed 7 years ago by Russell Taylor
Re #6371. Temporarily remove assert while testing live.
Changeset: e766e6d2589b166afba1598e37fd19c3a11888d1
comment:76 Changed 7 years ago by Russell Taylor
Re #6371. Always enable live button pending debugging of that code.
Changeset: dd5148fe0f60c16d4dbba10b115fd49196bc5c47
comment:77 Changed 7 years ago by Russell Taylor
Re #6371. Be sure to call the derived class create method.
Changeset: 2419d632511a9bedbae9f3548708ea7a7afec2e6
comment:78 Changed 7 years ago by Russell Taylor
Re #6371. Reset some things when deselecting the live listener.
Changeset: ca2a4f29e6b6f30a8528933b6d0005fffda15f0c
comment:79 Changed 7 years ago by Russell Taylor
Re #6371. Final log value is considered to last to end of run.
Also add back in check that keeps logs that don't change out of the result.
Changeset: 1d64d733f1b6e9c959fa7cb1bbf67c7adbb6c5d2
comment:80 Changed 7 years ago by Russell Taylor
Re #6371. Lower logging level for monitor check.
The live stream doesn't have monitors, so we don't want to normally see this log message over and over.
Changeset: 3904f8256c2a72b0059b64c6a56f92e850bb0e63
comment:81 Changed 7 years ago by Russell Taylor
Re #6371. Add a test for the last change to this algorithm.
Confirmed that without the fix, this test would fail.
Changeset: 2c83215addbe14093d8848099c9b9e57703c7e8f
comment:82 Changed 7 years ago by Russell Taylor
Re #6371. Remove temp file that I added mistakenly some months ago.
Changeset: 672d7ded5de625b7c1f9d24bb6958c664861ad93
comment:83 Changed 7 years ago by Russell Taylor
Re #6371. Improve some error messages.
Changeset: c843c1c8fa3df1a3f0a0396fcbe73df8d79b6139
comment:84 Changed 7 years ago by Russell Taylor
Re #6371. Some protection against an empty log.
Changeset: a83b4489a9c57d93f20e0463875ec3170f2852fe
comment:85 Changed 7 years ago by Russell Taylor
Re #6371. Further improvement to error messages.
Changeset: d3077b4810f5a8b9d3b0f8445c9cdb98abf65f35
comment:86 Changed 7 years ago by Russell Taylor
Re #6371. For now, need to keep even unchanging logs.
Pending resolution of #6886.
Changeset: 4c885687ff6f65db8bc384c5913d5e7ccce747d4
comment:87 Changed 7 years ago by Russell Taylor
Re #6371. Forgot about the test for previous commit.
Changeset: e8b3532f82c598b1578d13a5c3b696d76b9d9b6b
comment:88 Changed 7 years ago by Russell Taylor
Re #6371. Be sure not to try and use an empty proton charge log.
Changeset: 1b32b1934ce1b5ed3a75681c2e3b9740eba9c8ae
comment:89 Changed 7 years ago by Russell Taylor
Re #6371. Include only varying logs in the combobox.
Changeset: 19a748b65058869b38bf9f0e1ee9aace12bb9ebf
comment:90 Changed 7 years ago by Russell Taylor
Re #6371. Minor changes - better memory management in test.
Changeset: c62c509620c3a883555caa368382f73363010096
comment:91 Changed 7 years ago by Russell Taylor
Re #6371. Tests for getFirst/LastPulseTime.
Changeset: f4439aec3b4921eb7f2b079c71ce84b98b1a958e
comment:92 Changed 7 years ago by Russell Taylor
Re #6371. Tidy up of getFirst/LastPulseTime.
The (!log) tests were redundant - the previous lines will throw if the property isn't there.
Changeset: b61425fd5784b98f510129e4eb50822808303e44
comment:93 Changed 7 years ago by Russell Taylor
Re #6371. Add busy cursors when running algorithms.
My experience so far is that running the algorithms is fairly fast. This leads me to think that I may not need to run things asynchronously.
Changeset: 8ee72d8273f866170491f41f07c77b57972b51d4
comment:94 Changed 7 years ago by Russell Taylor
Re #6371. Check whether the input table is empty, fail if it is.
The algorithm previously would fail, but with a cryptic error message at the point it tried to create the output workspace. This is more obvious.
Changeset: 56307ceaadf0dab14038020978d444d5ab71f80e
comment:95 Changed 7 years ago by Russell Taylor
Re #6371. Don't remove the row for scan_index=1 if it's the only one.
Changeset: 22bbd6b9a5ae74ec10dbdfbf848bde08de4c785e
comment:96 Changed 7 years ago by Russell Taylor
Re #6371. Add code to allow use with live data.
Changeset: fb143450e8947721306ebe6399cd80794292609f
comment:97 Changed 7 years ago by Russell Taylor
Re #6371. Well it worked for me...
Changeset: e824827099b07d69fdf95ca252750a60a6bbdcdd
comment:98 Changed 7 years ago by Russell Taylor
Re #6371. Left in a local testing line by mistake.
Also temporarily remove check that logs have more than one value for testing live client.
Changeset: cff5b488266ebdcf80c601f0c4d9e81576436a21
comment:99 Changed 7 years ago by Russell Taylor
Re #6371. Temporarily remove assert while testing live.
Changeset: e766e6d2589b166afba1598e37fd19c3a11888d1
comment:100 Changed 7 years ago by Russell Taylor
Re #6371. Always enable live button pending debugging of that code.
Changeset: dd5148fe0f60c16d4dbba10b115fd49196bc5c47
comment:101 Changed 7 years ago by Russell Taylor
Re #6371. Be sure to call the derived class create method.
Changeset: 2419d632511a9bedbae9f3548708ea7a7afec2e6
comment:102 Changed 7 years ago by Russell Taylor
Re #6371. Reset some things when deselecting the live listener.
Changeset: ca2a4f29e6b6f30a8528933b6d0005fffda15f0c
comment:103 Changed 7 years ago by Russell Taylor
Re #6371. Final log value is considered to last to end of run.
Also add back in check that keeps logs that don't change out of the result.
Changeset: 1d64d733f1b6e9c959fa7cb1bbf67c7adbb6c5d2
comment:104 Changed 7 years ago by Russell Taylor
Re #6371. Lower logging level for monitor check.
The live stream doesn't have monitors, so we don't want to normally see this log message over and over.
Changeset: 3904f8256c2a72b0059b64c6a56f92e850bb0e63
comment:105 Changed 7 years ago by Russell Taylor
Re #6371. Add a test for the last change to this algorithm.
Confirmed that without the fix, this test would fail.
Changeset: 2c83215addbe14093d8848099c9b9e57703c7e8f
comment:106 Changed 7 years ago by Russell Taylor
Re #6371. Remove temp file that I added mistakenly some months ago.
Changeset: 672d7ded5de625b7c1f9d24bb6958c664861ad93
comment:107 Changed 7 years ago by Russell Taylor
Re #6371. Improve some error messages.
Changeset: c843c1c8fa3df1a3f0a0396fcbe73df8d79b6139
comment:108 Changed 7 years ago by Russell Taylor
Re #6371. Some protection against an empty log.
Changeset: a83b4489a9c57d93f20e0463875ec3170f2852fe
comment:109 Changed 7 years ago by Russell Taylor
Re #6371. Further improvement to error messages.
Changeset: d3077b4810f5a8b9d3b0f8445c9cdb98abf65f35
comment:110 Changed 7 years ago by Russell Taylor
Re #6371. For now, need to keep even unchanging logs.
Pending resolution of #6886.
Changeset: 4c885687ff6f65db8bc384c5913d5e7ccce747d4
comment:111 Changed 7 years ago by Russell Taylor
Re #6371. Forgot about the test for previous commit.
Changeset: e8b3532f82c598b1578d13a5c3b696d76b9d9b6b
comment:112 Changed 7 years ago by Russell Taylor
Re #6371. Be sure not to try and use an empty proton charge log.
Changeset: 1b32b1934ce1b5ed3a75681c2e3b9740eba9c8ae
comment:113 Changed 7 years ago by Russell Taylor
Re #6371. Include only varying logs in the combobox.
Changeset: 19a748b65058869b38bf9f0e1ee9aace12bb9ebf
comment:114 Changed 7 years ago by Russell Taylor
Re #6371. Minor changes - better memory management in test.
Changeset: c62c509620c3a883555caa368382f73363010096
comment:115 Changed 7 years ago by Russell Taylor
Re #6371. Tests for getFirst/LastPulseTime.
Changeset: f4439aec3b4921eb7f2b079c71ce84b98b1a958e
comment:116 Changed 7 years ago by Russell Taylor
Re #6371. Tidy up of getFirst/LastPulseTime.
The (!log) tests were redundant - the previous lines will throw if the property isn't there.
Changeset: b61425fd5784b98f510129e4eb50822808303e44
comment:117 Changed 7 years ago by Russell Taylor
Re #6371. Add busy cursors when running algorithms.
My experience so far is that running the algorithms is fairly fast. This leads me to think that I may not need to run things asynchronously.
Changeset: 8ee72d8273f866170491f41f07c77b57972b51d4
comment:118 Changed 7 years ago by Russell Taylor
Re #6371. Lower the logging level on connection.
In general, the calling factory class should be handling reporting here. Specifically, I want to silently attempt a connection in the background without the user seeing it.
Changeset: 81948528b643632f826f12b211a290ba7fd0845e
comment:119 Changed 7 years ago by Russell Taylor
Re #6371. Lower the logging level on connection.
In general, the calling factory class should be handling reporting here. Specifically, I want to silently attempt a connection in the background without the user seeing it.
Changeset: 81948528b643632f826f12b211a290ba7fd0845e
comment:120 Changed 7 years ago by Russell Taylor
Re #6371. Avoid trying to reload same file over and over.
I was having problems on the mac with this slot being invoked every time the filename box lost focus, leading to getting stuck in a loop if an invalid file had been loaded. For some reason I didn't see this on RHEL6.
Changeset: f87a789205b59288ca9239684a7e17d7934bfa0f
comment:121 Changed 7 years ago by Russell Taylor
Re #6371. Probably a better clean-up order.
Changeset: c6bd9d5ce1da4252c83e972c50e0d0fa7fe3695f
comment:122 Changed 7 years ago by Russell Taylor
Re #6371. Add a help button.
Changeset: 72c680657ebcb761476dfe2f7abdf63279597cec
comment:123 Changed 7 years ago by Russell Taylor
Re #6371. Add a help button.
Changeset: 72c680657ebcb761476dfe2f7abdf63279597cec
comment:124 Changed 7 years ago by Russell Taylor
Re #6371. Check whether the input table is empty, fail if it is.
The algorithm previously would fail, but with a cryptic error message at the point it tried to create the output workspace. This is more obvious.
Changeset: 56307ceaadf0dab14038020978d444d5ab71f80e
comment:125 Changed 7 years ago by Russell Taylor
Re #6371. Don't remove the row for scan_index=1 if it's the only one.
Changeset: 22bbd6b9a5ae74ec10dbdfbf848bde08de4c785e
comment:126 Changed 7 years ago by Russell Taylor
Re #6371. Add code to allow use with live data.
Changeset: fb143450e8947721306ebe6399cd80794292609f
comment:127 Changed 7 years ago by Russell Taylor
Re #6371. Well it worked for me...
Changeset: e824827099b07d69fdf95ca252750a60a6bbdcdd
comment:128 Changed 7 years ago by Russell Taylor
Re #6371. Left in a local testing line by mistake.
Also temporarily remove check that logs have more than one value for testing live client.
Changeset: cff5b488266ebdcf80c601f0c4d9e81576436a21
comment:129 Changed 7 years ago by Russell Taylor
Re #6371. Temporarily remove assert while testing live.
Changeset: e766e6d2589b166afba1598e37fd19c3a11888d1
comment:130 Changed 7 years ago by Russell Taylor
Re #6371. Always enable live button pending debugging of that code.
Changeset: dd5148fe0f60c16d4dbba10b115fd49196bc5c47
comment:131 Changed 7 years ago by Russell Taylor
Re #6371. Be sure to call the derived class create method.
Changeset: 2419d632511a9bedbae9f3548708ea7a7afec2e6
comment:132 Changed 7 years ago by Russell Taylor
Re #6371. Reset some things when deselecting the live listener.
Changeset: ca2a4f29e6b6f30a8528933b6d0005fffda15f0c
comment:133 Changed 7 years ago by Russell Taylor
Re #6371. Final log value is considered to last to end of run.
Also add back in check that keeps logs that don't change out of the result.
Changeset: 1d64d733f1b6e9c959fa7cb1bbf67c7adbb6c5d2
comment:134 Changed 7 years ago by Russell Taylor
Re #6371. Lower logging level for monitor check.
The live stream doesn't have monitors, so we don't want to normally see this log message over and over.
Changeset: 3904f8256c2a72b0059b64c6a56f92e850bb0e63
comment:135 Changed 7 years ago by Russell Taylor
Re #6371. Add a test for the last change to this algorithm.
Confirmed that without the fix, this test would fail.
Changeset: 2c83215addbe14093d8848099c9b9e57703c7e8f
comment:136 Changed 7 years ago by Russell Taylor
Re #6371. Remove temp file that I added mistakenly some months ago.
Changeset: 672d7ded5de625b7c1f9d24bb6958c664861ad93
comment:137 Changed 7 years ago by Russell Taylor
Re #6371. Improve some error messages.
Changeset: c843c1c8fa3df1a3f0a0396fcbe73df8d79b6139
comment:138 Changed 7 years ago by Russell Taylor
Re #6371. Some protection against an empty log.
Changeset: a83b4489a9c57d93f20e0463875ec3170f2852fe
comment:139 Changed 7 years ago by Russell Taylor
Re #6371. Further improvement to error messages.
Changeset: d3077b4810f5a8b9d3b0f8445c9cdb98abf65f35
comment:140 Changed 7 years ago by Russell Taylor
Re #6371. For now, need to keep even unchanging logs.
Pending resolution of #6886.
Changeset: 4c885687ff6f65db8bc384c5913d5e7ccce747d4
comment:141 Changed 7 years ago by Russell Taylor
Re #6371. Forgot about the test for previous commit.
Changeset: e8b3532f82c598b1578d13a5c3b696d76b9d9b6b
comment:142 Changed 7 years ago by Russell Taylor
Re #6371. Be sure not to try and use an empty proton charge log.
Changeset: 1b32b1934ce1b5ed3a75681c2e3b9740eba9c8ae
comment:143 Changed 7 years ago by Russell Taylor
Re #6371. Include only varying logs in the combobox.
Changeset: 19a748b65058869b38bf9f0e1ee9aace12bb9ebf
comment:144 Changed 7 years ago by Russell Taylor
Re #6371. Minor changes - better memory management in test.
Changeset: c62c509620c3a883555caa368382f73363010096
comment:145 Changed 7 years ago by Russell Taylor
Re #6371. Tests for getFirst/LastPulseTime.
Changeset: f4439aec3b4921eb7f2b079c71ce84b98b1a958e
comment:146 Changed 7 years ago by Russell Taylor
Re #6371. Tidy up of getFirst/LastPulseTime.
The (!log) tests were redundant - the previous lines will throw if the property isn't there.
Changeset: b61425fd5784b98f510129e4eb50822808303e44
comment:147 Changed 7 years ago by Russell Taylor
Re #6371. Add busy cursors when running algorithms.
My experience so far is that running the algorithms is fairly fast. This leads me to think that I may not need to run things asynchronously.
Changeset: 8ee72d8273f866170491f41f07c77b57972b51d4
comment:148 Changed 7 years ago by Russell Taylor
- Status changed from accepted to verify
- Resolution set to fixed
TESTING:
This GUI can be found as Step Scan Analysis under the Interfaces menu. The 'good' file for testing it is HYSA_2934.nxs.h5 in the systemtests repo under Data, though you should also test the behaviour with all manner of other file types. This is for processing scan runs where 'something' (e.g. the detector) is moved to a new position for each data point. It is facilitated by a special log 'scan_index' in new HYSPEC/ADARA data files.
I think it's reasonably self-explanatory, although I do need to fill in the instructions at http://www.mantidproject.org/Step_Scan_Interface. Although these would help there's something to be said for just meddling with boxes & buttons to try and break things.
You probably won't be able to test the happy path with a live stream as that requires (a) a connection to the HYSPEC live stream & (b) for them to be doing a scan. There is scope for changing your default instrument to various different things (incl. ISIS ones) to check nothing bad happens.
comment:149 Changed 7 years ago by Russell Taylor
Re #6371. Check whether the input table is empty, fail if it is.
The algorithm previously would fail, but with a cryptic error message at the point it tried to create the output workspace. This is more obvious.
Changeset: 56307ceaadf0dab14038020978d444d5ab71f80e
comment:150 Changed 7 years ago by Russell Taylor
Re #6371. Don't remove the row for scan_index=1 if it's the only one.
Changeset: 22bbd6b9a5ae74ec10dbdfbf848bde08de4c785e
comment:151 Changed 7 years ago by Russell Taylor
Re #6371. Add code to allow use with live data.
Changeset: fb143450e8947721306ebe6399cd80794292609f
comment:152 Changed 7 years ago by Russell Taylor
Re #6371. Well it worked for me...
Changeset: e824827099b07d69fdf95ca252750a60a6bbdcdd
comment:153 Changed 7 years ago by Russell Taylor
Re #6371. Left in a local testing line by mistake.
Also temporarily remove check that logs have more than one value for testing live client.
Changeset: cff5b488266ebdcf80c601f0c4d9e81576436a21
comment:154 Changed 7 years ago by Russell Taylor
Re #6371. Temporarily remove assert while testing live.
Changeset: e766e6d2589b166afba1598e37fd19c3a11888d1
comment:155 Changed 7 years ago by Russell Taylor
Re #6371. Always enable live button pending debugging of that code.
Changeset: dd5148fe0f60c16d4dbba10b115fd49196bc5c47
comment:156 Changed 7 years ago by Russell Taylor
Re #6371. Be sure to call the derived class create method.
Changeset: 2419d632511a9bedbae9f3548708ea7a7afec2e6
comment:157 Changed 7 years ago by Russell Taylor
Re #6371. Reset some things when deselecting the live listener.
Changeset: ca2a4f29e6b6f30a8528933b6d0005fffda15f0c
comment:158 Changed 7 years ago by Russell Taylor
Re #6371. Final log value is considered to last to end of run.
Also add back in check that keeps logs that don't change out of the result.
Changeset: 1d64d733f1b6e9c959fa7cb1bbf67c7adbb6c5d2
comment:159 Changed 7 years ago by Russell Taylor
Re #6371. Lower logging level for monitor check.
The live stream doesn't have monitors, so we don't want to normally see this log message over and over.
Changeset: 3904f8256c2a72b0059b64c6a56f92e850bb0e63
comment:160 Changed 7 years ago by Russell Taylor
Re #6371. Add a test for the last change to this algorithm.
Confirmed that without the fix, this test would fail.
Changeset: 2c83215addbe14093d8848099c9b9e57703c7e8f
comment:161 Changed 7 years ago by Russell Taylor
Re #6371. Remove temp file that I added mistakenly some months ago.
Changeset: 672d7ded5de625b7c1f9d24bb6958c664861ad93
comment:162 Changed 7 years ago by Russell Taylor
Re #6371. Improve some error messages.
Changeset: c843c1c8fa3df1a3f0a0396fcbe73df8d79b6139
comment:163 Changed 7 years ago by Russell Taylor
Re #6371. Some protection against an empty log.
Changeset: a83b4489a9c57d93f20e0463875ec3170f2852fe
comment:164 Changed 7 years ago by Russell Taylor
Re #6371. Further improvement to error messages.
Changeset: d3077b4810f5a8b9d3b0f8445c9cdb98abf65f35
comment:165 Changed 7 years ago by Russell Taylor
Re #6371. For now, need to keep even unchanging logs.
Pending resolution of #6886.
Changeset: 4c885687ff6f65db8bc384c5913d5e7ccce747d4
comment:166 Changed 7 years ago by Russell Taylor
Re #6371. Forgot about the test for previous commit.
Changeset: e8b3532f82c598b1578d13a5c3b696d76b9d9b6b
comment:167 Changed 7 years ago by Russell Taylor
Re #6371. Be sure not to try and use an empty proton charge log.
Changeset: 1b32b1934ce1b5ed3a75681c2e3b9740eba9c8ae
comment:168 Changed 7 years ago by Russell Taylor
Re #6371. Include only varying logs in the combobox.
Changeset: 19a748b65058869b38bf9f0e1ee9aace12bb9ebf
comment:169 Changed 7 years ago by Russell Taylor
Re #6371. Minor changes - better memory management in test.
Changeset: c62c509620c3a883555caa368382f73363010096
comment:170 Changed 7 years ago by Russell Taylor
Re #6371. Tests for getFirst/LastPulseTime.
Changeset: f4439aec3b4921eb7f2b079c71ce84b98b1a958e
comment:171 Changed 7 years ago by Russell Taylor
Re #6371. Tidy up of getFirst/LastPulseTime.
The (!log) tests were redundant - the previous lines will throw if the property isn't there.
Changeset: b61425fd5784b98f510129e4eb50822808303e44
comment:172 Changed 7 years ago by Russell Taylor
Re #6371. Add busy cursors when running algorithms.
My experience so far is that running the algorithms is fairly fast. This leads me to think that I may not need to run things asynchronously.
Changeset: 8ee72d8273f866170491f41f07c77b57972b51d4
comment:173 Changed 7 years ago by Russell Taylor
Re #6371. Check whether the input table is empty, fail if it is.
The algorithm previously would fail, but with a cryptic error message at the point it tried to create the output workspace. This is more obvious.
Changeset: 56307ceaadf0dab14038020978d444d5ab71f80e
comment:174 Changed 7 years ago by Russell Taylor
Re #6371. Don't remove the row for scan_index=1 if it's the only one.
Changeset: 22bbd6b9a5ae74ec10dbdfbf848bde08de4c785e
comment:175 Changed 7 years ago by Russell Taylor
Re #6371. Add code to allow use with live data.
Changeset: fb143450e8947721306ebe6399cd80794292609f
comment:176 Changed 7 years ago by Russell Taylor
Re #6371. Well it worked for me...
Changeset: e824827099b07d69fdf95ca252750a60a6bbdcdd
comment:177 Changed 7 years ago by Russell Taylor
Re #6371. Left in a local testing line by mistake.
Also temporarily remove check that logs have more than one value for testing live client.
Changeset: cff5b488266ebdcf80c601f0c4d9e81576436a21
comment:178 Changed 7 years ago by Russell Taylor
Re #6371. Temporarily remove assert while testing live.
Changeset: e766e6d2589b166afba1598e37fd19c3a11888d1
comment:179 Changed 7 years ago by Russell Taylor
Re #6371. Always enable live button pending debugging of that code.
Changeset: dd5148fe0f60c16d4dbba10b115fd49196bc5c47
comment:180 Changed 7 years ago by Russell Taylor
Re #6371. Be sure to call the derived class create method.
Changeset: 2419d632511a9bedbae9f3548708ea7a7afec2e6
comment:181 Changed 7 years ago by Russell Taylor
Re #6371. Reset some things when deselecting the live listener.
Changeset: ca2a4f29e6b6f30a8528933b6d0005fffda15f0c
comment:182 Changed 7 years ago by Russell Taylor
Re #6371. Final log value is considered to last to end of run.
Also add back in check that keeps logs that don't change out of the result.
Changeset: 1d64d733f1b6e9c959fa7cb1bbf67c7adbb6c5d2
comment:183 Changed 7 years ago by Russell Taylor
Re #6371. Lower logging level for monitor check.
The live stream doesn't have monitors, so we don't want to normally see this log message over and over.
Changeset: 3904f8256c2a72b0059b64c6a56f92e850bb0e63
comment:184 Changed 7 years ago by Russell Taylor
Re #6371. Add a test for the last change to this algorithm.
Confirmed that without the fix, this test would fail.
Changeset: 2c83215addbe14093d8848099c9b9e57703c7e8f
comment:185 Changed 7 years ago by Russell Taylor
Re #6371. Remove temp file that I added mistakenly some months ago.
Changeset: 672d7ded5de625b7c1f9d24bb6958c664861ad93
comment:186 Changed 7 years ago by Russell Taylor
Re #6371. Improve some error messages.
Changeset: c843c1c8fa3df1a3f0a0396fcbe73df8d79b6139
comment:187 Changed 7 years ago by Russell Taylor
Re #6371. Some protection against an empty log.
Changeset: a83b4489a9c57d93f20e0463875ec3170f2852fe
comment:188 Changed 7 years ago by Russell Taylor
Re #6371. Further improvement to error messages.
Changeset: d3077b4810f5a8b9d3b0f8445c9cdb98abf65f35
comment:189 Changed 7 years ago by Russell Taylor
Re #6371. For now, need to keep even unchanging logs.
Pending resolution of #6886.
Changeset: 4c885687ff6f65db8bc384c5913d5e7ccce747d4
comment:190 Changed 7 years ago by Russell Taylor
Re #6371. Forgot about the test for previous commit.
Changeset: e8b3532f82c598b1578d13a5c3b696d76b9d9b6b
comment:191 Changed 7 years ago by Russell Taylor
Re #6371. Be sure not to try and use an empty proton charge log.
Changeset: 1b32b1934ce1b5ed3a75681c2e3b9740eba9c8ae
comment:192 Changed 7 years ago by Russell Taylor
Re #6371. Include only varying logs in the combobox.
Changeset: 19a748b65058869b38bf9f0e1ee9aace12bb9ebf
comment:193 Changed 7 years ago by Russell Taylor
Re #6371. Minor changes - better memory management in test.
Changeset: c62c509620c3a883555caa368382f73363010096
comment:194 Changed 7 years ago by Russell Taylor
Re #6371. Tests for getFirst/LastPulseTime.
Changeset: f4439aec3b4921eb7f2b079c71ce84b98b1a958e
comment:195 Changed 7 years ago by Russell Taylor
Re #6371. Tidy up of getFirst/LastPulseTime.
The (!log) tests were redundant - the previous lines will throw if the property isn't there.
Changeset: b61425fd5784b98f510129e4eb50822808303e44
comment:196 Changed 7 years ago by Russell Taylor
Re #6371. Add busy cursors when running algorithms.
My experience so far is that running the algorithms is fairly fast. This leads me to think that I may not need to run things asynchronously.
Changeset: 8ee72d8273f866170491f41f07c77b57972b51d4
comment:197 Changed 7 years ago by Vickie Lynch
- Status changed from verify to verifying
- Tester set to Vickie Lynch
comment:198 Changed 7 years ago by Vickie Lynch
- Status changed from verifying to closed
Seems to work
comment:199 Changed 7 years ago by Russell Taylor
Re #6371. Check whether the input table is empty, fail if it is.
The algorithm previously would fail, but with a cryptic error message at the point it tried to create the output workspace. This is more obvious.
Changeset: 56307ceaadf0dab14038020978d444d5ab71f80e
comment:200 Changed 7 years ago by Russell Taylor
Re #6371. Don't remove the row for scan_index=1 if it's the only one.
Changeset: 22bbd6b9a5ae74ec10dbdfbf848bde08de4c785e
comment:201 Changed 7 years ago by Russell Taylor
Re #6371. Add code to allow use with live data.
Changeset: fb143450e8947721306ebe6399cd80794292609f
comment:202 Changed 7 years ago by Russell Taylor
Re #6371. Well it worked for me...
Changeset: e824827099b07d69fdf95ca252750a60a6bbdcdd
comment:203 Changed 7 years ago by Russell Taylor
Re #6371. Left in a local testing line by mistake.
Also temporarily remove check that logs have more than one value for testing live client.
Changeset: cff5b488266ebdcf80c601f0c4d9e81576436a21
comment:204 Changed 7 years ago by Russell Taylor
Re #6371. Temporarily remove assert while testing live.
Changeset: e766e6d2589b166afba1598e37fd19c3a11888d1
comment:205 Changed 7 years ago by Russell Taylor
Re #6371. Always enable live button pending debugging of that code.
Changeset: dd5148fe0f60c16d4dbba10b115fd49196bc5c47
comment:206 Changed 7 years ago by Russell Taylor
Re #6371. Be sure to call the derived class create method.
Changeset: 2419d632511a9bedbae9f3548708ea7a7afec2e6
comment:207 Changed 7 years ago by Russell Taylor
Re #6371. Reset some things when deselecting the live listener.
Changeset: ca2a4f29e6b6f30a8528933b6d0005fffda15f0c
comment:208 Changed 7 years ago by Russell Taylor
Re #6371. Final log value is considered to last to end of run.
Also add back in check that keeps logs that don't change out of the result.
Changeset: 1d64d733f1b6e9c959fa7cb1bbf67c7adbb6c5d2
comment:209 Changed 7 years ago by Russell Taylor
Re #6371. Lower logging level for monitor check.
The live stream doesn't have monitors, so we don't want to normally see this log message over and over.
Changeset: 3904f8256c2a72b0059b64c6a56f92e850bb0e63
comment:210 Changed 7 years ago by Russell Taylor
Re #6371. Add a test for the last change to this algorithm.
Confirmed that without the fix, this test would fail.
Changeset: 2c83215addbe14093d8848099c9b9e57703c7e8f
comment:211 Changed 7 years ago by Russell Taylor
Re #6371. Remove temp file that I added mistakenly some months ago.
Changeset: 672d7ded5de625b7c1f9d24bb6958c664861ad93
comment:212 Changed 7 years ago by Russell Taylor
Re #6371. Improve some error messages.
Changeset: c843c1c8fa3df1a3f0a0396fcbe73df8d79b6139
comment:213 Changed 7 years ago by Russell Taylor
Re #6371. Some protection against an empty log.
Changeset: a83b4489a9c57d93f20e0463875ec3170f2852fe
comment:214 Changed 7 years ago by Russell Taylor
Re #6371. Further improvement to error messages.
Changeset: d3077b4810f5a8b9d3b0f8445c9cdb98abf65f35
comment:215 Changed 7 years ago by Russell Taylor
Re #6371. For now, need to keep even unchanging logs.
Pending resolution of #6886.
Changeset: 4c885687ff6f65db8bc384c5913d5e7ccce747d4
comment:216 Changed 7 years ago by Russell Taylor
Re #6371. Forgot about the test for previous commit.
Changeset: e8b3532f82c598b1578d13a5c3b696d76b9d9b6b
comment:217 Changed 7 years ago by Russell Taylor
Re #6371. Be sure not to try and use an empty proton charge log.
Changeset: 1b32b1934ce1b5ed3a75681c2e3b9740eba9c8ae
comment:218 Changed 7 years ago by Russell Taylor
Re #6371. Include only varying logs in the combobox.
Changeset: 19a748b65058869b38bf9f0e1ee9aace12bb9ebf
comment:219 Changed 7 years ago by Russell Taylor
Re #6371. Minor changes - better memory management in test.
Changeset: c62c509620c3a883555caa368382f73363010096
comment:220 Changed 7 years ago by Russell Taylor
Re #6371. Tests for getFirst/LastPulseTime.
Changeset: f4439aec3b4921eb7f2b079c71ce84b98b1a958e
comment:221 Changed 7 years ago by Russell Taylor
Re #6371. Tidy up of getFirst/LastPulseTime.
The (!log) tests were redundant - the previous lines will throw if the property isn't there.
Changeset: b61425fd5784b98f510129e4eb50822808303e44
comment:222 Changed 7 years ago by Russell Taylor
Re #6371. Add busy cursors when running algorithms.
My experience so far is that running the algorithms is fairly fast. This leads me to think that I may not need to run things asynchronously.
Changeset: 8ee72d8273f866170491f41f07c77b57972b51d4
comment:223 Changed 7 years ago by Russell Taylor
Re #6371. Lower the logging level on connection.
In general, the calling factory class should be handling reporting here. Specifically, I want to silently attempt a connection in the background without the user seeing it.
Changeset: 81948528b643632f826f12b211a290ba7fd0845e
comment:224 Changed 7 years ago by Russell Taylor
Re #6371. Avoid trying to reload same file over and over.
I was having problems on the mac with this slot being invoked every time the filename box lost focus, leading to getting stuck in a loop if an invalid file had been loaded. For some reason I didn't see this on RHEL6.
Changeset: f87a789205b59288ca9239684a7e17d7934bfa0f
comment:225 Changed 7 years ago by Russell Taylor
Re #6371. Probably a better clean-up order.
Changeset: c6bd9d5ce1da4252c83e972c50e0d0fa7fe3695f
comment:226 Changed 7 years ago by Russell Taylor
Re #6371. Add a help button.
Changeset: 72c680657ebcb761476dfe2f7abdf63279597cec
comment:227 Changed 7 years ago by Russell Taylor
Re #6371. Check whether the input table is empty, fail if it is.
The algorithm previously would fail, but with a cryptic error message at the point it tried to create the output workspace. This is more obvious.
Changeset: 56307ceaadf0dab14038020978d444d5ab71f80e
comment:228 Changed 7 years ago by Russell Taylor
Re #6371. Don't remove the row for scan_index=1 if it's the only one.
Changeset: 22bbd6b9a5ae74ec10dbdfbf848bde08de4c785e
comment:229 Changed 7 years ago by Russell Taylor
Re #6371. Add code to allow use with live data.
Changeset: fb143450e8947721306ebe6399cd80794292609f
comment:230 Changed 7 years ago by Russell Taylor
Re #6371. Well it worked for me...
Changeset: e824827099b07d69fdf95ca252750a60a6bbdcdd
comment:231 Changed 7 years ago by Russell Taylor
Re #6371. Left in a local testing line by mistake.
Also temporarily remove check that logs have more than one value for testing live client.
Changeset: cff5b488266ebdcf80c601f0c4d9e81576436a21
comment:232 Changed 7 years ago by Russell Taylor
Re #6371. Temporarily remove assert while testing live.
Changeset: e766e6d2589b166afba1598e37fd19c3a11888d1
comment:233 Changed 7 years ago by Russell Taylor
Re #6371. Always enable live button pending debugging of that code.
Changeset: dd5148fe0f60c16d4dbba10b115fd49196bc5c47
comment:234 Changed 7 years ago by Russell Taylor
Re #6371. Be sure to call the derived class create method.
Changeset: 2419d632511a9bedbae9f3548708ea7a7afec2e6
comment:235 Changed 7 years ago by Russell Taylor
Re #6371. Reset some things when deselecting the live listener.
Changeset: ca2a4f29e6b6f30a8528933b6d0005fffda15f0c
comment:236 Changed 7 years ago by Russell Taylor
Re #6371. Final log value is considered to last to end of run.
Also add back in check that keeps logs that don't change out of the result.
Changeset: 1d64d733f1b6e9c959fa7cb1bbf67c7adbb6c5d2
comment:237 Changed 7 years ago by Russell Taylor
Re #6371. Lower logging level for monitor check.
The live stream doesn't have monitors, so we don't want to normally see this log message over and over.
Changeset: 3904f8256c2a72b0059b64c6a56f92e850bb0e63
comment:238 Changed 7 years ago by Russell Taylor
Re #6371. Add a test for the last change to this algorithm.
Confirmed that without the fix, this test would fail.
Changeset: 2c83215addbe14093d8848099c9b9e57703c7e8f
comment:239 Changed 7 years ago by Russell Taylor
Re #6371. Remove temp file that I added mistakenly some months ago.
Changeset: 672d7ded5de625b7c1f9d24bb6958c664861ad93
comment:240 Changed 7 years ago by Russell Taylor
Re #6371. Improve some error messages.
Changeset: c843c1c8fa3df1a3f0a0396fcbe73df8d79b6139
comment:241 Changed 7 years ago by Russell Taylor
Re #6371. Some protection against an empty log.
Changeset: a83b4489a9c57d93f20e0463875ec3170f2852fe
comment:242 Changed 7 years ago by Russell Taylor
Re #6371. Further improvement to error messages.
Changeset: d3077b4810f5a8b9d3b0f8445c9cdb98abf65f35
comment:243 Changed 7 years ago by Russell Taylor
Re #6371. For now, need to keep even unchanging logs.
Pending resolution of #6886.
Changeset: 4c885687ff6f65db8bc384c5913d5e7ccce747d4
comment:244 Changed 7 years ago by Russell Taylor
Re #6371. Forgot about the test for previous commit.
Changeset: e8b3532f82c598b1578d13a5c3b696d76b9d9b6b
comment:245 Changed 7 years ago by Russell Taylor
Re #6371. Be sure not to try and use an empty proton charge log.
Changeset: 1b32b1934ce1b5ed3a75681c2e3b9740eba9c8ae
comment:246 Changed 7 years ago by Russell Taylor
Re #6371. Include only varying logs in the combobox.
Changeset: 19a748b65058869b38bf9f0e1ee9aace12bb9ebf
comment:247 Changed 7 years ago by Russell Taylor
Re #6371. Minor changes - better memory management in test.
Changeset: c62c509620c3a883555caa368382f73363010096
comment:248 Changed 7 years ago by Russell Taylor
Re #6371. Tests for getFirst/LastPulseTime.
Changeset: f4439aec3b4921eb7f2b079c71ce84b98b1a958e
comment:249 Changed 7 years ago by Russell Taylor
Re #6371. Tidy up of getFirst/LastPulseTime.
The (!log) tests were redundant - the previous lines will throw if the property isn't there.
Changeset: b61425fd5784b98f510129e4eb50822808303e44
comment:250 Changed 7 years ago by Russell Taylor
Re #6371. Add busy cursors when running algorithms.
My experience so far is that running the algorithms is fairly fast. This leads me to think that I may not need to run things asynchronously.
Changeset: 8ee72d8273f866170491f41f07c77b57972b51d4
comment:251 Changed 7 years ago by Russell Taylor
Re #6371. Lower the logging level on connection.
In general, the calling factory class should be handling reporting here. Specifically, I want to silently attempt a connection in the background without the user seeing it.
Changeset: 81948528b643632f826f12b211a290ba7fd0845e
comment:252 Changed 7 years ago by Russell Taylor
Re #6371. Avoid trying to reload same file over and over.
I was having problems on the mac with this slot being invoked every time the filename box lost focus, leading to getting stuck in a loop if an invalid file had been loaded. For some reason I didn't see this on RHEL6.
Changeset: f87a789205b59288ca9239684a7e17d7934bfa0f
comment:253 Changed 7 years ago by Russell Taylor
Re #6371. Probably a better clean-up order.
Changeset: c6bd9d5ce1da4252c83e972c50e0d0fa7fe3695f
comment:254 Changed 7 years ago by Russell Taylor
Re #6371. Add a help button.
Changeset: 72c680657ebcb761476dfe2f7abdf63279597cec
comment:255 Changed 7 years ago by Russell Taylor
Re #6371. Check whether the input table is empty, fail if it is.
The algorithm previously would fail, but with a cryptic error message at the point it tried to create the output workspace. This is more obvious.
Changeset: 56307ceaadf0dab14038020978d444d5ab71f80e
comment:256 Changed 7 years ago by Russell Taylor
Re #6371. Don't remove the row for scan_index=1 if it's the only one.
Changeset: 22bbd6b9a5ae74ec10dbdfbf848bde08de4c785e
comment:257 Changed 7 years ago by Russell Taylor
Re #6371. Add code to allow use with live data.
Changeset: fb143450e8947721306ebe6399cd80794292609f
comment:258 Changed 7 years ago by Russell Taylor
Re #6371. Well it worked for me...
Changeset: e824827099b07d69fdf95ca252750a60a6bbdcdd
comment:259 Changed 7 years ago by Russell Taylor
Re #6371. Left in a local testing line by mistake.
Also temporarily remove check that logs have more than one value for testing live client.
Changeset: cff5b488266ebdcf80c601f0c4d9e81576436a21
comment:260 Changed 7 years ago by Russell Taylor
Re #6371. Temporarily remove assert while testing live.
Changeset: e766e6d2589b166afba1598e37fd19c3a11888d1
comment:261 Changed 7 years ago by Russell Taylor
Re #6371. Always enable live button pending debugging of that code.
Changeset: dd5148fe0f60c16d4dbba10b115fd49196bc5c47
comment:262 Changed 7 years ago by Russell Taylor
Re #6371. Be sure to call the derived class create method.
Changeset: 2419d632511a9bedbae9f3548708ea7a7afec2e6
comment:263 Changed 7 years ago by Russell Taylor
Re #6371. Reset some things when deselecting the live listener.
Changeset: ca2a4f29e6b6f30a8528933b6d0005fffda15f0c
comment:264 Changed 7 years ago by Russell Taylor
Re #6371. Final log value is considered to last to end of run.
Also add back in check that keeps logs that don't change out of the result.
Changeset: 1d64d733f1b6e9c959fa7cb1bbf67c7adbb6c5d2
comment:265 Changed 7 years ago by Russell Taylor
Re #6371. Lower logging level for monitor check.
The live stream doesn't have monitors, so we don't want to normally see this log message over and over.
Changeset: 3904f8256c2a72b0059b64c6a56f92e850bb0e63
comment:266 Changed 7 years ago by Russell Taylor
Re #6371. Add a test for the last change to this algorithm.
Confirmed that without the fix, this test would fail.
Changeset: 2c83215addbe14093d8848099c9b9e57703c7e8f
comment:267 Changed 7 years ago by Russell Taylor
Re #6371. Remove temp file that I added mistakenly some months ago.
Changeset: 672d7ded5de625b7c1f9d24bb6958c664861ad93
comment:268 Changed 7 years ago by Russell Taylor
Re #6371. Improve some error messages.
Changeset: c843c1c8fa3df1a3f0a0396fcbe73df8d79b6139
comment:269 Changed 7 years ago by Russell Taylor
Re #6371. Some protection against an empty log.
Changeset: a83b4489a9c57d93f20e0463875ec3170f2852fe
comment:270 Changed 7 years ago by Russell Taylor
Re #6371. Further improvement to error messages.
Changeset: d3077b4810f5a8b9d3b0f8445c9cdb98abf65f35
comment:271 Changed 7 years ago by Russell Taylor
Re #6371. For now, need to keep even unchanging logs.
Pending resolution of #6886.
Changeset: 4c885687ff6f65db8bc384c5913d5e7ccce747d4
comment:272 Changed 7 years ago by Russell Taylor
Re #6371. Forgot about the test for previous commit.
Changeset: e8b3532f82c598b1578d13a5c3b696d76b9d9b6b
comment:273 Changed 7 years ago by Russell Taylor
Re #6371. Be sure not to try and use an empty proton charge log.
Changeset: 1b32b1934ce1b5ed3a75681c2e3b9740eba9c8ae
comment:274 Changed 7 years ago by Russell Taylor
Re #6371. Include only varying logs in the combobox.
Changeset: 19a748b65058869b38bf9f0e1ee9aace12bb9ebf
comment:275 Changed 7 years ago by Russell Taylor
Re #6371. Minor changes - better memory management in test.
Changeset: c62c509620c3a883555caa368382f73363010096
comment:276 Changed 7 years ago by Russell Taylor
Re #6371. Tests for getFirst/LastPulseTime.
Changeset: f4439aec3b4921eb7f2b079c71ce84b98b1a958e
comment:277 Changed 7 years ago by Russell Taylor
Re #6371. Tidy up of getFirst/LastPulseTime.
The (!log) tests were redundant - the previous lines will throw if the property isn't there.
Changeset: b61425fd5784b98f510129e4eb50822808303e44
comment:278 Changed 7 years ago by Russell Taylor
Re #6371. Add busy cursors when running algorithms.
My experience so far is that running the algorithms is fairly fast. This leads me to think that I may not need to run things asynchronously.
Changeset: 8ee72d8273f866170491f41f07c77b57972b51d4
comment:279 Changed 7 years ago by Russell Taylor
Re #6371. Lower the logging level on connection.
In general, the calling factory class should be handling reporting here. Specifically, I want to silently attempt a connection in the background without the user seeing it.
Changeset: 81948528b643632f826f12b211a290ba7fd0845e
comment:280 Changed 7 years ago by Russell Taylor
Re #6371. Avoid trying to reload same file over and over.
I was having problems on the mac with this slot being invoked every time the filename box lost focus, leading to getting stuck in a loop if an invalid file had been loaded. For some reason I didn't see this on RHEL6.
Changeset: f87a789205b59288ca9239684a7e17d7934bfa0f
comment:281 Changed 7 years ago by Russell Taylor
Re #6371. Probably a better clean-up order.
Changeset: c6bd9d5ce1da4252c83e972c50e0d0fa7fe3695f
comment:282 Changed 7 years ago by Russell Taylor
Re #6371. Add a help button.
Changeset: 72c680657ebcb761476dfe2f7abdf63279597cec
comment:283 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7217
