Ticket #6392 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Review Rebinning Controls on Slice Viewer

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.5
Component: VATES Keywords:
Cc: Blocked By: #6272
Blocking: #6727 Tester: Karl Palmen

Description (last modified by Owen Arnold) (diff)

Inconsistent, and hard to understand controls in the SliceViewer

  • The Rebin button rebins only the current slice point within the viewing extents.
  • The refresh button has to be invoked every time the view is panned or zoomed.
  • The auto rebin button automatically applies the refresh.
  • The lock button when unlock auto rebins to the current slice point (as sliders are moved)

The point of this ticket is to get agreement of what the new behaviour should be like. I'm going to generate some mockups and share them with a few selected people from both sites. Work can then commence (probably under a separate ticket) once a specification has been agreed upon.

Attachments

ExistingRebinningControls.png (2.7 KB) - added by Owen Arnold 8 years ago.
ProposalRebinningControls1.png (2.2 KB) - added by Owen Arnold 8 years ago.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted
  • Description modified (diff)

These are the existing controls (see ExistingRebinningControls attachment) and are from left to right as follows:

  • The rebin button
  • The refresh button
  • The auto rebin button
  • The lock button.

See the ticket description for an outline on what each of these functions do.

Last edited 8 years ago by Owen Arnold (previous) (diff)

Changed 8 years ago by Owen Arnold

Changed 8 years ago by Owen Arnold

comment:2 Changed 8 years ago by Owen Arnold

My first proposal is to combine all the functionality of the lock and auto-rebin into a single toggle (see PropsalRebinningControls1 attachement). I'm proposing that we use the Lock icon for this. The refresh and rebin buttons are unaffected, and would do what they currently do.

comment:3 Changed 8 years ago by Owen Arnold

Quote from Peter Peterson regarding my first proposal

"That is a good idea. Have at it."

comment:4 Changed 8 years ago by Owen Arnold

Nick has asked that in the process of doing this, we also update the rebinning icon on the slice viewer.

comment:5 Changed 8 years ago by Owen Arnold

  • Blocking 6727 added

comment:6 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: There's not much to test here. This ticket has been about seeking agreement and documenting the agreed course of action to take. You might satisfy yourself that the proposal seems logical. Action implementation is happening under another ticket.

comment:7 Changed 8 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:8 Changed 8 years ago by Karl Palmen

  • Status changed from verifying to closed

So you'll do auto-rebinning by locking (if not locked) then unlocking. This makes logical sense, because unlocking already does auto-rebinning.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7238

Note: See TracTickets for help on using tickets.