Ticket #6455 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Expose DetectorGroup::getNameSeparator to Python

Reported by: Martyn Gigg Owned by: Karl Palmen
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Users may want to retrieve the separator for the name list so make it available.

Attachments

testDetGroup.py (785 bytes) - added by Karl Palmen 8 years ago.

Change History

comment:1 Changed 8 years ago by Karl Palmen

I've had a look into this. I find I cannot expose getNameSeparator like I did with getFullName, because I exposed the latter within IComponent and getNameSeparator is not in IComponent. I might be able expose it within DetectorGroup, but as there are no other functions exposed within DetectorGroup, I'd need some help here.

comment:2 Changed 8 years ago by Martyn Gigg

The function is only applicable and indeed only defined on a DetectorGroup so it should be exposed there.

DetectorGroup currently has one other method exposed, getDetectorIDs, see Code/Mantid/Framework/PythonInterface/mantid/geometry/src/Exports/DetectorGroup.cpp

comment:3 Changed 8 years ago by Karl Palmen

Thank you Martyn for letting me know.

comment:4 Changed 8 years ago by Karl Palmen

  • Status changed from new to accepted

comment:5 Changed 8 years ago by Karl Palmen

The function getNameSeparator was declared as protected and needed to by changed to public for exposure to compile.

Changed 8 years ago by Karl Palmen

comment:6 Changed 8 years ago by Karl Palmen

The attached python file testDetGroup.py tests this.

comment:7 Changed 8 years ago by Karl Palmen

Expose the function to Python re #6455

Still need to write python script to test this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: ba3a1b831c07f25d06dae8fb914119e6c583f509

comment:8 Changed 8 years ago by Karl Palmen

Expose the function to Python re #6455

Still need to write python script to test this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: ba3a1b831c07f25d06dae8fb914119e6c583f509

comment:9 Changed 8 years ago by Karl Palmen

The branch is 6455_expose_det_group_sep and it can be tested by running the attached scripr testDetGroup.py or similar.

comment:10 Changed 8 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:11 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:12 Changed 8 years ago by Karl Palmen

Expose the function to Python re #6455

Still need to write python script to test this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: ba3a1b831c07f25d06dae8fb914119e6c583f509

comment:13 Changed 8 years ago by Karl Palmen

Expose the function to Python re #6455

Still need to write python script to test this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: ba3a1b831c07f25d06dae8fb914119e6c583f509

comment:14 Changed 7 years ago by Karl Palmen

Expose the function to Python re #6455

Still need to write python script to test this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: ba3a1b831c07f25d06dae8fb914119e6c583f509

comment:15 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:16 Changed 7 years ago by Karl Palmen

Expose the function to Python re #6455

Still need to write python script to test this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: ba3a1b831c07f25d06dae8fb914119e6c583f509

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7301

Note: See TracTickets for help on using tickets.