Ticket #6460 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Enable TableWorkspace comparison in CheckWorkspacesMatch

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 3.0
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #7604 Tester: Samuel Jackson

Description (last modified by Russell Taylor) (diff)

I need this for a system test for the RockingCurve workflow algorithm.

While I'm there, some tidying up looks to be a good idea - there's an awful lot in the one, very long, doComparison method.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:2 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:4 Changed 7 years ago by Russell Taylor

  • Milestone changed from Backlog to Release 3.0

comment:5 Changed 7 years ago by Russell Taylor

  • Blocking 7604 added

comment:6 Changed 7 years ago by Russell Taylor

  • Status changed from new to inprogress

Re #6460. Move event list checking into its own method.

Changeset: ef48c1c99d19ab43aa714e8bbebb14ba05006e7c

comment:7 Changed 7 years ago by Russell Taylor

Re #6460. Only apply 'CheckType' option to event workspaces.

This algorithm property is only applicable to event workspaces (as the property documentation states) but was being used for MD & Peaks workspaces. However, the outcome if you pass in one of these workspace types along with something else is a crash if the CheckType property is false.

Therefore, always enforce a match for these types.

Changeset: dc3f86425f05af59754cd413ed890030054c5ab0

comment:8 Changed 7 years ago by Russell Taylor

Re #6460. Move PeaksWorkspace checking into its own method.

Changeset: 1086b47f4b3096833df04373dc309b2ac4d23f82

comment:9 Changed 7 years ago by Russell Taylor

Re #6460. Add ability to compare TableWorkspaces.

Changeset: a529d5171f5eaded0d2e2f60bce52b8dde633449

comment:10 Changed 7 years ago by Russell Taylor

Re #6460. Additional test.

Changeset: c24adb62f8e8709d88994adf378cd75d1df08b15

comment:11 Changed 7 years ago by Russell Taylor

Re #6460. Another test.

Changeset: 1613f09381a769211d3d64eb45d85919b6a84ada

comment:12 Changed 7 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

To Test: Create a couple of TableWorkspaces somehow (N.B. not PeaksWorkspaces) and make sure that the algorithm flags up different tables but passes if they match (e.g. if you pass the same table as both input workspaces). Note also that there's a system test - StepScan - in the develop branch that's using this new functionality.

comment:13 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:14 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/6460_check_table_workspaces_match'

Full changeset: ​b7464de463894ae100f6e7b1bcd09f755124f9b7

comment:15 Changed 7 years ago by Samuel Jackson

Made some table workspaces and tried comparing tables with differing columns & rows, equal tables, a table and a matrix workspace etc. All worked as I expected.

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7306

Note: See TracTickets for help on using tickets.