Ticket #6521 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

PeaksViewer compatible workspaces

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.5
Component: VATES Keywords:
Cc: Blocked By:
Blocking: #6820 Tester: Gesner Passos

Description

Whether a given MDWorkspace plotted in the SliceViewer is compatible with the PeaksViewer functionality is currently the subject of a Regular expression on the Workspaces' axes.

It is currently possible to 'fool' the PeaksViewer into enabling itself when it shouldn't simply by creating a dummy mdworkspace, via CreateMDWorkspace (i.e. with dimensions named H, K, L).

The following rules for enabling/using the PeaksViewer would be better:

  • Inspect getSpecialCoordinates() on the mdworkspace. If the workspace doesn't have this set, keep going but create a log warning about the fact we are guessing what special coordinates the workspace is in.
  • If the workspace does have a known value for getSpecialCoordinates, try to match the dimension names according to the current regex scheme. If these are incompatible, give up and log an error. For example if getSpecialCoordinates are HKL and the Dimensions are Q_lab_x, Q_lab_y, Q_lab_z.

We should also check the compatibility of the specialcoordinates that were set when the PW was integrated and the current special coordinates of the viewing MDWorkspace, but this will be the subject of another ticket.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted
  • Owner set to Owen Arnold

comment:2 Changed 8 years ago by Owen Arnold

refs #6521 emit status.

Changeset: 7c18149bee9cf30c55c3a281e60f56ae3ee2d639

comment:3 Changed 8 years ago by Owen Arnold

refs #6521 #6542. Evaluate and inform on compatible workspaces.

Handle the case that the mdworkspace does not appear self-consistent. Also handle the case where an integrated peaks workspace is being viewed in a coordinate system that is not the same as the one it was integrated in.

Changeset: 2eb6418b5be1594f74824c81ca32c56805646b57

comment:4 Changed 8 years ago by Owen Arnold

refs #6521 #6542 small modification to warning.

Changeset: 7335416bbd076ee904661a62cc39a6b7f2a61e23

comment:5 Changed 8 years ago by Owen Arnold

refs #6521 #6542 quality enum for vc++.

Changeset: 65b1e2ec63a1412d990fe683a1e3c2dd23a7b483

comment:6 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester:

To follow these steps you should first be familiar with the functionality of the PeaksViewer. This has been documented on the wiki http://www.mantidproject.org/PeaksViewer. It would also be helpful to look at the Diffraction_Workflow_Test.py test in the Analysis system tests, as this will serve as a useful guide for generating some real input workspaces.

  • Change the log level in MantidPlot to notice
  • Find an input workspace containing some strong Single Crystal Peaks (see Diffraction_Workflow_Test)
  • Create an MDWorkspace to QLab
  • Run FindPeaksMD
  • Open the MDWorkspace and PeaksWorkspace in the SliceViewer and PeaksViewer.
  • There should be no notice information about this action
  • Close the SliceViewer
  • Run SetSpecialCoordinates on the MDWorkspace and set the coordinates QSample
  • Now open reopen the MDWorkspace and PeaksWorkspace in the Sliceviewer and PeaksViewer
  • There should be a notification error describing the conflict and explaining the corrective action taken.

comment:7 Changed 8 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:8 Changed 8 years ago by Gesner Passos

  • Status changed from verifying to closed

Following the test procedure, you get the exactly result described.

comment:9 Changed 8 years ago by Owen Arnold

  • Blocking 6820 added

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7367

Note: See TracTickets for help on using tickets.