Ticket #6542 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Match Peak and MDWorkspaces

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.5
Component: VATES Keywords:
Cc: Blocked By:
Blocking: Tester: Gesner Passos

Description

Similar to #6521

The peaks workspace should 'know' what coordinate system it was created in. It should warn about usage in the PeaksViewer in any other coordinate system.

Change History

comment:1 Changed 8 years ago by Owen Arnold

refs #6521 #6542. Evaluate and inform on compatible workspaces.

Handle the case that the mdworkspace does not appear self-consistent. Also handle the case where an integrated peaks workspace is being viewed in a coordinate system that is not the same as the one it was integrated in.

Changeset: 2eb6418b5be1594f74824c81ca32c56805646b57

comment:2 Changed 8 years ago by Owen Arnold

refs #6521 #6542 small modification to warning.

Changeset: 7335416bbd076ee904661a62cc39a6b7f2a61e23

comment:3 Changed 8 years ago by Owen Arnold

refs #6521 #6542 quality enum for vc++.

Changeset: 65b1e2ec63a1412d990fe683a1e3c2dd23a7b483

comment:4 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:5 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester:

Follow the first set of instructions (including the first set of bullet points) given with the test instructions for #6521. You should now have an MDWorkspace and PeaksWorkspace loaded in the PeaksViewer/SliceViewer, with no notifications relating to the current set of actions.

  • Close the SliceViewer
  • Run SetSpecialCoordinates on the PeaksWorkspace generated via FindPeaksMD setting the coordinates to HKL
  • Reopen the MDWorkspace and PeaksWorkspace in the SliceViewer/PeaksViewer.
  • You should get NO notification errors or warnings.
  • Now integrate the PeaksWorkspace using IntegratePeaksMD and then repeat the bullet points above.
  • You should now get a notification error explaining that the peaks will look distorted because they are being viewed in a different coordinate system to the one they were integrated in.

comment:6 Changed 8 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:7 Changed 8 years ago by Gesner Passos

  • Status changed from verifying to closed

Following the test procedure, you get the exactly result described.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7388

Note: See TracTickets for help on using tickets.