Ticket #6572 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Eliminate code duplication between AppendSpectra & ConjoinWorkspaces

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: minor Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: #6142 Tester: Karl Palmen

Description

cpd highlights a large amount of code shared between the source files of these algorithms. This is not too surprising as they are basically the same algorithm, with the essential difference being that the former allows a separate output workspace while the later absorbs the second input workspace into the first (or more accurately into a workspace with the same name as the first).

Change History

comment:1 Changed 8 years ago by Russell Taylor

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Russell Taylor

Re #6572. Consolidate code between AppendSpectra & ConjoinWorkspaces

by creating a common base class. This should satisfy cpd, though not me yet.

Changeset: 0321b7dcc848f7937289b2276b16250bbda864d4

comment:3 Changed 8 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

This'll do. There is some duplication (or near duplication) still there, but it's mainly down to the fact that the algorithms do things subtly differently. The differences are at least documented.

comment:4 Changed 8 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:5 Changed 8 years ago by Karl Palmen

  • Status changed from verifying to closed

Changeset shows that such a change has been made and unit tests have indicated it would work.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7418

Note: See TracTickets for help on using tickets.