Ticket #6593 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

small refactoring of FFT

Reported by: Jose Borreguero Owned by: Jose Borreguero
Priority: trivial Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Karl Palmen

Description

  • Updating the Wiki
  • remove instances of variables with same names
  • consistently use variable bool shift

Change History

comment:1 Changed 8 years ago by Jose Borreguero

Refs #6593 Small changes

touched on the Wiki renamed bool shift to bool centerShit inserted explanations for the details of the algorithm

Changeset: 66b28cd9d1d0fde3837a8a309603e9351d9c6f5d

comment:2 Changed 8 years ago by Jose Borreguero

Refs #6593 Fix introduced errors related to variable dys

modified: ../../Mantid/Framework/Algorithms/src/FFT.cpp

Changeset: c1046c98687db5910c433aa07ead849acdb2737e

comment:3 Changed 8 years ago by Jose Borreguero

Refs #6593 Small changes

touched on the Wiki renamed bool shift to bool centerShit inserted explanations for the details of the algorithm

Changeset: 5e13fb4debdc387fe065d5387904ef30f55e01d1

comment:4 Changed 8 years ago by Jose Borreguero

Refs #6593 Fix introduced errors related to variable dys

modified: ../../Mantid/Framework/Algorithms/src/FFT.cpp

Changeset: de093b06eec983834d1a3d85077ed840528e07ba

comment:5 Changed 8 years ago by Jose Borreguero

  • Status changed from new to accepted
  • Priority changed from minor to trivial

comment:6 Changed 8 years ago by Jose Borreguero

  • Status changed from accepted to verify
  • Resolution set to fixed

There's really no testing neccessary, since it was only updating the wiki and renaming boolean variable shift to avoid confusion with double variable shift

comment:7 Changed 8 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:8 Changed 8 years ago by Karl Palmen

  • Status changed from verifying to closed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7439

Note: See TracTickets for help on using tickets.