Ticket #6607 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Eliminate the use of LoadIsawPeaks and SaveIsawPeaks in SCDCalibratePanels

Reported by: Ruth Mikkelson Owned by: Ruth Mikkelson
Priority: minor Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Dereck Kachere

Description

In Topaz, the saveIsawPeaks algorithm saves All the panels to the DetCal file, even the ones( about half) that do not exist yet.

The LoadIsawPeaks algorithm takes too long because of all the unused panels. The SCDAlgorithm has access to the base instrument so there is no need to use the LoadInstrument Algorithm.

Attachments

Fit.integrate (975.6 KB) - added by Ruth Mikkelson 8 years ago.
Test Peaks File
Fit.mat (564 bytes) - added by Ruth Mikkelson 8 years ago.
Crystal Orientation file( ISAW Format)

Change History

comment:1 Changed 8 years ago by Ruth Mikkelson

  • Owner set to Ruth Mikkelson
  • Status changed from new to accepted

comment:2 Changed 8 years ago by Ruth Mikkelson

Refs #6607 Replace Save and LoadIsawPeaks algorithms

Refs #6086 Changed some Wiki documentation

Changeset: 91df656aefd0e87df034e0d360c2c11b4943edf5

comment:3 Changed 8 years ago by Ruth Mikkelson

Refs #6607 Eliminated compiler warning on snowleopard(I hope)

Changeset: 67bd39ae6506a89570595bec671a799842cd015b

Changed 8 years ago by Ruth Mikkelson

Test Peaks File

Changed 8 years ago by Ruth Mikkelson

Crystal Orientation file( ISAW Format)

comment:4 Changed 8 years ago by Ruth Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

The changes have already been merged into master. Technical difficulties caused problems in closing this ticket last week.

Also, last week loading an ISAW DetCal file for TOPAZ runs above 6300 took 20 sec. That is no longer the case this week. The SaveISAWDetCal algorithm also, this week, does not include a lot of non-existent detectors.

Attached are two files to use for testing. You will have to use LoadIsawPeaks to load the peaks file, then LoadIsawUB to load the mat file. Then IndexPeaks to index the peaks.

Run SCDCalibratePanels with inputs of Peaks,OnePanelPerGroup,abc_alpha..=4.785,4.785,12.991,90,90,120. Check all boxes and set tolerance=.12. The Filenames are where the results go. The rest of the options can be defaults, though it should be run a second time with preprocessInstrument=B)Apply a ISAW DetCal file. The name of this DetCal file is the result from the first run.

If you are working in MantidPlot, debug mode can be enabled. You will get a lot of output.

comment:5 Changed 8 years ago by Dereck Kachere

  • Status changed from verify to verifying
  • Tester set to Dereck Kachere

comment:6 Changed 8 years ago by Dereck Kachere

  • Status changed from verifying to closed

Followed the testing instructions. There is indeed no need to use the LoadInstrument algorithm.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7453

Note: See TracTickets for help on using tickets.