Ticket #6611 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

MUON: Move Python from version 1 to 2

Reported by: Anders Markvardsen Owned by: Martyn Gigg
Priority: blocker Milestone: Release 2.5
Component: MantidPlot Keywords:
Cc: martyn.gigg@… Blocked By:
Blocking: Tester: Owen Arnold

Description

Go through the Muon code and check if any version one python code embeded in the muon gui code

Change History

comment:1 Changed 8 years ago by Anders Markvardsen

Parts move 1 -> 2 python. re #6611

Changeset: 33162699af543bc5acc3672b343e6a5fc3970656

comment:2 Changed 8 years ago by Anders Markvardsen

Python v1 to v2 for muon. re #6611

Changeset: 8aea3c9af41521f250384aa3b912d6d37170e158

comment:3 Changed 8 years ago by Anders Markvardsen

  • Status changed from new to accepted

Quit a few changes was made to move from v1 from v2. I did a reasonable amount of tested during this process. But it would be good if the tester as a minimum do

  1. Load MUSR data from AutoTestData
  2. try the + and - of periods
  3. go to the Data Analysis tab and do a fit of a dataset

comment:4 Changed 8 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 8 years ago by Anders Markvardsen

fixed redhat build. re #6611

Owen pointed that I had broken build and forward declaration in header

Changeset: 8531c5b83829cd3e976a9aad460ced3adbc6bbb2

comment:6 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:7 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Confirm changing to v2 python api and in many cases to C++ api.

comment:8 Changed 8 years ago by Anders Markvardsen

Python v1 to v2 for muon. re #6611

Changeset: 8aea3c9af41521f250384aa3b912d6d37170e158

comment:9 Changed 8 years ago by Martyn Gigg

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:10 Changed 8 years ago by Martyn Gigg

  • Owner changed from Anders Markvardsen to Martyn Gigg
  • Status changed from reopened to accepted

Linux builds are broken on master. Somehow the commit from comment 5 didn't get merged properly. Don't have a clue how this has happened.

New branch feature/6611_muon_python to fix Linux.

comment:11 Changed 8 years ago by Martyn Gigg

Remove class qualification from MuonAnalysis member. Refs #6611

Changeset: 97d104d780d41d1b5b46199810d418585f16e649

comment:12 Changed 8 years ago by Martyn Gigg

Merge branch 'feature/6611_muon_python' into develop. Refs #6611

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/MuonAnalysis.h

Changeset: 74a8a2a1d529cc8bfe3a71023c57b3748f3237bc

comment:13 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:14 Changed 8 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester changed from Roman Tolchenov to Owen Arnold

comment:15 Changed 8 years ago by Martyn Gigg

Remove class qualification from MuonAnalysis member. Refs #6611

Changeset: 97d104d780d41d1b5b46199810d418585f16e649

comment:16 Changed 8 years ago by Anders Markvardsen

Python v1 to v2 for muon. re #6611

Changeset: 8aea3c9af41521f250384aa3b912d6d37170e158

comment:17 Changed 8 years ago by Martyn Gigg

Remove class qualification from MuonAnalysis member. Refs #6611

Changeset: 97d104d780d41d1b5b46199810d418585f16e649

comment:18 Changed 8 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:19 Changed 8 years ago by Anders Markvardsen

Python v1 to v2 for muon. re #6611

Changeset: fec8808f8cb992d6c9ae5b4691fda4d436c8c898

comment:20 Changed 8 years ago by Martyn Gigg

Remove class qualification from MuonAnalysis member. Refs #6611

Changeset: 009c81182ad69c1339d89582152c9ad16ee54932

comment:21 Changed 8 years ago by Anders Markvardsen

Python v1 to v2 for muon. re #6611

Changeset: 8aea3c9af41521f250384aa3b912d6d37170e158

comment:22 Changed 8 years ago by Martyn Gigg

Remove class qualification from MuonAnalysis member. Refs #6611

Changeset: 97d104d780d41d1b5b46199810d418585f16e649

comment:23 Changed 7 years ago by Anders Markvardsen

fixed redhat build. re #6611

Owen pointed that I had broken build and forward declaration in header

Changeset: 8531c5b83829cd3e976a9aad460ced3adbc6bbb2

comment:24 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/6611_muon_python' into develop. Refs #6611

Conflicts:

Code/Mantid/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/MuonAnalysis.h

Changeset: 74a8a2a1d529cc8bfe3a71023c57b3748f3237bc

comment:25 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7457

Note: See TracTickets for help on using tickets.