Ticket #6632 (assigned)

Opened 8 years ago

Last modified 5 years ago

SANS: Improve Wide angle corrections

Reported by: Gesner Passos Owned by: Peter Parker
Priority: minor Milestone: Backlog
Component: SANS Keywords:
Cc: Blocked By: #6643
Blocking: Tester:

Description (last modified by Gesner Passos) (diff)

The Wide Angle correction was implemented at #6529. But, there are some todo things that was not covered at that ticket:

  • documentation of this algorithm
  • implement this algorithm in C++
  • validating input
  • error propagation

Change History

comment:1 Changed 8 years ago by Anders Markvardsen

Note before converting the python algorithm compare with how sns does similar corrections. Make this the first task of this ticket.

Also consider keepting this algorithm as a Python algorithm since no need to convert to C++ if the python code already provide the speed which the sans guys need

comment:2 Changed 8 years ago by Anders Markvardsen

  • Blocked By 6643 added

Note before completing this ticket complete #6643

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:4 Changed 7 years ago by Gesner Passos

  • Status changed from new to accepted

comment:5 Changed 7 years ago by Nick Draper

  • Status changed from accepted to assigned

comment:6 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after the code freeze for R2.6

comment:9 Changed 7 years ago by Gesner Passos

  • Component changed from Framework to SANS
  • Description modified (diff)

comment:10 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:11 Changed 7 years ago by Gesner Passos

It was decided that we do not need to migrate to C++, but the error propagation would be necessary. The documentation is already nice. (wiki page). The validation could be added, but it is not a great issue, because it is not used directly from users, but in the reduction.

comment:12 Changed 7 years ago by Nick Draper

  • Owner changed from Gesner Passos to Peter Parker

Ownership handed over to Peter

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7478

Note: See TracTickets for help on using tickets.