Ticket #6529 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

SANS: Wide angle corrections

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: critical Milestone: Release 2.5
Component: Mantid Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Anders Markvardsen

Description (last modified by Gesner Passos) (diff)

Implement the Wide Angle correction as described in the document attached: Wide_angle_corrections_SAMPLE.pdf.

Attachments

Wide_angle_corrections_SAMPLE.pdf (44.6 KB) - added by Gesner Passos 8 years ago.
Description of the task to implement
MASKSANS2D_123T_4m_Xpress_8mm.txt (2.1 KB) - added by Gesner Passos 8 years ago.
User file that may be used for test.
DIRECT_11971_4m_Rear_09Mar12.dat (8.0 KB) - added by Gesner Passos 8 years ago.
user file require this mask file
input_with_trans.csv (320 bytes) - added by Gesner Passos 8 years ago.
Batch file that may be used for testing

Change History

Changed 8 years ago by Gesner Passos

Description of the task to implement

Changed 8 years ago by Gesner Passos

User file that may be used for test.

comment:1 Changed 8 years ago by Gesner Passos

Tester:

Open SANS interface (Menu->Interface->SANS ISIS) Change instrument to SANS2D Load User File: MASKSANS2D_123T_4m_Xpress_8mm.txt​ Load Batch File: input_with_trans.csv​

Execute Reduce1D.

Change the option SAMPLE/PATH/ON -> to SAMPLE/PATH/OFF and check that the differences of both results fit the expected behavior described by the user:

The fitted M4 transmissions go down to ~0.5, so the differences at high angle should be large, the front detector does not well overlap the rear (though it was sick at the time). Results for (Sample – can) are ~0.3cm-1 at smallest Q, the wiggles around Q ~0.35 ang-1 are real.

comment:2 Changed 8 years ago by Gesner Passos

  • Status changed from new to accepted

Changed 8 years ago by Gesner Passos

user file require this mask file

Changed 8 years ago by Gesner Passos

Batch file that may be used for testing

comment:3 Changed 8 years ago by Gesner Passos

Add WavelenghtPixel dependent parameter for Q1D

TODO: ensure that the input is valid.

re #6529

Changeset: d8872dd8e5b2f9f05ac34f7df946bb36ae657e16

comment:4 Changed 8 years ago by Gesner Passos

Creation of Algorithm SANSSolidAngleCorrection

This algorithm was created as a python script to allow the scientist to check the algorithm and evaluate this feature. There are still things TODO:

  • documentation of this algorithm
  • implement this algorithm in C++
  • validating input
  • error propagation

But, it allows testing the new feature.

re #6529

Changeset: fffa2952d2f1ade2fdb56582236f894cb4ca4adc

comment:5 Changed 8 years ago by Gesner Passos

Implement the Wide Angle correction

re #6529

Changeset: 29e24652e0749e507987981471e34ffb3abef7e4

comment:6 Changed 8 years ago by Gesner Passos

Correct the SolidAngleCorrection Algorithm

Change the label to twoTheta and correct the exception message

re #6529

Changeset: 9d420cb8ca61210f51d6254c8112103ffab83927

comment:7 Changed 8 years ago by Gesner Passos

Correct the name of the Algorithm

The algorithm deal with the Wide Angle Correction and not with the solid angle. Besides, SolidAngleCorrection belongs to another algorithm.

re #6529

Changeset: fd5d3899ea08f258ecbdb9049f37c352ead3e032

comment:8 Changed 8 years ago by Gesner Passos

Correct the name of the file

re #6529

Changeset: cbbeeee7a397d231b47a1dbc1400e79083ef38da

comment:9 Changed 8 years ago by Gesner Passos

  • Status changed from accepted to verify
  • Resolution set to fixed
  • Description modified (diff)

comment:10 Changed 8 years ago by Gesner Passos

  • Description modified (diff)

comment:11 Changed 8 years ago by Gesner Passos

The #6632 will deal with the list of things TODO, so this ticket will be closed, so to be available for testings.

comment:12 Changed 8 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:13 Changed 8 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Richard needs this and have tested it. Note this algorithm is now public so it needs documentation urgently and some thoughts about how we may sync this with sns, therefore added #6643

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7375

Note: See TracTickets for help on using tickets.