Ticket #6656 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Investigate and fix the problem with absoulute normalization for ISIS inelastic instriments

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: nick.draper@… Blocked By:
Blocking: Tester: Gesner Passos

Description

Observed on MAPS

After recent changes in inelastic scripts/algorithms absolute normalization of the data does not work any more and the monochromatic vanadium integrals return 0.

The scripts are not covered by unit tests. This will become a problem when these scripts and mantid are updated for the next cycle as number of users/IS use these scripts for data reduction.

Change History

comment:1 Changed 8 years ago by Alex Buts

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Alex Buts

refs #6656 Modified Mari reduction to work with correct monovan file

Changeset: a94847bac5f69e2e912a0fdffce582cc434e5de8

comment:3 Changed 8 years ago by Alex Buts

refs #6656 Better(proper) diagnostics from DetectorEfficiencyCor

Changeset: 5943f288a9ad5180a81a1651c98f911b0b3af9c5

comment:4 Changed 8 years ago by Alex Buts

refs #6656 fixed incorrect brackets in LoadDetectorInfo

Changeset: c490d639a5be3db9a1eedf306aeb24d45e4832dd

comment:5 Changed 8 years ago by Alex Buts

refs #6656 warning on signed/unsigned comparison

Changeset: bcc0d84e98c78379c47d51d57c9d5ab02f720659

comment:6 Changed 8 years ago by Alex Buts

refs #6656 Fixed erroneous change to DirectEnergyConversion

Changeset: f567eacecaa65fa482a296ba6c3f75b203d2a696

comment:7 Changed 8 years ago by Alex Buts

refs #6656 Better(proper) diagnostics from DetectorEfficiencyCor

Changeset: 451d8b079a12ff33d301be7c3ba1838d15d36678

comment:8 Changed 8 years ago by Alex Buts

refs #6656 fixed incorrect brackets in LoadDetectorInfo

Changeset: d5e121d0690e3d9cd5b355e68a0d569ff280ab89

comment:9 Changed 8 years ago by Alex Buts

refs #6656 warning on signed/unsigned comparison

Changeset: e67aa858c313f9e17845c9e2594cdb9318438048

comment:10 Changed 8 years ago by Alex Buts

refs #6656 Fixed erroneous change to DirectEnergyConversion

Changeset: 3de7b26e1963546fa0c4a092d9882372ca24f9e3

comment:11 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

It is tricky to verify this ticket as the problem was related to custom reduction scripts, which are build and run outside of Mantid control.

The the test script below used to produce workspace with all 0 in it which was wrong. This does not happen any more and the target workspace (15181.spe) has some values in it. To check if the values are in fact correct one has to compare final result with Libisis and I have already done this.

The data files for this script are in ISIS data folders for MAPS and under open svn repository ​https://svn.isis.rl.ac.uk/InstrumentFiles/trunk/maps

I can provide tester with these files on request.

The main problem is in fact wider then solved by this ticket and is described by the ticket ref #6667 

LoadRaw(Filename=r'D:\Data\Fe\Feb2013\EI400\MAP15181.raw',OutputWorkspace='MAP15181.raw')
GetEi(InputWorkspace='MAP15181.raw',Monitor1Spec='41474',Monitor2Spec='41475',EnergyEstimate='400')
ChangeBinOffset(InputWorkspace='MAP15181.raw',OutputWorkspace='15181.spe',Offset='-1183.62979333')
MoveInstrumentComponent(Workspace='15181.spe',ComponentName='undulator',Z='-1.6950000000000001',RelativePosition='0')
LoadDetectorInfo(Workspace='15181.spe',DataFilename=r'C:\Users\wkc26243\Documents\work\Libisis\InstrumentFiles\maps\detector_095_libisis.nxs',RelocateDets='1')
AddSampleLog(Workspace='15181.spe',LogName='DirectInelasticReductionNormalisedBy',LogText='monitor-1')
ConvertUnits(InputWorkspace='15181.spe',OutputWorkspace='15181.spe',Target='DeltaE',EMode='Direct')
#
DetectorEfficiencyCor(InputWorkspace='15181.spe',OutputWorkspace='15181.spe')
#
CorrectKiKf(InputWorkspace='15181.spe',OutputWorkspace='15181.spe')
Rebin(InputWorkspace='15181.spe',OutputWorkspace='15181.spe',Params='-71,2,381',PreserveEvents='0')
GroupDetectors(InputWorkspace='15181.spe',OutputWorkspace='15181.spe',MapFile=r'C:\Users\wkc26243\Documents\work\Libisis\InstrumentFiles\maps\4to1_mid_lowang.map',Behaviour='Average')
Last edited 8 years ago by Alex Buts (previous) (diff)

comment:12 Changed 8 years ago by Alex Buts

refs #6656 Doxygen warning fixed

Changeset: 3f8c232c85c72f0c5455d1b4d92cc25d42d2b4bf

comment:13 Changed 8 years ago by Alex Buts

refs #6656 Better(proper) diagnostics from DetectorEfficiencyCor

Changeset: 451d8b079a12ff33d301be7c3ba1838d15d36678

comment:14 Changed 8 years ago by Alex Buts

refs #6656 fixed incorrect brackets in LoadDetectorInfo

Changeset: d5e121d0690e3d9cd5b355e68a0d569ff280ab89

comment:15 Changed 8 years ago by Alex Buts

refs #6656 warning on signed/unsigned comparison

Changeset: e67aa858c313f9e17845c9e2594cdb9318438048

comment:16 Changed 8 years ago by Alex Buts

refs #6656 Fixed erroneous change to DirectEnergyConversion

Changeset: 3de7b26e1963546fa0c4a092d9882372ca24f9e3

comment:17 Changed 8 years ago by Alex Buts

refs #6656 Doxygen warning fixed

Changeset: 3f8c232c85c72f0c5455d1b4d92cc25d42d2b4bf

comment:18 Changed 8 years ago by Alex Buts

refs #6656 fiddling with new workflow

nothing new but some strange merges/commits

Changeset: e3575d9513404d980b367395c1a8bb11ad84e7ff

comment:19 Changed 8 years ago by Alex Buts

refs #6656 wrapping warning suppression in compiler check clause

Changeset: 9cffcc05be576efc01a4f9bf9004f0a91d34580e

comment:20 Changed 8 years ago by Stuart Campbell

Not sure that turning off the warnings is the best way to get rid of the signed/unsigned warning.

comment:21 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:22 Changed 8 years ago by Alex Buts

  • Status changed from reopened to accepted

comment:23 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

It is completely justified in this situation, as the warning comes from the expression which verifies if static cast which follows latter and make conversion from size_t to int does not cause problem on given machine and OS.

the comparison size_t(var)<max(int)

comment:24 Changed 8 years ago by Stuart Campbell

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:25 Changed 8 years ago by Stuart Campbell

  • Cc nick.draper@… added

I can't seem to see the branch you are working from ? what's its name ?

comment:26 Changed 8 years ago by Alex Buts

  • Status changed from reopened to accepted

comment:27 Changed 8 years ago by Alex Buts

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:28 Changed 8 years ago by Stuart Campbell

Fix compiler warning. refs #6656.

Changeset: daa6c89acad21b283b685c0e6504088606ec2803

comment:29 Changed 8 years ago by Stuart Campbell

Please don't fix things directly on the develop branch - you should be editing your topic branch and then merging to develop!

comment:30 Changed 8 years ago by Stuart Campbell

Remove pointless test. refs #6656

Changeset: 217c0f60379ad170dbb082dc0169cdc9ba60d8c3

comment:31 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:32 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to verify
  • Tester Russell Taylor deleted

I got pulled away to do something else. Anyway, I don't have the data files for the script.

comment:33 Changed 8 years ago by Alex Buts

refs #6656 Modified Mari reduction to work with correct monovan file

Changeset: a94847bac5f69e2e912a0fdffce582cc434e5de8

comment:34 Changed 8 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:35 Changed 8 years ago by Alex Buts

refs #6656 Better(proper) diagnostics from DetectorEfficiencyCor

Changeset: 4815ac16494d35c44d98defcec729f539aaafab1

comment:36 Changed 8 years ago by Alex Buts

refs #6656 fixed incorrect brackets in LoadDetectorInfo

Changeset: 7d6c06af8b54ba2e88405066fe7718b52e28e75d

comment:37 Changed 8 years ago by Alex Buts

refs #6656 warning on signed/unsigned comparison

Changeset: f3b766990c05b5ad1cbfef07ccdf705e66031ecd

comment:38 Changed 8 years ago by Alex Buts

refs #6656 Fixed erroneous change to DirectEnergyConversion

Changeset: 9f078e0af0e893c3e1041f3196dabde9a8bca0b0

comment:39 Changed 8 years ago by Alex Buts

refs #6656 Doxygen warning fixed

Changeset: 4b717ece67f33a952981393bed6357e4dab06d47

comment:40 Changed 8 years ago by Stuart Campbell

Fix compiler warning. refs #6656.

Changeset: 42350ecd686b95594f68f039edddd2e999134529

comment:41 Changed 8 years ago by Stuart Campbell

Remove pointless test. refs #6656

Changeset: e3a9bfdec81ce13f74ef9e29c37629efa1bdc949

comment:42 Changed 8 years ago by Gesner Passos

  • Status changed from verifying to closed

There is no more a workspace with only zeros. It passed all well.

comment:43 Changed 8 years ago by Alex Buts

refs #6656 Better(proper) diagnostics from DetectorEfficiencyCor

Changeset: 4815ac16494d35c44d98defcec729f539aaafab1

comment:44 Changed 8 years ago by Alex Buts

refs #6656 fixed incorrect brackets in LoadDetectorInfo

Changeset: 7d6c06af8b54ba2e88405066fe7718b52e28e75d

comment:45 Changed 8 years ago by Alex Buts

refs #6656 warning on signed/unsigned comparison

Changeset: f3b766990c05b5ad1cbfef07ccdf705e66031ecd

comment:46 Changed 8 years ago by Alex Buts

refs #6656 Fixed erroneous change to DirectEnergyConversion

Changeset: 9f078e0af0e893c3e1041f3196dabde9a8bca0b0

comment:47 Changed 8 years ago by Alex Buts

refs #6656 Doxygen warning fixed

Changeset: 4b717ece67f33a952981393bed6357e4dab06d47

comment:48 Changed 8 years ago by Stuart Campbell

Fix compiler warning. refs #6656.

Changeset: 42350ecd686b95594f68f039edddd2e999134529

comment:49 Changed 8 years ago by Stuart Campbell

Remove pointless test. refs #6656

Changeset: e3a9bfdec81ce13f74ef9e29c37629efa1bdc949

comment:50 Changed 8 years ago by Alex Buts

refs #6656 Better(proper) diagnostics from DetectorEfficiencyCor

Changeset: 4815ac16494d35c44d98defcec729f539aaafab1

comment:51 Changed 8 years ago by Alex Buts

refs #6656 fixed incorrect brackets in LoadDetectorInfo

Changeset: 7d6c06af8b54ba2e88405066fe7718b52e28e75d

comment:52 Changed 8 years ago by Alex Buts

refs #6656 warning on signed/unsigned comparison

Changeset: f3b766990c05b5ad1cbfef07ccdf705e66031ecd

comment:53 Changed 8 years ago by Alex Buts

refs #6656 Fixed erroneous change to DirectEnergyConversion

Changeset: 9f078e0af0e893c3e1041f3196dabde9a8bca0b0

comment:54 Changed 8 years ago by Alex Buts

refs #6656 Doxygen warning fixed

Changeset: 4b717ece67f33a952981393bed6357e4dab06d47

comment:55 Changed 8 years ago by Stuart Campbell

Fix compiler warning. refs #6656.

Changeset: 42350ecd686b95594f68f039edddd2e999134529

comment:56 Changed 8 years ago by Stuart Campbell

Remove pointless test. refs #6656

Changeset: e3a9bfdec81ce13f74ef9e29c37629efa1bdc949

comment:57 Changed 8 years ago by Alex Buts

refs #6656 Better(proper) diagnostics from DetectorEfficiencyCor

Changeset: 4815ac16494d35c44d98defcec729f539aaafab1

comment:58 Changed 8 years ago by Alex Buts

refs #6656 fixed incorrect brackets in LoadDetectorInfo

Changeset: 7d6c06af8b54ba2e88405066fe7718b52e28e75d

comment:59 Changed 8 years ago by Alex Buts

refs #6656 warning on signed/unsigned comparison

Changeset: f3b766990c05b5ad1cbfef07ccdf705e66031ecd

comment:60 Changed 8 years ago by Alex Buts

refs #6656 Fixed erroneous change to DirectEnergyConversion

Changeset: 9f078e0af0e893c3e1041f3196dabde9a8bca0b0

comment:61 Changed 8 years ago by Alex Buts

refs #6656 Doxygen warning fixed

Changeset: 4b717ece67f33a952981393bed6357e4dab06d47

comment:62 Changed 8 years ago by Stuart Campbell

Fix compiler warning. refs #6656.

Changeset: 42350ecd686b95594f68f039edddd2e999134529

comment:63 Changed 8 years ago by Stuart Campbell

Remove pointless test. refs #6656

Changeset: e3a9bfdec81ce13f74ef9e29c37629efa1bdc949

comment:64 Changed 8 years ago by Alex Buts

refs #6656 Better(proper) diagnostics from DetectorEfficiencyCor

Changeset: 4815ac16494d35c44d98defcec729f539aaafab1

comment:65 Changed 8 years ago by Alex Buts

refs #6656 fixed incorrect brackets in LoadDetectorInfo

Changeset: 7d6c06af8b54ba2e88405066fe7718b52e28e75d

comment:66 Changed 8 years ago by Alex Buts

refs #6656 warning on signed/unsigned comparison

Changeset: f3b766990c05b5ad1cbfef07ccdf705e66031ecd

comment:67 Changed 8 years ago by Alex Buts

refs #6656 Fixed erroneous change to DirectEnergyConversion

Changeset: 9f078e0af0e893c3e1041f3196dabde9a8bca0b0

comment:68 Changed 8 years ago by Alex Buts

refs #6656 Doxygen warning fixed

Changeset: 4b717ece67f33a952981393bed6357e4dab06d47

comment:69 Changed 8 years ago by Stuart Campbell

Fix compiler warning. refs #6656.

Changeset: 42350ecd686b95594f68f039edddd2e999134529

comment:70 Changed 8 years ago by Stuart Campbell

Remove pointless test. refs #6656

Changeset: e3a9bfdec81ce13f74ef9e29c37629efa1bdc949

comment:71 Changed 7 years ago by Alex Buts

refs #6656 Better(proper) diagnostics from DetectorEfficiencyCor

Changeset: 5943f288a9ad5180a81a1651c98f911b0b3af9c5

comment:72 Changed 7 years ago by Alex Buts

refs #6656 fixed incorrect brackets in LoadDetectorInfo

Changeset: c490d639a5be3db9a1eedf306aeb24d45e4832dd

comment:73 Changed 7 years ago by Alex Buts

refs #6656 warning on signed/unsigned comparison

Changeset: bcc0d84e98c78379c47d51d57c9d5ab02f720659

comment:74 Changed 7 years ago by Alex Buts

refs #6656 Fixed erroneous change to DirectEnergyConversion

Changeset: f567eacecaa65fa482a296ba6c3f75b203d2a696

comment:75 Changed 7 years ago by Alex Buts

refs #6656 fiddling with new workflow

nothing new but some strange merges/commits

Changeset: e3575d9513404d980b367395c1a8bb11ad84e7ff

comment:76 Changed 7 years ago by Alex Buts

refs #6656 wrapping warning suppression in compiler check clause

Changeset: 9cffcc05be576efc01a4f9bf9004f0a91d34580e

comment:77 Changed 7 years ago by Stuart Campbell

Merge branch 'bugfix/6656_ProblemWithISISAbsoluteReduction' into develop

refs #6656

Conflicts:

Code/Mantid/Framework/DataHandling/src/LoadDetectorInfo.cpp

Changeset: 68fa36e21f50c00c5c0c06549253e9eed09abf9d

comment:78 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7502

Note: See TracTickets for help on using tickets.