Ticket #6657 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

DirectInelaticSNSTest (system test) does not handle periods in save directories correctly

Reported by: Martyn Gigg Owned by: Martyn Gigg
Priority: major Milestone: Release 2.5
Component: Infrastructure Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

The test saves an nxspe file to the save directory and then tries to find it again. If the save directory has a period in it then it fails because the test replaces periods by the character p, presumably to avoid some precision issue in the filname (which is constructed from a rotation parameter)

Change History

comment:1 Changed 8 years ago by Martyn Gigg

Fix DirectInelaticSNSTest path bug. Refs #6657

It only affected those paths where there was a period in the path already.

Changeset: d4d2df12ef7ab0623f0f5f372e2abecb5d092e62

comment:2 Changed 8 years ago by Martyn Gigg

  • Owner set to Martyn Gigg
  • Status changed from new to accepted

The branch name is: 6657_DirectInelasticSNS_pathbug

comment:3 Changed 8 years ago by Martyn Gigg

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester: Note this is a change in the systemtest repository

Please check that the DirectInelaticSNSTest runs correctly on you local machine.

comment:4 Changed 8 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:5 Changed 8 years ago by Martyn Gigg

Fix DirectInelaticSNSTest path bug. Refs #6657

It only affected those paths where there was a period in the path already.

Changeset: d4d2df12ef7ab0623f0f5f372e2abecb5d092e62

comment:6 Changed 8 years ago by Russell Taylor

  • Status changed from verifying to closed

The test passed on my machine, including when I renamed the path of my systemtest repo to have a period in it.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7503

Note: See TracTickets for help on using tickets.