Ticket #6692 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Muon: keep all period when new run

Reported by: Anders Markvardsen Owned by: Arturs Bekasovs
Priority: critical Milestone: Release 3.0
Component: Muon Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description (last modified by Anders Markvardsen) (diff)

Steve writes: - Configuration of period calculation should be preserved when loading runs unless number of periods in new run is different

Example is MUSR00015190-1.

  1. Load MUSR00015190 then select 1 + 2 for periods
  1. then select MUSR00015191 and you will see that it

plot period 1 only

change this so if next dataset has the same number of periods and is from the same instrument that it preserve the period algebra selected

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:2 Changed 7 years ago by Anders Markvardsen

  • Priority changed from major to critical

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after R2.6

comment:4 Changed 7 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Arturs Bekasovs
  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.0

comment:5 Changed 7 years ago by Arturs Bekasovs

  • Component changed from MantidPlot to Muon

comment:6 Changed 7 years ago by Arturs Bekasovs

  • Status changed from new to inprogress

Some minor clean-up code refactoring.

Refs #6692

Changeset: e3b28f18aa37d41151cfa6f2fc8c5fdfc955bbda

comment:7 Changed 7 years ago by Arturs Bekasovs

Put all the period widgets update code to one function.

Plus minor clean-up/refactoring of the code itself.

Refs #6692

Changeset: 3ccaa7aa57bf8b72ac29de6d2d64c8c57365eea6

comment:8 Changed 7 years ago by Arturs Bekasovs

Update widgets only if number of periods has changed.

Refs #6692

Changeset: 0abc816c46d56b2571bf7983eb95006245cb6abb

comment:9 Changed 7 years ago by Arturs Bekasovs

Update unconditionally if instrument has changed.

Plus move checks out of the function - more clear that way.

Refs #6692

Changeset: 538bf880dcbfe241ac231e8351b1484c3317b2e3

comment:10 Changed 7 years ago by Arturs Bekasovs

Tester:

That's a very simple one.

  1. Load AutoTestData/MUSR00015190.nxs. Make sure that period widgets are updated properly - there should be 2 periods overall, and the second period box should be enabled and set to None.
  2. Set period algebra used to 1 + 2.
  3. Load AutoTestData/MUSR00015191.nxs. As it has the same instrument AND number of periods, algebra should remain 1 + 2. You can check that this algebra is actually used by plotting counts of any of the groups - counts will be approx. twice as big as if you use 1 + None.
  4. Load AutoTestData/MUSR00022725.nxs. It has one period only, so widgets SHOULD get updated to reflect it.
  5. Again, load AutoTestData/MUSR00015191.nxs and set 1 + 2.
  6. Now load AutoTestData/argus0031800.nxs. It also has 2 periods BUT the instrument is different, so period algebra should get reset to something like 1 + None.

comment:11 Changed 7 years ago by Arturs Bekasovs

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:12 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:13 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/6692_muon_save_periods'

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7538

Note: See TracTickets for help on using tickets.