Ticket #6734 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

NaCl SXD Reduction to System Test

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Dennis and I worked to produce a reduction script, which would accurately find the lattice parameters of a NaCl sample run on the ISIS SXD instrument. This appears to be producing some nice results. As this is a good benchmark for future work in this area we ought to integrate the results into our system test framework. Having this as part of our system tests, will help build confidence in our single crystal elastic diffraction setups.

I'm going to try to avoid making the system tests too sensitive. Measuring the lattice parameters to 1 decimal place is probably a sufficient test that things are working okay.

Change History

comment:1 Changed 8 years ago by Owen Arnold

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Owen Arnold

refs #6734. Good results for NaCl.

Changeset: 23b924bf334107a4d36705fdab392c8957008dcb

comment:3 Changed 8 years ago by Owen Arnold

refs #6734. Good results for NaCl.

Changeset: 23b924bf334107a4d36705fdab392c8957008dcb

comment:4 Changed 8 years ago by Owen Arnold

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester:

Branch for testing is https://github.com/mantidproject/systemtests/tree/feature/6734_sxd_tests This is on the systemtest repository.

You should check the workflow of the test, and check that is currently passes on all platforms.

comment:5 Changed 8 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 8 years ago by Owen Arnold

refs #6734. Good results for NaCl.

Changeset: 23b924bf334107a4d36705fdab392c8957008dcb

comment:7 Changed 8 years ago by Michael Reuter

  • Status changed from verifying to closed

I ran this on my RHEL6 box and it worked. I checked the build servers and RHEL6 and OSX are OK. Windows cannot be verified due to builds being broken by other tests. I will assume that this works on Windows and if it doesn't then those issues can be addressed in another ticket.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7580

Note: See TracTickets for help on using tickets.