Ticket #6738 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Extra LiveDataAlgorithm validation broke the FileEventDataListener

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: major Milestone: Release 2.5
Component: Mantid Keywords: LiveData
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

The addition of code in LiveDataAlgorithm::validateInputs() under #5366 had led to the creation of the listener over and over again. With most ILiveListeners, this is not a big deal, but the FileEventDataListener (which is used for testing) takes some action in the destructor (deletes a temporary workspace), which meant that testing live data using it is broken.

Change History

comment:1 Changed 8 years ago by Russell Taylor

  • Status changed from new to accepted

Branch is at feature/6738_create_fewer_livelisteners

comment:2 Changed 8 years ago by Russell Taylor

Re #6738. Only create listener if the alg doesn't already 'have' one.

Changeset: 4cfce5894370aae6f93b7c1ccb145847dae0247a

comment:3 Changed 8 years ago by Russell Taylor

Re #6738. Enable use of multiple FileEventDataListeners at same time.

Changeset: 4a6b15fa704c77479409484ad055a1aa5ceb7f7b

comment:4 Changed 8 years ago by Russell Taylor

Re #6738. Documentation correction that didn't merit its own ticket.

Changeset: e06b9fb0a87d9797e80561296fe66fd7eb7cfcf8

comment:5 Changed 8 years ago by Russell Taylor

  • Status changed from accepted to verify
  • Resolution set to fixed

To test: First edit your Mantid.user.properties to add the properties:

  • fileeventdatalistener.filename - with the path to a pre-nexus or runinfo file (e.g. CNCS_7860_runinfo.xml)
  • fileeventdatalistener.chunks - with some integer (e.g. 10)

Then run the StartLiveData algorithm, choosing FileEventDataListener as the Instrument. Before the above fix, the algorithm would stop with an error before loading the second 'chunk'. Now it should continue until the whole file has been loaded.

Test also that you can have more than one instance of MonitorLiveData running at the same time using a FileEventDataListener.

comment:6 Changed 8 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:7 Changed 8 years ago by Russell Taylor

Re #6738. Only create listener if the alg doesn't already 'have' one.

Changeset: 4cfce5894370aae6f93b7c1ccb145847dae0247a

comment:8 Changed 8 years ago by Russell Taylor

Re #6738. Enable use of multiple FileEventDataListeners at same time.

Changeset: 4a6b15fa704c77479409484ad055a1aa5ceb7f7b

comment:9 Changed 8 years ago by Russell Taylor

Re #6738. Documentation correction that didn't merit its own ticket.

Changeset: e06b9fb0a87d9797e80561296fe66fd7eb7cfcf8

comment:10 Changed 8 years ago by Martyn Gigg

  • Status changed from verifying to closed

comment:11 Changed 8 years ago by Russell Taylor

Re #6738. Only create listener if the alg doesn't already 'have' one.

Changeset: 4cfce5894370aae6f93b7c1ccb145847dae0247a

comment:12 Changed 8 years ago by Russell Taylor

Re #6738. Enable use of multiple FileEventDataListeners at same time.

Changeset: 4a6b15fa704c77479409484ad055a1aa5ceb7f7b

comment:13 Changed 8 years ago by Russell Taylor

Re #6738. Documentation correction that didn't merit its own ticket.

Changeset: e06b9fb0a87d9797e80561296fe66fd7eb7cfcf8

comment:14 Changed 8 years ago by Russell Taylor

Re #6738. Only create listener if the alg doesn't already 'have' one.

Changeset: 4cfce5894370aae6f93b7c1ccb145847dae0247a

comment:15 Changed 8 years ago by Russell Taylor

Re #6738. Enable use of multiple FileEventDataListeners at same time.

Changeset: 4a6b15fa704c77479409484ad055a1aa5ceb7f7b

comment:16 Changed 8 years ago by Russell Taylor

Re #6738. Documentation correction that didn't merit its own ticket.

Changeset: e06b9fb0a87d9797e80561296fe66fd7eb7cfcf8

comment:17 Changed 7 years ago by Russell Taylor

Re #6738. Only create listener if the alg doesn't already 'have' one.

Changeset: 4cfce5894370aae6f93b7c1ccb145847dae0247a

comment:18 Changed 7 years ago by Russell Taylor

Re #6738. Enable use of multiple FileEventDataListeners at same time.

Changeset: 4a6b15fa704c77479409484ad055a1aa5ceb7f7b

comment:19 Changed 7 years ago by Russell Taylor

Re #6738. Documentation correction that didn't merit its own ticket.

Changeset: e06b9fb0a87d9797e80561296fe66fd7eb7cfcf8

comment:20 Changed 7 years ago by Russell Taylor

Re #6738. Only create listener if the alg doesn't already 'have' one.

Changeset: 4cfce5894370aae6f93b7c1ccb145847dae0247a

comment:21 Changed 7 years ago by Russell Taylor

Re #6738. Enable use of multiple FileEventDataListeners at same time.

Changeset: 4a6b15fa704c77479409484ad055a1aa5ceb7f7b

comment:22 Changed 7 years ago by Russell Taylor

Re #6738. Documentation correction that didn't merit its own ticket.

Changeset: e06b9fb0a87d9797e80561296fe66fd7eb7cfcf8

comment:23 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7584

Note: See TracTickets for help on using tickets.