Ticket #6737 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Create an algorithm to write log time correction file

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By:
Blocking: #6844 Tester: Michael Reuter

Description

Implement an algorithm to write out a log time correction file for FilterEvents().

The correction of each pixel is a factor (f) such that neutron_tof * f = sample_tof. And f = L1/(L1+L2) for each pixel.

Remove the corresponding codes from GetTimeSeriesLogInformation.

Change History

comment:1 Changed 8 years ago by Wenduo Zhou

Start to implement CreateLogTimeCorrection. Refs #6737.

Changeset: a4bc6e23df351474cb3071e933b66020a5ba560e

comment:2 Changed 8 years ago by Wenduo Zhou

Save the work. Refs #6737.

Changeset: 5f70a68fee8b271d8feeb5f7a1233e676ae17116

comment:3 Changed 8 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 9fc9818cefb65358855ce85720686f941f2d519c

comment:4 Changed 8 years ago by Wenduo Zhou

Start to implement CreateLogTimeCorrection. Refs #6737.

Changeset: a4bc6e23df351474cb3071e933b66020a5ba560e

comment:5 Changed 8 years ago by Wenduo Zhou

Save the work. Refs #6737.

Changeset: 5f70a68fee8b271d8feeb5f7a1233e676ae17116

comment:6 Changed 8 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 9fc9818cefb65358855ce85720686f941f2d519c

comment:7 Changed 8 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 88e69f5e904036382553b7b6e75d7340eb92ccfa

comment:8 Changed 8 years ago by Wenduo Zhou

Complete the implementation. Refs #6737.

Changeset: 7ecaecefffb3b404a85ab323b5358e52f3dd6dd9

comment:9 Changed 8 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:10 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 88e69f5e904036382553b7b6e75d7340eb92ccfa

comment:11 Changed 7 years ago by Wenduo Zhou

Complete the implementation. Refs #6737.

Changeset: 7ecaecefffb3b404a85ab323b5358e52f3dd6dd9

comment:12 Changed 7 years ago by Wenduo Zhou

Try to fix windows build. Refs #6737.

Changeset: e1aafdc81248b18bdbcb4f35c46842814de35b0d

comment:13 Changed 7 years ago by Wenduo Zhou

Finish the work on this ticket. Refs #6737.

  1. Throw an exception if user specifies the name of the output table workspace

same as input matrix workspace.

  1. Change the property for output correction file to optional save. Changeset: 698627ab7988e89a880a5f3c80ba61200bcfb606

comment:14 Changed 7 years ago by Wenduo Zhou

Finish the work on this ticket. Refs #6737.

  1. Throw an exception if user specifies the name of the output table workspace

same as input matrix workspace.

  1. Change the property for output correction file to optional save. Changeset: 698627ab7988e89a880a5f3c80ba61200bcfb606

comment:15 Changed 7 years ago by Wenduo Zhou

  • Blocking 4844 added

comment:16 Changed 7 years ago by Wenduo Zhou

  • Blocking 6844 added; 4844 removed

comment:17 Changed 7 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

How to verify this ticket

  1. Load any data to MantidPlot to create a work space having non-empty instrument;
  2. Call CreateLogTimeCorrection();
    • You needn't give the output file name as it is just optional;
  3. Check the output table workspace. The first column are the detector IDs. The 2nd column are the correction factors. None of them should be greater than 1.0. The third column are the L2 (distance from sample to detector) of detector.
Last edited 7 years ago by Wenduo Zhou (previous) (diff)

comment:18 Changed 7 years ago by Wenduo Zhou

Fix a bug. Refs #6737.

Changeset: bb5ded8c72d9801922d747055b543ccfd0a23079

comment:19 Changed 7 years ago by Wenduo Zhou

Fix a bug. Refs #6737.

Changeset: bb5ded8c72d9801922d747055b543ccfd0a23079

comment:20 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:21 Changed 7 years ago by Wenduo Zhou

Start to implement CreateLogTimeCorrection. Refs #6737.

Changeset: a4bc6e23df351474cb3071e933b66020a5ba560e

comment:22 Changed 7 years ago by Wenduo Zhou

Save the work. Refs #6737.

Changeset: 5f70a68fee8b271d8feeb5f7a1233e676ae17116

comment:23 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 9fc9818cefb65358855ce85720686f941f2d519c

comment:24 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 88e69f5e904036382553b7b6e75d7340eb92ccfa

comment:25 Changed 7 years ago by Wenduo Zhou

Complete the implementation. Refs #6737.

Changeset: 7ecaecefffb3b404a85ab323b5358e52f3dd6dd9

comment:26 Changed 7 years ago by Wenduo Zhou

Try to fix windows build. Refs #6737.

Changeset: e1aafdc81248b18bdbcb4f35c46842814de35b0d

comment:27 Changed 7 years ago by Wenduo Zhou

Finish the work on this ticket. Refs #6737.

  1. Throw an exception if user specifies the name of the output table workspace

same as input matrix workspace.

  1. Change the property for output correction file to optional save. Changeset: 698627ab7988e89a880a5f3c80ba61200bcfb606

comment:28 Changed 7 years ago by Wenduo Zhou

Fix a bug. Refs #6737.

Changeset: bb5ded8c72d9801922d747055b543ccfd0a23079

comment:29 Changed 7 years ago by Wenduo Zhou

Start to implement CreateLogTimeCorrection. Refs #6737.

Changeset: a4bc6e23df351474cb3071e933b66020a5ba560e

comment:30 Changed 7 years ago by Wenduo Zhou

Save the work. Refs #6737.

Changeset: 5f70a68fee8b271d8feeb5f7a1233e676ae17116

comment:31 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 9fc9818cefb65358855ce85720686f941f2d519c

comment:32 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 88e69f5e904036382553b7b6e75d7340eb92ccfa

comment:33 Changed 7 years ago by Wenduo Zhou

Complete the implementation. Refs #6737.

Changeset: 7ecaecefffb3b404a85ab323b5358e52f3dd6dd9

comment:34 Changed 7 years ago by Wenduo Zhou

Try to fix windows build. Refs #6737.

Changeset: e1aafdc81248b18bdbcb4f35c46842814de35b0d

comment:35 Changed 7 years ago by Wenduo Zhou

Finish the work on this ticket. Refs #6737.

  1. Throw an exception if user specifies the name of the output table workspace

same as input matrix workspace.

  1. Change the property for output correction file to optional save. Changeset: 698627ab7988e89a880a5f3c80ba61200bcfb606

comment:36 Changed 7 years ago by Wenduo Zhou

Fix a bug. Refs #6737.

Changeset: bb5ded8c72d9801922d747055b543ccfd0a23079

comment:37 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

This seems to be working correctly.

comment:38 Changed 7 years ago by Wenduo Zhou

Start to implement CreateLogTimeCorrection. Refs #6737.

Changeset: a4bc6e23df351474cb3071e933b66020a5ba560e

comment:39 Changed 7 years ago by Wenduo Zhou

Save the work. Refs #6737.

Changeset: 5f70a68fee8b271d8feeb5f7a1233e676ae17116

comment:40 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 9fc9818cefb65358855ce85720686f941f2d519c

comment:41 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 88e69f5e904036382553b7b6e75d7340eb92ccfa

comment:42 Changed 7 years ago by Wenduo Zhou

Complete the implementation. Refs #6737.

Changeset: 7ecaecefffb3b404a85ab323b5358e52f3dd6dd9

comment:43 Changed 7 years ago by Wenduo Zhou

Try to fix windows build. Refs #6737.

Changeset: e1aafdc81248b18bdbcb4f35c46842814de35b0d

comment:44 Changed 7 years ago by Wenduo Zhou

Finish the work on this ticket. Refs #6737.

  1. Throw an exception if user specifies the name of the output table workspace

same as input matrix workspace.

  1. Change the property for output correction file to optional save. Changeset: 698627ab7988e89a880a5f3c80ba61200bcfb606

comment:45 Changed 7 years ago by Wenduo Zhou

Fix a bug. Refs #6737.

Changeset: bb5ded8c72d9801922d747055b543ccfd0a23079

comment:46 Changed 7 years ago by Wenduo Zhou

Start to implement CreateLogTimeCorrection. Refs #6737.

Changeset: a4bc6e23df351474cb3071e933b66020a5ba560e

comment:47 Changed 7 years ago by Wenduo Zhou

Save the work. Refs #6737.

Changeset: 5f70a68fee8b271d8feeb5f7a1233e676ae17116

comment:48 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 9fc9818cefb65358855ce85720686f941f2d519c

comment:49 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 88e69f5e904036382553b7b6e75d7340eb92ccfa

comment:50 Changed 7 years ago by Wenduo Zhou

Complete the implementation. Refs #6737.

Changeset: 7ecaecefffb3b404a85ab323b5358e52f3dd6dd9

comment:51 Changed 7 years ago by Wenduo Zhou

Try to fix windows build. Refs #6737.

Changeset: e1aafdc81248b18bdbcb4f35c46842814de35b0d

comment:52 Changed 7 years ago by Wenduo Zhou

Finish the work on this ticket. Refs #6737.

  1. Throw an exception if user specifies the name of the output table workspace

same as input matrix workspace.

  1. Change the property for output correction file to optional save. Changeset: 698627ab7988e89a880a5f3c80ba61200bcfb606

comment:53 Changed 7 years ago by Wenduo Zhou

Fix a bug. Refs #6737.

Changeset: bb5ded8c72d9801922d747055b543ccfd0a23079

comment:54 Changed 7 years ago by Wenduo Zhou

Start to implement CreateLogTimeCorrection. Refs #6737.

Changeset: a4bc6e23df351474cb3071e933b66020a5ba560e

comment:55 Changed 7 years ago by Wenduo Zhou

Save the work. Refs #6737.

Changeset: 5f70a68fee8b271d8feeb5f7a1233e676ae17116

comment:56 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 9fc9818cefb65358855ce85720686f941f2d519c

comment:57 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6737.

Changeset: 88e69f5e904036382553b7b6e75d7340eb92ccfa

comment:58 Changed 7 years ago by Wenduo Zhou

Complete the implementation. Refs #6737.

Changeset: 7ecaecefffb3b404a85ab323b5358e52f3dd6dd9

comment:59 Changed 7 years ago by Wenduo Zhou

Try to fix windows build. Refs #6737.

Changeset: e1aafdc81248b18bdbcb4f35c46842814de35b0d

comment:60 Changed 7 years ago by Wenduo Zhou

Finish the work on this ticket. Refs #6737.

  1. Throw an exception if user specifies the name of the output table workspace

same as input matrix workspace.

  1. Change the property for output correction file to optional save. Changeset: 698627ab7988e89a880a5f3c80ba61200bcfb606

comment:61 Changed 7 years ago by Wenduo Zhou

Fix a bug. Refs #6737.

Changeset: bb5ded8c72d9801922d747055b543ccfd0a23079

comment:62 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7583

Note: See TracTickets for help on using tickets.