Ticket #6844 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

FilterEvents() imports a table workspace for log time correction

Reported by: Wenduo Zhou Owned by: Wenduo Zhou
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: saviciat@… Blocked By: #6737
Blocking: Tester: Russell Taylor

Description

FilterEvents() will import the log time correction from a TableWorkspace other than importing a log time correction file in the current implementation.

It might affect some system test.

Attachments

verify6844.py​ (1.5 KB) - added by Wenduo Zhou 7 years ago.

Change History

comment:1 Changed 8 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:2 Changed 8 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: abc2d21a702c05021d7be5b2b351f2c2039500d8

comment:3 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: 6ebb7510aa464aa1038e1239fd6188df4d9533ab

comment:4 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: abc2d21a702c05021d7be5b2b351f2c2039500d8

comment:5 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: 6ebb7510aa464aa1038e1239fd6188df4d9533ab

comment:6 Changed 7 years ago by Wenduo Zhou

Complete unit test. Refs #6844.

Changeset: 37152334a9967cef4dc75724f4dc89e082ea37c4

comment:7 Changed 7 years ago by Wenduo Zhou

Complete unit test. Refs #6844.

Changeset: 37152334a9967cef4dc75724f4dc89e082ea37c4

comment:8 Changed 7 years ago by Wenduo Zhou

  • Blocked By 6737 added

comment:9 Changed 7 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

How to verify this ticket

  1. Load VULCAN run 20002;
  2. Execute algorithm CreateLogTimeCorrection() to generate a correction table;
  3. Execute GenerateEventFilter() to generate a filter according to log "Special1_0";
  4. Execute FilterEvents() with and without the correction table. The outcome should be close but not exactly the same.

Download the attachment "verify6844.py" which contains the script to verify this ticket.

Changed 7 years ago by Wenduo Zhou

comment:10 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:11 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to verify
  • Tester Gesner Passos deleted

This has to be tested in ORNL to be able to Load VULCAN 20002. returning to the pool

comment:12 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:13 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: abc2d21a702c05021d7be5b2b351f2c2039500d8

comment:14 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: 6ebb7510aa464aa1038e1239fd6188df4d9533ab

comment:15 Changed 7 years ago by Wenduo Zhou

Complete unit test. Refs #6844.

Changeset: 37152334a9967cef4dc75724f4dc89e082ea37c4

comment:16 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: abc2d21a702c05021d7be5b2b351f2c2039500d8

comment:17 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: 6ebb7510aa464aa1038e1239fd6188df4d9533ab

comment:18 Changed 7 years ago by Wenduo Zhou

Complete unit test. Refs #6844.

Changeset: 37152334a9967cef4dc75724f4dc89e082ea37c4

comment:19 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: abc2d21a702c05021d7be5b2b351f2c2039500d8

comment:20 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: 6ebb7510aa464aa1038e1239fd6188df4d9533ab

comment:21 Changed 7 years ago by Wenduo Zhou

Complete unit test. Refs #6844.

Changeset: 37152334a9967cef4dc75724f4dc89e082ea37c4

comment:22 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: abc2d21a702c05021d7be5b2b351f2c2039500d8

comment:23 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: 6ebb7510aa464aa1038e1239fd6188df4d9533ab

comment:24 Changed 7 years ago by Wenduo Zhou

Complete unit test. Refs #6844.

Changeset: 37152334a9967cef4dc75724f4dc89e082ea37c4

comment:25 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: abc2d21a702c05021d7be5b2b351f2c2039500d8

comment:26 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: 6ebb7510aa464aa1038e1239fd6188df4d9533ab

comment:27 Changed 7 years ago by Wenduo Zhou

Complete unit test. Refs #6844.

Changeset: 37152334a9967cef4dc75724f4dc89e082ea37c4

comment:28 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

comment:29 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: abc2d21a702c05021d7be5b2b351f2c2039500d8

comment:30 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: 6ebb7510aa464aa1038e1239fd6188df4d9533ab

comment:31 Changed 7 years ago by Wenduo Zhou

Complete unit test. Refs #6844.

Changeset: 37152334a9967cef4dc75724f4dc89e082ea37c4

comment:32 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: abc2d21a702c05021d7be5b2b351f2c2039500d8

comment:33 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6844.

Changeset: 6ebb7510aa464aa1038e1239fd6188df4d9533ab

comment:34 Changed 7 years ago by Wenduo Zhou

Complete unit test. Refs #6844.

Changeset: 37152334a9967cef4dc75724f4dc89e082ea37c4

comment:35 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7690

Note: See TracTickets for help on using tickets.