Ticket #6736 (closed: duplicate)
Move reducer code to new Python api
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.6 |
| Component: | Python | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Mathieu Doucet |
Description
The reducer code is still based on the old Python api. Move the code to the new API but try and keep support for the old api. The only tricky bits seem to be the parts around adding an algorithm object as a step.
Change History
comment:2 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Mathieu Doucet
comment:3 Changed 7 years ago by Mathieu Doucet
- Owner changed from Mathieu Doucet to Nick Draper
This work has been done already as part of tickets to more the ORNL SANS to the new Python API (see #6151). The new reducer code is in script/reduction_workflow. To migrate an instrument to the new workflow, one should move their old "ReductionStep" code to workflow algorithms. In addition, one should move the reduction logic to a workflow algorithm. For an example, see the SetupEQSANSReduction and SANSReduction workflow algorithms. This approach uses Mantid property managers to hold the reduction options rather than a python class, which simplifies the reducer code.
comment:4 Changed 7 years ago by Nick Draper
- Owner changed from Nick Draper to Martyn Gigg
Martyn, Can I have your opinion please? How much more is there to be done?
comment:5 Changed 7 years ago by Martyn Gigg
If I understand this correctly the reducer code that uses the old api can just be removed when we remove the old API as long as all of the reduction steps have been migrated to WorkflowAlgorithms.
I think for us this will impact SANS and indirect inelastic so we should raise tickets to sort those out.
comment:6 Changed 7 years ago by Martyn Gigg
- Milestone changed from Release 2.6 to Release 2.7
Batch move to 2.7
comment:11 Changed 7 years ago by Martyn Gigg
- Status changed from new to verify
- Resolution set to duplicate
Duplicate of #7469
comment:12 Changed 7 years ago by Mathieu Doucet
- Status changed from verify to verifying
- Tester set to Mathieu Doucet
comment:13 Changed 7 years ago by Mathieu Doucet
- Status changed from verifying to closed
Yes. This work has been done as part of a few other tickets.
comment:15 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7582
Moved to r2.6 at the end of r2.5