Investigate Calibration Failure of MAPS D4 Window

[Karl Palmen]

Investigate why the python tube calibration code cannot calibrate all or most of the tubes in the D4 window of the MAPS instrument for calibration run 14919, which is used by the MAPS example scripts.

If the cause is found and can be easily fixed, fix it, else report the situation.

[Karl Palmen]

I've found out that the failure of the calibration of the D4_window, is that the detector IDs for that window are in reverse order (step="-1") and the tube specification code expects them to be in numerical order. The IDLIST for the D4_window begins thus in the IDF file:

  <idlist idname="D4_window">
    <id start="44101256" step="-1" end="44101001" />

This can be easily fixed to work with step = -1, by checking the ID of the last detector. Also it could be fixed for step = any non-zero integer, but such a fix would be more complicated.

[Karl Palmen]

Allow detectors to be numbered in reverse order in a tube re #6742

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 6080073c0f07929dd1deceed17d648e25c23c91b

[Karl Palmen]

To test, run the TubeCalibDemoMaps_D4.py example script in .../scripts/Calibration/Examples. Check the it does calibrate the tubes, even though they may be rotated a little (separate issue).

The branch is feature/6742_maps_d4window .

[Karl Palmen]

Further investigation has shown that this simple solution has turned the tubes around so that the detectors of ID ...001 are in the right instead of the left. More work will need to be done.

[Karl Palmen]

Deal with detectors in reverse order without reversing tube re #6742

This also fixes the problem of the tubes sloping.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 25e4a73b88bf361e960b477ae09329e010e1cc62

[Karl Palmen]

Allow detectors to be numbered in reverse order in a tube re #6742

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 6080073c0f07929dd1deceed17d648e25c23c91b

[Karl Palmen]

Deal with detectors in reverse order without reversing tube re #6742

This also fixes the problem of the tubes sloping.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 25e4a73b88bf361e960b477ae09329e010e1cc62

[Karl Palmen]

To test, run the TubeCalibDemoMaps_D4.py example script in .../scripts/Calibration/Examples. Check the it does calibrate the tubes and that the detector IDs do run from ...001 to ...256 left to right.

Branch = feature/6742_maps_d4window .

[Karl Palmen]

Tidy up python code re #6742

This commit was needed only because I made the previous one without saving.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b75be43c026f82f2ee3a87168f83757f3d3d1618

[Karl Palmen]

Tidy up python code re #6742

This commit was needed only because I made the previous one without saving.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b75be43c026f82f2ee3a87168f83757f3d3d1618

[Anders Markvardsen]

Works as expected.

To help the tester please specify the folder where a calibration MAPS file can be found, which in this case is
isis\inst$\NDXMAPS\Instrument\data\cycle_09_5

The steps I did to make run the script was

1. added
   isis\inst$\NDXMAPS\Instrument\data\cycle_09_5 to Manage User Directories

2. on line 16 in TubeCalibDemoMaps_D4.py changed path = r"C:/Temp/" to path = ""

[Karl Palmen]

Allow detectors to be numbered in reverse order in a tube re #6742

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 6080073c0f07929dd1deceed17d648e25c23c91b

[Karl Palmen]

Deal with detectors in reverse order without reversing tube re #6742

This also fixes the problem of the tubes sloping.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 25e4a73b88bf361e960b477ae09329e010e1cc62

[Karl Palmen]

Tidy up python code re #6742

This commit was needed only because I made the previous one without saving.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b75be43c026f82f2ee3a87168f83757f3d3d1618

[Karl Palmen]

"To help the tester please specify the folder where a calibration MAPS file can be found, which in this case is isis\inst$\NDXMAPS\Instrument\data\cycle_09_5" This will be done as part of #6752 .

[Karl Palmen]

Allow detectors to be numbered in reverse order in a tube re #6742

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 6080073c0f07929dd1deceed17d648e25c23c91b

[Karl Palmen]

Deal with detectors in reverse order without reversing tube re #6742

This also fixes the problem of the tubes sloping.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 25e4a73b88bf361e960b477ae09329e010e1cc62

[Karl Palmen]

Tidy up python code re #6742

This commit was needed only because I made the previous one without saving.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b75be43c026f82f2ee3a87168f83757f3d3d1618

[Karl Palmen]

Allow detectors to be numbered in reverse order in a tube re #6742

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 6080073c0f07929dd1deceed17d648e25c23c91b

[Karl Palmen]

Deal with detectors in reverse order without reversing tube re #6742

This also fixes the problem of the tubes sloping.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 25e4a73b88bf361e960b477ae09329e010e1cc62

[Karl Palmen]

Tidy up python code re #6742

This commit was needed only because I made the previous one without saving.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b75be43c026f82f2ee3a87168f83757f3d3d1618

[Karl Palmen]

Allow detectors to be numbered in reverse order in a tube re #6742

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 6080073c0f07929dd1deceed17d648e25c23c91b

[Karl Palmen]

Deal with detectors in reverse order without reversing tube re #6742

This also fixes the problem of the tubes sloping.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 25e4a73b88bf361e960b477ae09329e010e1cc62

[Karl Palmen]

Tidy up python code re #6742

This commit was needed only because I made the previous one without saving.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b75be43c026f82f2ee3a87168f83757f3d3d1618

[Stuart Campbell]

This ticket has been transferred to github issue ​7588