Ticket #6754 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Inst display: Show HKL for new manual peaks if valid UBmatrix available

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: critical Milestone: Release 2.5
Component: MantidPlot Keywords:
Cc: Blocked By: #6753
Blocking: Tester: Nick Draper

Description

When picking new peaks manually, if a peak workspace is overlaid with a UB matrix then use CalculatePeakHKL (#6753) to calculate the new peaks HKL and display the potentially fractional display on the instrument view.

Change History

comment:1 Changed 7 years ago by Roman Tolchenov

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Roman Tolchenov

Run CalculatePeaksHKL algorithm to set the hkl values. Re #6754

Changeset: c7d88d209f951015d6d238906611eebde1b43937

comment:3 Changed 7 years ago by Roman Tolchenov

Run CalculatePeaksHKL algorithm to set the hkl values. Re #6754

Changeset: c7d88d209f951015d6d238906611eebde1b43937

comment:4 Changed 7 years ago by Roman Tolchenov

Display info on the peak overlays. Re #6754.

Changeset: c9d5dd5f0b2d76ec132c20c7eee46581eaaf3ef2

comment:5 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6754_manual_peaks_with_UB' into develop. Re #6754

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/InstrumentWidget/ProjectionSurface.h

Changeset: 2fa99dc2edb260a37bf4bdf1981b0afce9ad4c53

comment:6 Changed 7 years ago by Roman Tolchenov

Correcting previous conflict resolution (very simple). Re #6754.

Changeset: 543695eabfd7d83f272a4fed31048a8bfcc0f991

comment:7 Changed 7 years ago by Roman Tolchenov

Display info on the peak overlays. Re #6754.

Changeset: c9d5dd5f0b2d76ec132c20c7eee46581eaaf3ef2

comment:8 Changed 7 years ago by Roman Tolchenov

  • Status changed from accepted to verify
  • Resolution set to fixed

To tester:

branch feature/6754_manual_peaks_with_UB

The tester needs to have a PeaksWorkspace with a UB matrix attached to it

comment:9 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:10 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to verify
  • Tester Martyn Gigg deleted

comment:11 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:12 Changed 7 years ago by Roman Tolchenov

Run CalculatePeaksHKL algorithm to set the hkl values. Re #6754

Changeset: c7d88d209f951015d6d238906611eebde1b43937

comment:13 Changed 7 years ago by Roman Tolchenov

Display info on the peak overlays. Re #6754.

Changeset: c9d5dd5f0b2d76ec132c20c7eee46581eaaf3ef2

comment:14 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Tested functionality and usability, using script from #6753. HKL calculation not tested, assumed from testing of #6753.

comment:15 Changed 7 years ago by Roman Tolchenov

Run CalculatePeaksHKL algorithm to set the hkl values. Re #6754

Changeset: c7d88d209f951015d6d238906611eebde1b43937

comment:16 Changed 7 years ago by Roman Tolchenov

Display info on the peak overlays. Re #6754.

Changeset: c9d5dd5f0b2d76ec132c20c7eee46581eaaf3ef2

comment:17 Changed 7 years ago by Roman Tolchenov

Run CalculatePeaksHKL algorithm to set the hkl values. Re #6754

Changeset: c7d88d209f951015d6d238906611eebde1b43937

comment:18 Changed 7 years ago by Roman Tolchenov

Display info on the peak overlays. Re #6754.

Changeset: c9d5dd5f0b2d76ec132c20c7eee46581eaaf3ef2

comment:19 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6754_manual_peaks_with_UB' into develop. Re #6754

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/InstrumentWidget/ProjectionSurface.h

Changeset: 2fa99dc2edb260a37bf4bdf1981b0afce9ad4c53

comment:20 Changed 7 years ago by Roman Tolchenov

Correcting previous conflict resolution (very simple). Re #6754.

Changeset: 543695eabfd7d83f272a4fed31048a8bfcc0f991

comment:21 Changed 7 years ago by Roman Tolchenov

Run CalculatePeaksHKL algorithm to set the hkl values. Re #6754

Changeset: c7d88d209f951015d6d238906611eebde1b43937

comment:22 Changed 7 years ago by Roman Tolchenov

Display info on the peak overlays. Re #6754.

Changeset: c9d5dd5f0b2d76ec132c20c7eee46581eaaf3ef2

comment:23 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6754_manual_peaks_with_UB' into develop. Re #6754

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/InstrumentWidget/ProjectionSurface.h

Changeset: 2fa99dc2edb260a37bf4bdf1981b0afce9ad4c53

comment:24 Changed 7 years ago by Roman Tolchenov

Correcting previous conflict resolution (very simple). Re #6754.

Changeset: 543695eabfd7d83f272a4fed31048a8bfcc0f991

comment:25 Changed 7 years ago by Roman Tolchenov

Run CalculatePeaksHKL algorithm to set the hkl values. Re #6754

Changeset: c7d88d209f951015d6d238906611eebde1b43937

comment:26 Changed 7 years ago by Roman Tolchenov

Display info on the peak overlays. Re #6754.

Changeset: c9d5dd5f0b2d76ec132c20c7eee46581eaaf3ef2

comment:27 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6754_manual_peaks_with_UB' into develop. Re #6754

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/InstrumentWidget/ProjectionSurface.h

Changeset: 2fa99dc2edb260a37bf4bdf1981b0afce9ad4c53

comment:28 Changed 7 years ago by Roman Tolchenov

Correcting previous conflict resolution (very simple). Re #6754.

Changeset: 543695eabfd7d83f272a4fed31048a8bfcc0f991

comment:29 Changed 7 years ago by Roman Tolchenov

Run CalculatePeaksHKL algorithm to set the hkl values. Re #6754

Changeset: c7d88d209f951015d6d238906611eebde1b43937

comment:30 Changed 7 years ago by Roman Tolchenov

Display info on the peak overlays. Re #6754.

Changeset: c9d5dd5f0b2d76ec132c20c7eee46581eaaf3ef2

comment:31 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6754_manual_peaks_with_UB' into develop. Re #6754

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/InstrumentWidget/ProjectionSurface.h

Changeset: 2fa99dc2edb260a37bf4bdf1981b0afce9ad4c53

comment:32 Changed 7 years ago by Roman Tolchenov

Correcting previous conflict resolution (very simple). Re #6754.

Changeset: 543695eabfd7d83f272a4fed31048a8bfcc0f991

comment:33 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/6754_manual_peaks_with_UB' into develop. Re #6754

Conflicts:

Code/Mantid/MantidPlot/src/Mantid/InstrumentWidget/ProjectionSurface.h

Changeset: 2fa99dc2edb260a37bf4bdf1981b0afce9ad4c53

comment:34 Changed 7 years ago by Roman Tolchenov

Correcting previous conflict resolution (very simple). Re #6754.

Changeset: 543695eabfd7d83f272a4fed31048a8bfcc0f991

comment:35 Changed 7 years ago by Roman Tolchenov

Run CalculatePeaksHKL algorithm to set the hkl values. Re #6754

Changeset: c7d88d209f951015d6d238906611eebde1b43937

comment:36 Changed 7 years ago by Roman Tolchenov

Display info on the peak overlays. Re #6754.

Changeset: c9d5dd5f0b2d76ec132c20c7eee46581eaaf3ef2

comment:37 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/6880_helpwindow_on_exit' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:38 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/6880_helpwindow_on_exit' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:39 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7600

Note: See TracTickets for help on using tickets.