Ticket #6755 (closed: fixed)

Opened 8 years ago

Last modified 5 years ago

Enable tube_calib.py to calibrate several components

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 2.5
Component: Mantid Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description (last modified by Karl Palmen) (diff)

Currently in the tube calibration scripts, one can calibrate the tubes of a single component, such as the whole instrument, a door or window or an individual tube.

This is done by defining a tube specification for one component (which has one or more tubes) and passing it on to the tube_calib.getCalibration() function.

It would be useful to be able to calibrated several components together. This could be done by either enabling tube_spec to create a specification based several componenents or having a tube_caib.getCalibration function that can take several components.

The first option is simpler for the user, but the second option could be extended to allow different ideal tubes and fit parameters for different components.

Perhaps both options could be implemented.

Change History

comment:1 Changed 8 years ago by Karl Palmen

  • Status changed from new to assigned
  • Owner set to Karl Palmen

comment:2 Changed 8 years ago by Karl Palmen

  • Description modified (diff)
  • Summary changed from CalibrateComponentSet function for tube calibration python scripts to Enable tube_calib.py to calibrate several components

comment:3 Changed 8 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:4 Changed 8 years ago by Karl Palmen

Remove support of discontinuous indices re #6755

Support of discontinuous indices in tube is not used and could complicate future work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0781dea624e6b28158f7cbee673fc656a8d5add4

comment:5 Changed 8 years ago by Karl Palmen

Store specification string in array re #6755

The array currently has no more than one element. More will be added in later work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5c675f0c3d956fc76b62916446faaabd0c0007c5

comment:6 Changed 8 years ago by Karl Palmen

Store component in an array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d09a728486d38483b56cc8e7e3718b055270f414

comment:7 Changed 8 years ago by Karl Palmen

Change the name for component name array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7d79b42dea38ae2ec70ddef28cfd1cd41733c0fd

comment:8 Changed 8 years ago by Karl Palmen

Enable Multiple components to be calibrated re #6755

This can be done by repeatedly calling the setTubeSpecByString method of one tube specification.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 140082e350cf38ecad8aa1b3cf73dd179e855fbd

comment:9 Changed 8 years ago by Karl Palmen

Add an example to test and demonstrate this re #6755

also a small improvement in print out.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7aee6baac040efa978de4f59babe80a0df74bdc8

comment:10 Changed 8 years ago by Karl Palmen

Enable multiple components to be specified by string array re #6755

Also added an example that uses this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9d84e593b103919b496bd4db8f685f3bc0dfdf5a

comment:11 Changed 8 years ago by Karl Palmen

To test, I suggest you run the example scripts TubeCalibDemoMaps_C4C3.py and TubeCalibDemoMaps_C4C3C2.py. You may need to modify the path and fileName variables to get them to work on your machine. The example run is from cycle 09_5.

Check the the expected tubes are listed in the python output and the components appear to be calibrated. This calibration does not neec to be perfect.

You may instead run a different example script and modify it to calibrate multiple components in the same was as the two examples mentioned. If done with MERLIN bear in mind that a calibration from DAT data is done to the tubes not calibrated by the script.

Also test the effect of an invalid component name. This should show a meaningful error message and no calibration be done.

comment:12 Changed 8 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:13 Changed 8 years ago by Karl Palmen

Remove support of discontinuous indices re #6755

Support of discontinuous indices in tube is not used and could complicate future work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0781dea624e6b28158f7cbee673fc656a8d5add4

comment:14 Changed 8 years ago by Karl Palmen

Store specification string in array re #6755

The array currently has no more than one element. More will be added in later work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5c675f0c3d956fc76b62916446faaabd0c0007c5

comment:15 Changed 8 years ago by Karl Palmen

Store component in an array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d09a728486d38483b56cc8e7e3718b055270f414

comment:16 Changed 8 years ago by Karl Palmen

Change the name for component name array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7d79b42dea38ae2ec70ddef28cfd1cd41733c0fd

comment:17 Changed 8 years ago by Karl Palmen

Enable Multiple components to be calibrated re #6755

This can be done by repeatedly calling the setTubeSpecByString method of one tube specification.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 140082e350cf38ecad8aa1b3cf73dd179e855fbd

comment:18 Changed 8 years ago by Karl Palmen

Add an example to test and demonstrate this re #6755

also a small improvement in print out.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7aee6baac040efa978de4f59babe80a0df74bdc8

comment:19 Changed 8 years ago by Karl Palmen

Enable multiple components to be specified by string array re #6755

Also added an example that uses this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9d84e593b103919b496bd4db8f685f3bc0dfdf5a

comment:20 Changed 8 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:21 Changed 8 years ago by Karl Palmen

Remove support of discontinuous indices re #6755

Support of discontinuous indices in tube is not used and could complicate future work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0781dea624e6b28158f7cbee673fc656a8d5add4

comment:22 Changed 8 years ago by Karl Palmen

Store specification string in array re #6755

The array currently has no more than one element. More will be added in later work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5c675f0c3d956fc76b62916446faaabd0c0007c5

comment:23 Changed 8 years ago by Karl Palmen

Store component in an array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d09a728486d38483b56cc8e7e3718b055270f414

comment:24 Changed 8 years ago by Karl Palmen

Change the name for component name array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7d79b42dea38ae2ec70ddef28cfd1cd41733c0fd

comment:25 Changed 8 years ago by Karl Palmen

Enable Multiple components to be calibrated re #6755

This can be done by repeatedly calling the setTubeSpecByString method of one tube specification.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 140082e350cf38ecad8aa1b3cf73dd179e855fbd

comment:26 Changed 8 years ago by Karl Palmen

Add an example to test and demonstrate this re #6755

also a small improvement in print out.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7aee6baac040efa978de4f59babe80a0df74bdc8

comment:27 Changed 8 years ago by Karl Palmen

Enable multiple components to be specified by string array re #6755

Also added an example that uses this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9d84e593b103919b496bd4db8f685f3bc0dfdf5a

comment:28 Changed 8 years ago by Roman Tolchenov

  • Status changed from verifying to closed

comment:29 Changed 7 years ago by Karl Palmen

Remove support of discontinuous indices re #6755

Support of discontinuous indices in tube is not used and could complicate future work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0781dea624e6b28158f7cbee673fc656a8d5add4

comment:30 Changed 7 years ago by Karl Palmen

Store specification string in array re #6755

The array currently has no more than one element. More will be added in later work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5c675f0c3d956fc76b62916446faaabd0c0007c5

comment:31 Changed 7 years ago by Karl Palmen

Store component in an array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d09a728486d38483b56cc8e7e3718b055270f414

comment:32 Changed 7 years ago by Karl Palmen

Change the name for component name array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7d79b42dea38ae2ec70ddef28cfd1cd41733c0fd

comment:33 Changed 7 years ago by Karl Palmen

Enable Multiple components to be calibrated re #6755

This can be done by repeatedly calling the setTubeSpecByString method of one tube specification.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 140082e350cf38ecad8aa1b3cf73dd179e855fbd

comment:34 Changed 7 years ago by Karl Palmen

Add an example to test and demonstrate this re #6755

also a small improvement in print out.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7aee6baac040efa978de4f59babe80a0df74bdc8

comment:35 Changed 7 years ago by Karl Palmen

Enable multiple components to be specified by string array re #6755

Also added an example that uses this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9d84e593b103919b496bd4db8f685f3bc0dfdf5a

comment:36 Changed 7 years ago by Karl Palmen

Remove support of discontinuous indices re #6755

Support of discontinuous indices in tube is not used and could complicate future work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0781dea624e6b28158f7cbee673fc656a8d5add4

comment:37 Changed 7 years ago by Karl Palmen

Store specification string in array re #6755

The array currently has no more than one element. More will be added in later work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5c675f0c3d956fc76b62916446faaabd0c0007c5

comment:38 Changed 7 years ago by Karl Palmen

Store component in an array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d09a728486d38483b56cc8e7e3718b055270f414

comment:39 Changed 7 years ago by Karl Palmen

Change the name for component name array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7d79b42dea38ae2ec70ddef28cfd1cd41733c0fd

comment:40 Changed 7 years ago by Karl Palmen

Enable Multiple components to be calibrated re #6755

This can be done by repeatedly calling the setTubeSpecByString method of one tube specification.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 140082e350cf38ecad8aa1b3cf73dd179e855fbd

comment:41 Changed 7 years ago by Karl Palmen

Add an example to test and demonstrate this re #6755

also a small improvement in print out.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7aee6baac040efa978de4f59babe80a0df74bdc8

comment:42 Changed 7 years ago by Karl Palmen

Enable multiple components to be specified by string array re #6755

Also added an example that uses this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9d84e593b103919b496bd4db8f685f3bc0dfdf5a

comment:43 Changed 7 years ago by Karl Palmen

Remove support of discontinuous indices re #6755

Support of discontinuous indices in tube is not used and could complicate future work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0781dea624e6b28158f7cbee673fc656a8d5add4

comment:44 Changed 7 years ago by Karl Palmen

Store specification string in array re #6755

The array currently has no more than one element. More will be added in later work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5c675f0c3d956fc76b62916446faaabd0c0007c5

comment:45 Changed 7 years ago by Karl Palmen

Store component in an array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d09a728486d38483b56cc8e7e3718b055270f414

comment:46 Changed 7 years ago by Karl Palmen

Change the name for component name array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7d79b42dea38ae2ec70ddef28cfd1cd41733c0fd

comment:47 Changed 7 years ago by Karl Palmen

Enable Multiple components to be calibrated re #6755

This can be done by repeatedly calling the setTubeSpecByString method of one tube specification.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 140082e350cf38ecad8aa1b3cf73dd179e855fbd

comment:48 Changed 7 years ago by Karl Palmen

Add an example to test and demonstrate this re #6755

also a small improvement in print out.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7aee6baac040efa978de4f59babe80a0df74bdc8

comment:49 Changed 7 years ago by Karl Palmen

Enable multiple components to be specified by string array re #6755

Also added an example that uses this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9d84e593b103919b496bd4db8f685f3bc0dfdf5a

comment:50 Changed 7 years ago by Karl Palmen

Remove support of discontinuous indices re #6755

Support of discontinuous indices in tube is not used and could complicate future work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0781dea624e6b28158f7cbee673fc656a8d5add4

comment:51 Changed 7 years ago by Karl Palmen

Store specification string in array re #6755

The array currently has no more than one element. More will be added in later work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5c675f0c3d956fc76b62916446faaabd0c0007c5

comment:52 Changed 7 years ago by Karl Palmen

Store component in an array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d09a728486d38483b56cc8e7e3718b055270f414

comment:53 Changed 7 years ago by Karl Palmen

Change the name for component name array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7d79b42dea38ae2ec70ddef28cfd1cd41733c0fd

comment:54 Changed 7 years ago by Karl Palmen

Enable Multiple components to be calibrated re #6755

This can be done by repeatedly calling the setTubeSpecByString method of one tube specification.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 140082e350cf38ecad8aa1b3cf73dd179e855fbd

comment:55 Changed 7 years ago by Karl Palmen

Add an example to test and demonstrate this re #6755

also a small improvement in print out.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7aee6baac040efa978de4f59babe80a0df74bdc8

comment:56 Changed 7 years ago by Karl Palmen

Enable multiple components to be specified by string array re #6755

Also added an example that uses this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9d84e593b103919b496bd4db8f685f3bc0dfdf5a

comment:57 Changed 7 years ago by Karl Palmen

Remove support of discontinuous indices re #6755

Support of discontinuous indices in tube is not used and could complicate future work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 0781dea624e6b28158f7cbee673fc656a8d5add4

comment:58 Changed 7 years ago by Karl Palmen

Store specification string in array re #6755

The array currently has no more than one element. More will be added in later work.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 5c675f0c3d956fc76b62916446faaabd0c0007c5

comment:59 Changed 7 years ago by Karl Palmen

Store component in an array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d09a728486d38483b56cc8e7e3718b055270f414

comment:60 Changed 7 years ago by Karl Palmen

Change the name for component name array re #6755

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7d79b42dea38ae2ec70ddef28cfd1cd41733c0fd

comment:61 Changed 7 years ago by Karl Palmen

Enable Multiple components to be calibrated re #6755

This can be done by repeatedly calling the setTubeSpecByString method of one tube specification.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 140082e350cf38ecad8aa1b3cf73dd179e855fbd

comment:62 Changed 7 years ago by Karl Palmen

Add an example to test and demonstrate this re #6755

also a small improvement in print out.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 7aee6baac040efa978de4f59babe80a0df74bdc8

comment:63 Changed 7 years ago by Karl Palmen

Enable multiple components to be specified by string array re #6755

Also added an example that uses this.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 9d84e593b103919b496bd4db8f685f3bc0dfdf5a

comment:64 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7601

Note: See TracTickets for help on using tickets.