Ticket #6821 (closed: worksforme)

Opened 8 years ago

Last modified 5 years ago

Make CalibrateMaps take account of varying positions of Calibration Bars

Reported by: Karl Palmen Owned by: Anders Markvardsen
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Harry Jeffery

Description (last modified by Anders Markvardsen) (diff)

This is a ticket for the tube calibration scripts.

The distances between the calibration bars of MAPS varies between windows. Modify CalibrateMaps to take account of this.

It should be easy to do when the fix to #6755 becomes available.

Change History

comment:1 Changed 8 years ago by Karl Palmen

  • Cc anders.markvardsen@… added

comment:2 Changed 8 years ago by Karl Palmen

  • Status changed from new to assigned
  • Owner set to Karl Palmen

comment:3 Changed 7 years ago by Karl Palmen

I intend to use ideal tubes as follows:

A, B and C windows (-0.50375, -0.16667, 0.0 +0.16667, 0.50375)

D windows (-0.715, -0.2205, 0.0, 0.2205, 0.715)

E windows not calibrated because they have no bar shadows.

comment:4 Changed 7 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:5 Changed 7 years ago by Karl Palmen

Modify CalibrateMaps() appropriately re #6821

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d1a3aab44557f333f7a45130c5804610ab2693cd

comment:6 Changed 7 years ago by Karl Palmen

Merge Manually with Master re #6821

This was necessary, because of a delay in completing the testing of ticket #6752.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 816238c938d0082aa922375267542a2f309a18e1

comment:7 Changed 7 years ago by Karl Palmen

Modify CalibrateMaps() appropriately re #6821

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d1a3aab44557f333f7a45130c5804610ab2693cd

comment:8 Changed 7 years ago by Karl Palmen

Merge Manually with Master re #6821

This was necessary, because of a delay in completing the testing of ticket #6752.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 816238c938d0082aa922375267542a2f309a18e1

comment:9 Changed 7 years ago by Karl Palmen

Merge branch 'feature/6821_maps_vary' into develop re #6821

Conflicts:

Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_Simple.py

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 691c8dc9aad684aa2bbb490ffb3cf94b49dec6d5

comment:10 Changed 7 years ago by Karl Palmen

To test run the scipts/Calibration/Examples/TubeDemoMaps_Simple.py script verify that it runs without error and the horizontal tubes are long enough to touch each other and the instrument looks OK without very much wiggle in the shadow lines.

comment:11 Changed 7 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:12 Changed 7 years ago by Karl Palmen

Modify CalibrateMaps() appropriately re #6821

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d1a3aab44557f333f7a45130c5804610ab2693cd

comment:13 Changed 7 years ago by Karl Palmen

Merge Manually with Master re #6821

This was necessary, because of a delay in completing the testing of ticket #6752.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 816238c938d0082aa922375267542a2f309a18e1

comment:14 Changed 7 years ago by Karl Palmen

Merge branch 'feature/6821_maps_vary' into develop re #6821

Conflicts:

Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_Simple.py

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 691c8dc9aad684aa2bbb490ffb3cf94b49dec6d5

comment:15 Changed 7 years ago by Karl Palmen

Modify CalibrateMaps() appropriately re #6821

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d1a3aab44557f333f7a45130c5804610ab2693cd

comment:16 Changed 7 years ago by Karl Palmen

Merge Manually with Master re #6821

This was necessary, because of a delay in completing the testing of ticket #6752.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 816238c938d0082aa922375267542a2f309a18e1

comment:17 Changed 7 years ago by Karl Palmen

Merge branch 'feature/6821_maps_vary' into develop re #6821

Conflicts:

Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_Simple.py

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 691c8dc9aad684aa2bbb490ffb3cf94b49dec6d5

comment:18 Changed 7 years ago by Karl Palmen

Modify CalibrateMaps() appropriately re #6821

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d1a3aab44557f333f7a45130c5804610ab2693cd

comment:19 Changed 7 years ago by Karl Palmen

Merge Manually with Master re #6821

This was necessary, because of a delay in completing the testing of ticket #6752.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 816238c938d0082aa922375267542a2f309a18e1

comment:20 Changed 7 years ago by Karl Palmen

Merge branch 'feature/6821_maps_vary' into develop re #6821

Conflicts:

Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_Simple.py

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 691c8dc9aad684aa2bbb490ffb3cf94b49dec6d5

comment:21 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:22 Changed 7 years ago by Karl Palmen

Modify CalibrateMaps() appropriately re #6821

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d1a3aab44557f333f7a45130c5804610ab2693cd

comment:23 Changed 7 years ago by Karl Palmen

Merge Manually with Master re #6821

This was necessary, because of a delay in completing the testing of ticket #6752.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 816238c938d0082aa922375267542a2f309a18e1

comment:24 Changed 7 years ago by Karl Palmen

Merge branch 'feature/6821_maps_vary' into develop re #6821

Conflicts:

Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_Simple.py

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 691c8dc9aad684aa2bbb490ffb3cf94b49dec6d5

comment:25 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

not sure if I see the right output

comment:26 Changed 7 years ago by Anders Markvardsen

  • Owner changed from Karl Palmen to Anders Markvardsen
  • Status changed from reopened to assigned

comment:27 Changed 7 years ago by Anders Markvardsen

  • Milestone changed from Release 2.5 to Release 2.6

comment:28 Changed 7 years ago by Karl Palmen

Modify CalibrateMaps() appropriately re #6821

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d1a3aab44557f333f7a45130c5804610ab2693cd

comment:29 Changed 7 years ago by Karl Palmen

Merge Manually with Master re #6821

This was necessary, because of a delay in completing the testing of ticket #6752.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 816238c938d0082aa922375267542a2f309a18e1

comment:30 Changed 7 years ago by Karl Palmen

Merge branch 'feature/6821_maps_vary' into develop re #6821

Conflicts:

Code/Mantid/scripts/Calibration/Examples/TubeCalibDemoMaps_Simple.py

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 691c8dc9aad684aa2bbb490ffb3cf94b49dec6d5

comment:31 Changed 7 years ago by Peter Peterson

Merge branch 'feature/6846_qtassistant_singleton' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:32 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/6788_inst_view_scripting' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:33 Changed 7 years ago by Russell Taylor

Merge branch 'feature/6371_step_scan_gui' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:34 Changed 7 years ago by Peter Peterson

Merge branch 'feature/6846_qtassistant_singleton' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:35 Changed 7 years ago by Martyn Gigg

Merge branch 'feature/6788_inst_view_scripting' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:36 Changed 7 years ago by Russell Taylor

Merge branch 'feature/6371_step_scan_gui' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:37 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:38 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:39 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:40 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:41 Changed 6 years ago by Anders Markvardsen

  • Cc anders.markvardsen@… removed
  • Status changed from assigned to verify
  • Resolution set to worksforme
  • Description modified (diff)
  • Tester Anders Markvardsen deleted

This now works as demonstrated here: http://www.mantidproject.org/Tube_Calibration_Examples#Running_TubeCalibDemoMaps_All.py which shows the full calibration of maps as has been demonstrated to instrument scientists

comment:42 Changed 6 years ago by Harry Jeffery

  • Milestone changed from Backlog to Release 3.3

comment:43 Changed 6 years ago by Harry Jeffery

  • Status changed from verify to verifying
  • Tester set to Harry Jeffery

comment:44 Changed 6 years ago by Harry Jeffery

  • Status changed from verifying to closed

comment:45 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7667

Note: See TracTickets for help on using tickets.