Ticket #6851 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Updates to Powder Diffraction Reduction GUI

Reported by: Peter Peterson Owned by: Wenduo Zhou
Priority: minor Milestone: Release 2.5
Component: Mantid Keywords:
Cc: Blocked By: #6861
Blocking: Tester: Vickie Lynch

Description

A bunch of little issues

  • For overriding characterization runs, there is no need for the checkbox. If the number is supplied it should be used. The
  • PreserveEvents=True should be default
  • StripVanadiumPeaks=True should be default
  • RemovePromptPulseWidth=50 should be default
  • Disabled widgets get redisabled when switching tabs (example: the widgets that are enabled when you select StripVanadiumPeaks)

Change History

comment:1 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:2 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:3 Changed 7 years ago by Wenduo Zhou

  • Blocked By 6861 added

comment:4 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6851.

Modifications include

  1. Set PreserveEvents' default to True;
  2. set StripVanadiumPeaks's default to True;
  3. Set RemovePromptPulseWidth's default to 50;
  4. Remove all "override" buttons in run setup tab related to

corrections (not fully tested).

Changeset: b06c16e6ae0347573acbf815d8317a905fbf0b8c

comment:5 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to accepted

comment:6 Changed 7 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

Reported issue "Disabled widgets get redisabled when switching tabs (example: the widgets that are enabled when you select StripVanadiumPeaks)" cannot be observed on Ubuntu 12.04.

Last edited 7 years ago by Wenduo Zhou (previous) (diff)

comment:7 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6851.

Modifications include

  1. Set PreserveEvents' default to True;
  2. set StripVanadiumPeaks's default to True;
  3. Set RemovePromptPulseWidth's default to 50;
  4. Remove all "override" buttons in run setup tab related to

corrections (not fully tested).

Changeset: b06c16e6ae0347573acbf815d8317a905fbf0b8c

comment:8 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:9 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

If start the gui up with "StripVanadiumPeaks=True" the boxes beneath it are disabled. Unchecking then checking the box re-enables them will work around the issue, but it should be fixed.

comment:10 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:11 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:12 Changed 7 years ago by Wenduo Zhou

  • Status changed from reopened to accepted

comment:13 Changed 7 years ago by Wenduo Zhou

Fix the enable/disable issue with van peak strip. Refs #6851.

Changeset: c8bdb29cc4f307491f3e37587075327a5f62ed92

comment:14 Changed 7 years ago by Wenduo Zhou

Fix the enable/disable issue with van peak strip. Refs #6851.

Changeset: c8bdb29cc4f307491f3e37587075327a5f62ed92

comment:15 Changed 7 years ago by Wenduo Zhou

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:16 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:17 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:18 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6851.

Modifications include

  1. Set PreserveEvents' default to True;
  2. set StripVanadiumPeaks's default to True;
  3. Set RemovePromptPulseWidth's default to 50;
  4. Remove all "override" buttons in run setup tab related to

corrections (not fully tested).

Changeset: b06c16e6ae0347573acbf815d8317a905fbf0b8c

comment:19 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:20 Changed 7 years ago by Wenduo Zhou

Fix the enable/disable issue with van peak strip. Refs #6851.

Changeset: c8bdb29cc4f307491f3e37587075327a5f62ed92

comment:21 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:22 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:23 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6851.

Modifications include

  1. Set PreserveEvents' default to True;
  2. set StripVanadiumPeaks's default to True;
  3. Set RemovePromptPulseWidth's default to 50;
  4. Remove all "override" buttons in run setup tab related to

corrections (not fully tested).

Changeset: b06c16e6ae0347573acbf815d8317a905fbf0b8c

comment:24 Changed 7 years ago by Wenduo Zhou

Fix the enable/disable issue with van peak strip. Refs #6851.

Changeset: c8bdb29cc4f307491f3e37587075327a5f62ed92

comment:25 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:26 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6851.

Modifications include

  1. Set PreserveEvents' default to True;
  2. set StripVanadiumPeaks's default to True;
  3. Set RemovePromptPulseWidth's default to 50;
  4. Remove all "override" buttons in run setup tab related to

corrections (not fully tested).

Changeset: b06c16e6ae0347573acbf815d8317a905fbf0b8c

comment:27 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:28 Changed 7 years ago by Wenduo Zhou

Fix the enable/disable issue with van peak strip. Refs #6851.

Changeset: c8bdb29cc4f307491f3e37587075327a5f62ed92

comment:29 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to verifying
  • Tester changed from Peter Peterson to Vickie Lynch

comment:30 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:31 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6851.

Modifications include

  1. Set PreserveEvents' default to True;
  2. set StripVanadiumPeaks's default to True;
  3. Set RemovePromptPulseWidth's default to 50;
  4. Remove all "override" buttons in run setup tab related to

corrections (not fully tested).

Changeset: b06c16e6ae0347573acbf815d8317a905fbf0b8c

comment:32 Changed 7 years ago by Wenduo Zhou

Fix the enable/disable issue with van peak strip. Refs #6851.

Changeset: c8bdb29cc4f307491f3e37587075327a5f62ed92

comment:33 Changed 7 years ago by Vickie Lynch

  • Status changed from verifying to closed

The problem Peter found with "StripVanadiumPeaks=True" in the Powder Diffraction Reduction interface has been fixed.

comment:34 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:35 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: 1753727d5c4aaf41cec4b96333c6eef6303ea837

comment:36 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6851.

Modifications include

  1. Set PreserveEvents' default to True;
  2. set StripVanadiumPeaks's default to True;
  3. Set RemovePromptPulseWidth's default to 50;
  4. Remove all "override" buttons in run setup tab related to

corrections (not fully tested).

Changeset: b06c16e6ae0347573acbf815d8317a905fbf0b8c

comment:37 Changed 7 years ago by Wenduo Zhou

Fix the enable/disable issue with van peak strip. Refs #6851.

Changeset: c8bdb29cc4f307491f3e37587075327a5f62ed92

comment:38 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6851.

Modifications include

  1. Set PreserveEvents' default to True;
  2. set StripVanadiumPeaks's default to True;
  3. Set RemovePromptPulseWidth's default to 50;
  4. Remove all "override" buttons in run setup tab related to

corrections (not fully tested).

Changeset: b06c16e6ae0347573acbf815d8317a905fbf0b8c

comment:39 Changed 7 years ago by Wenduo Zhou

Fix the enable/disable issue with van peak strip. Refs #6851.

Changeset: c8bdb29cc4f307491f3e37587075327a5f62ed92

comment:40 Changed 7 years ago by Wenduo Zhou

Checkpointing work. Refs #6851.

Modifications include

  1. Set PreserveEvents' default to True;
  2. set StripVanadiumPeaks's default to True;
  3. Set RemovePromptPulseWidth's default to 50;
  4. Remove all "override" buttons in run setup tab related to

corrections (not fully tested).

Changeset: b06c16e6ae0347573acbf815d8317a905fbf0b8c

comment:41 Changed 7 years ago by Alex Buts

refs #5856 & #6851 Experiment info converted into methadata

This commit goes for both tickets as we need to have run_number as methadata too.

Changeset: a20cb78510bc1fad95b37200525e69e74eecb023

comment:42 Changed 7 years ago by Wenduo Zhou

Fix the enable/disable issue with van peak strip. Refs #6851.

Changeset: c8bdb29cc4f307491f3e37587075327a5f62ed92

comment:43 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7697

Note: See TracTickets for help on using tickets.