Ticket #6865 (closed: fixed)
Enable ConvertToMD performance tests when #6449 and #6852 are merged to the masted
| Reported by: | Alex Buts | Owned by: | Alex Buts |
|---|---|---|---|
| Priority: | major | Milestone: | Release 2.5 |
| Component: | Mantid | Keywords: | |
| Cc: | Blocked By: | #6449, #6852 | |
| Blocking: | Tester: | Michael Reuter |
Description
The performace tests on convertToMD are mysteriously depend on changes introduced by ticket #6852
At the moment I have fixed the tests according to #6852 but disabled them as the branch 6449 itself should not depend on these changes
When both #6449 and #6852 are merged to master, these tests should be enabled.
Change History
comment:2 Changed 7 years ago by Alex Buts
refs #6865 W-matrix fixed and the tests can now be enabled
Changeset: 6c74e5d7685bd4342ae81ecddd19445931b87bad
comment:3 Changed 7 years ago by Alex Buts
refs #6865 W-matrix fixed and the tests can now be enabled
Changeset: 6c74e5d7685bd4342ae81ecddd19445931b87bad
comment:4 Changed 7 years ago by Alex Buts
- Status changed from accepted to verify
- Resolution set to fixed
This is trivial ticket to test.
As soon as #6852 is merged into master, you should be able to merge this branch and the ConvertToMDTestPerformance from ConvertToMDTest.h should compile and run without errors.
The ticket branch is actually bugfix/6865_ etc...
comment:5 Changed 7 years ago by Alex Buts
refs #6865 This should give the property correct type
Changeset: 1a20c0aa33bde991819dd7dbbe01c817b2ac0aaa
comment:6 Changed 7 years ago by Alex Buts
refs #6865 This should give the property correct type
Changeset: 1a20c0aa33bde991819dd7dbbe01c817b2ac0aaa
comment:7 Changed 7 years ago by Alex Buts
refs #6865 Initial changes to possible q-frame options
Changeset: 9040294459c9fafd24c47425b86c716ac610cb6d
comment:8 Changed 7 years ago by Alex Buts
refs #6865 Should allow user to choose a frame of interest in Q3D mode
Changeset: 8a245b6a9c99975be9ef84e3096aa86616d33f58
comment:9 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:10 Changed 7 years ago by Alex Buts
refs #6865 This should fix it
e.g. enabled explicit selection of QFrame. A but more tests is still needed.
Changeset: dc1e4822094055f3109fd57e2069669b0e36ff59
comment:11 Changed 7 years ago by Alex Buts
refs #6865 W-matrix fixed and the tests can now be enabled
Changeset: 6c74e5d7685bd4342ae81ecddd19445931b87bad
comment:12 Changed 7 years ago by Alex Buts
refs #6865 This should give the property correct type
Changeset: 1a20c0aa33bde991819dd7dbbe01c817b2ac0aaa
comment:13 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
This looks to be working correctly.
comment:14 Changed 7 years ago by Alex Buts
refs #6865 Initial changes to possible q-frame options
Changeset: 9040294459c9fafd24c47425b86c716ac610cb6d
comment:15 Changed 7 years ago by Alex Buts
refs #6865 Should allow user to choose a frame of interest in Q3D mode
Changeset: 8a245b6a9c99975be9ef84e3096aa86616d33f58
comment:16 Changed 7 years ago by Alex Buts
refs #6865 This should fix it
e.g. enabled explicit selection of QFrame. A but more tests is still needed.
Changeset: dc1e4822094055f3109fd57e2069669b0e36ff59
comment:17 Changed 7 years ago by Alex Buts
refs #6865 W-matrix fixed and the tests can now be enabled
Changeset: 6c74e5d7685bd4342ae81ecddd19445931b87bad
comment:18 Changed 7 years ago by Alex Buts
refs #6865 This should give the property correct type
Changeset: 1a20c0aa33bde991819dd7dbbe01c817b2ac0aaa
comment:19 Changed 7 years ago by Alex Buts
refs #6865 W-matrix fixed and the tests can now be enabled
Changeset: 6c74e5d7685bd4342ae81ecddd19445931b87bad
comment:20 Changed 7 years ago by Alex Buts
refs #6865 This should give the property correct type
Changeset: 1a20c0aa33bde991819dd7dbbe01c817b2ac0aaa
comment:21 Changed 7 years ago by Alex Buts
refs #6865 Initial changes to possible q-frame options
Changeset: 9040294459c9fafd24c47425b86c716ac610cb6d
comment:22 Changed 7 years ago by Alex Buts
refs #6865 Should allow user to choose a frame of interest in Q3D mode
Changeset: 8a245b6a9c99975be9ef84e3096aa86616d33f58
comment:23 Changed 7 years ago by Alex Buts
refs #6865 This should fix it
e.g. enabled explicit selection of QFrame. A but more tests is still needed.
Changeset: dc1e4822094055f3109fd57e2069669b0e36ff59
comment:24 Changed 7 years ago by Alex Buts
refs #6865 W-matrix fixed and the tests can now be enabled
Changeset: 6c74e5d7685bd4342ae81ecddd19445931b87bad
comment:25 Changed 7 years ago by Alex Buts
refs #6865 This should give the property correct type
Changeset: 1a20c0aa33bde991819dd7dbbe01c817b2ac0aaa
comment:26 Changed 7 years ago by Alex Buts
refs #6865 Initial changes to possible q-frame options
Changeset: 9040294459c9fafd24c47425b86c716ac610cb6d
comment:27 Changed 7 years ago by Alex Buts
refs #6865 Should allow user to choose a frame of interest in Q3D mode
Changeset: 8a245b6a9c99975be9ef84e3096aa86616d33f58
comment:28 Changed 7 years ago by Alex Buts
refs #6865 This should fix it
e.g. enabled explicit selection of QFrame. A but more tests is still needed.
Changeset: dc1e4822094055f3109fd57e2069669b0e36ff59
comment:29 Changed 7 years ago by Alex Buts
refs #6865 W-matrix fixed and the tests can now be enabled
Changeset: 6c74e5d7685bd4342ae81ecddd19445931b87bad
comment:30 Changed 7 years ago by Alex Buts
refs #6865 This should give the property correct type
Changeset: 1a20c0aa33bde991819dd7dbbe01c817b2ac0aaa
comment:31 Changed 7 years ago by Alex Buts
refs #6865 Initial changes to possible q-frame options
Changeset: 9040294459c9fafd24c47425b86c716ac610cb6d
comment:32 Changed 7 years ago by Alex Buts
refs #6865 Should allow user to choose a frame of interest in Q3D mode
Changeset: 8a245b6a9c99975be9ef84e3096aa86616d33f58
comment:33 Changed 7 years ago by Alex Buts
refs #6865 This should fix it
e.g. enabled explicit selection of QFrame. A but more tests is still needed.
Changeset: dc1e4822094055f3109fd57e2069669b0e36ff59
comment:34 Changed 7 years ago by Alex Buts
refs #6865 Initial changes to possible q-frame options
Changeset: 9040294459c9fafd24c47425b86c716ac610cb6d
comment:35 Changed 7 years ago by Alex Buts
refs #6865 Should allow user to choose a frame of interest in Q3D mode
Changeset: 8a245b6a9c99975be9ef84e3096aa86616d33f58
comment:36 Changed 7 years ago by Alex Buts
refs #6865 This should fix it
e.g. enabled explicit selection of QFrame. A but more tests is still needed.
Changeset: dc1e4822094055f3109fd57e2069669b0e36ff59
comment:37 Changed 7 years ago by Alex Buts
refs #6865 Initial changes to possible q-frame options
Changeset: 9040294459c9fafd24c47425b86c716ac610cb6d
comment:38 Changed 7 years ago by Alex Buts
refs #6865 Should allow user to choose a frame of interest in Q3D mode
Changeset: 8a245b6a9c99975be9ef84e3096aa86616d33f58
comment:39 Changed 7 years ago by Alex Buts
refs #6865 This should fix it
e.g. enabled explicit selection of QFrame. A but more tests is still needed.
Changeset: dc1e4822094055f3109fd57e2069669b0e36ff59
comment:40 Changed 7 years ago by Alex Buts
refs #6865 W-matrix fixed and the tests can now be enabled
Changeset: 6c74e5d7685bd4342ae81ecddd19445931b87bad
comment:41 Changed 7 years ago by Alex Buts
refs #6865 This should give the property correct type
Changeset: 1a20c0aa33bde991819dd7dbbe01c817b2ac0aaa
comment:42 Changed 7 years ago by Alex Buts
refs #6865 Initial changes to possible q-frame options
Changeset: 9040294459c9fafd24c47425b86c716ac610cb6d
comment:43 Changed 7 years ago by Alex Buts
refs #6865 Should allow user to choose a frame of interest in Q3D mode
Changeset: 8a245b6a9c99975be9ef84e3096aa86616d33f58
comment:44 Changed 7 years ago by Alex Buts
refs #6865 This should fix it
e.g. enabled explicit selection of QFrame. A but more tests is still needed.
Changeset: dc1e4822094055f3109fd57e2069669b0e36ff59
comment:45 Changed 7 years ago by Alex Buts
refs #6865 merge with develop and resolve conflicts (again)
Merge branch 'feature/6856_ConvertToDiffractionMDWS_v2' into develop
Conflicts:
Code/Mantid/Framework/MDAlgorithms/src/ConvertToMD.cpp
Changeset: 1d94c2cfdb8be314cb18ec66810f90ee25b1fc89
comment:46 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7711
