Ticket #6896 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Unit test for ModifyDetectorDotDatFile

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Nick Draper

Description


Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Karl Palmen

comment:2 Changed 7 years ago by Karl Palmen

There does not seem to be an algorithm that loads a DetectorDotDat file. This would be very useful in the test, so we can verify that the DetectorDotDeat file was modified correctly.

comment:3 Changed 7 years ago by Karl Palmen

Anders has told me that LoadDetectorInfo will load a DetectorDotDat file.

http://www.mantidproject.org/LoadDetectorInfo

comment:4 Changed 7 years ago by Karl Palmen

LoadDetectorInfo has a unit test, which will be useful for creating this desired unit test.

comment:5 Changed 7 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:6 Changed 7 years ago by Karl Palmen

Improve wiki re #6896

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: c513d5c7a605427c5cbb14d1b32b28c5a297dabd

comment:7 Changed 7 years ago by Nick Draper

  • Status changed from accepted to assigned

comment:8 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:9 Changed 7 years ago by Karl Palmen

  • Status changed from new to inprogress

comment:10 Changed 7 years ago by Karl Palmen

Add skeleton unit test re #6896

Just tests initialization of the algorithm.

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: b49907b2a93cb469894e351969b809b99738ebaf

comment:11 Changed 7 years ago by Karl Palmen

Test header of Output file re #6896

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 3e3ede101e11d18b8b47e14f5e6e9e63badcab93

comment:12 Changed 7 years ago by Karl Palmen

Modify and simplify test file re #6896

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: d68e5c208552a7040ea6997ab88e70c5168d1edd

comment:13 Changed 7 years ago by Karl Palmen

Check start of 3rd line of output file re #6896

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 4c68b30fc2aecce1b6d9c68322db37d7f9ced4f0

comment:14 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:15 Changed 7 years ago by Karl Palmen

Test some of output file contents re #6896

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 4d4d97b481d24ee8379a9c939e9c46fcffd27afa

comment:16 Changed 7 years ago by Karl Palmen

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test review the code. Check that there is a unit test ModifyDetectorDotDatFileTest and it tests the essential features of the algorithm as described in the wiki. You may also run the test to check it works on your system.

comment:17 Changed 7 years ago by Nick Draper

  • Status changed from verify to verifying
  • Tester set to Nick Draper

comment:18 Changed 7 years ago by Nick Draper

Code review looks good. Test is present and takes only 0.12 seconds.

comment:19 Changed 7 years ago by Nick Draper

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/6896_new_unit_test'

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7742

Note: See TracTickets for help on using tickets.