Ticket #6962 (closed: fixed)
SANS: Move SANSWideAngleCorrection to Python 2nd version
| Reported by: | Gesner Passos | Owned by: | Gesner Passos |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 2.6 |
| Component: | Python | Keywords: | Maintenance |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Nick Draper |
Description
Correct the work properly as explained at #6529
Change History
comment:1 Changed 7 years ago by Nick Draper
- Keywords Maintenance added
- Priority changed from blocker to critical
comment:2 Changed 7 years ago by Gesner Passos
Creation of SANSWideAngleCorrection python api 2
re #6962
Changeset: 1c82fa40cf6cd8bbf507800cf64975b012f8ccba
comment:3 Changed 7 years ago by Gesner Passos
Update documentation SANSWideAngleCorrection
re #6962
Changeset: 44d9cefd1b24b32df861bc55d2c40730b8376c35
comment:4 Changed 7 years ago by Gesner Passos
Some improvements to SANSWideAngleCorrection
Progress reporting, and moving toward directives of python new api.
re #6962
Changeset: 4b07e10018a1d4b95b22d6f2ca51342f2af3e30b
comment:5 Changed 7 years ago by Gesner Passos
Add unit test for SANSWideAngleCorrection
re #6962
Changeset: 4264c9b035dc4102e37a6af724e14229638d46d3
comment:6 Changed 7 years ago by Gesner Passos
Make the unit test independent of loading file data
it is required from the 'good practices' inside Mantid Team.
re #6962
Changeset: 91ed168d269b98c74dc90b1a951e0bb8b701a3dd
comment:7 Changed 7 years ago by Gesner Passos
Move documentation note to the usage section
The scientist suggested to put there. Now, that I'm aware of WIKI_USAGE keyword, I decided to put inside the usage this note.
re #6962
Changeset: 6d17b8ed4e4ff873eaefe98ba3cab1e3acb86263
comment:8 Changed 7 years ago by Gesner Passos
Adjust the equations so to not break the qtassistant
re #6962
Changeset: 2ac65a3292ee003de2b2f5815476ee6189be331e
comment:10 Changed 7 years ago by Gesner Passos
- Status changed from accepted to verify
- Resolution set to fixed
It does not only translated the algorithm to v2, but I also tried to fulfill the requirements for adding a unittest, adding documentation, and so on.
So the Tester is invited to:
- review the code to see if it is clear and well organized and has nothing to do with python v1
- agree that the unit test is sufficient
- perform the happy test described at #6529 (which should work nicely)
- review the documentation http://www.mantidproject.org/SANSWideAngleCorrection
comment:11 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:12 Changed 7 years ago by Nick Draper
- Status changed from verifying to closed
Really nice documentation. Also addition of a unit test which is really appreciated. Code review is sensible, unit test passes well.
comment:13 Changed 7 years ago by Gesner Passos
Creation of SANSWideAngleCorrection python api 2
re #6962
Changeset: 1c82fa40cf6cd8bbf507800cf64975b012f8ccba
comment:14 Changed 7 years ago by Gesner Passos
Update documentation SANSWideAngleCorrection
re #6962
Changeset: 44d9cefd1b24b32df861bc55d2c40730b8376c35
comment:15 Changed 7 years ago by Gesner Passos
Some improvements to SANSWideAngleCorrection
Progress reporting, and moving toward directives of python new api.
re #6962
Changeset: 4b07e10018a1d4b95b22d6f2ca51342f2af3e30b
comment:16 Changed 7 years ago by Gesner Passos
Add unit test for SANSWideAngleCorrection
re #6962
Changeset: 4264c9b035dc4102e37a6af724e14229638d46d3
comment:17 Changed 7 years ago by Gesner Passos
Make the unit test independent of loading file data
it is required from the 'good practices' inside Mantid Team.
re #6962
Changeset: 91ed168d269b98c74dc90b1a951e0bb8b701a3dd
comment:18 Changed 7 years ago by Gesner Passos
Move documentation note to the usage section
The scientist suggested to put there. Now, that I'm aware of WIKI_USAGE keyword, I decided to put inside the usage this note.
re #6962
Changeset: 6d17b8ed4e4ff873eaefe98ba3cab1e3acb86263
comment:19 Changed 7 years ago by Gesner Passos
Adjust the equations so to not break the qtassistant
re #6962
Changeset: 2ac65a3292ee003de2b2f5815476ee6189be331e
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7808
