Ticket #6971 (inprogress)
TOSCA sample position correction algorithm
Reported by: | Dereck Kachere | Owned by: | Dan Nixon |
---|---|---|---|
Priority: | major | Milestone: | Release 3.5 |
Component: | Indirect Inelastic | Keywords: | |
Cc: | silvia.imberti@… | Blocked By: | |
Blocking: | Tester: |
Description (last modified by Dan Nixon) (diff)
Add an algorithm that can be used to correct for change in the sample position of reduced TOSCA data.
Silvia has requested involvement in testing the ticket.
Some runs that demonstrate the issue are: 14007, 14009, 14011, 14013, 14015
Change History
comment:1 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
- Owner set to Dereck Kachere
comment:4 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:5 Changed 7 years ago by Samuel Jackson
- Owner changed from Dereck Kachere to Samuel Jackson
- Description modified (diff)
comment:6 Changed 7 years ago by Samuel Jackson
- Component changed from Framework to Indirect Inelastic
comment:7 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
Bulk move to assigned at the introduction of the triage step
comment:11 Changed 6 years ago by Dan Nixon
- Milestone changed from Backlog to Release 3.4
This can probably be implemented as a general option where the position reported by Instrument.getSample().getPos() can be offset by a given value in each axis.
comment:13 Changed 6 years ago by Dan Nixon
- Status changed from assigned to inprogress
comment:14 Changed 6 years ago by Dan Nixon
Use a combo box to define type, display default position
Refs #6971
Changeset: 6c9f93f198a9c8bbde6934de6ad540c1ff532758
comment:15 Changed 6 years ago by Dan Nixon
UI part done, needs algorithm support.
Will be easiest to do through the reduction algorithm using the MoveInstrumentComponent algorithm.
comment:16 Changed 6 years ago by Dan Nixon
- Summary changed from [C2E] - Energy Transfer Tab Additional Feature - (TOSCA Sample Position) to IDR ET: TOSCA Sample Position Option
comment:17 Changed 6 years ago by Dan Nixon
After discussion with instrument scientists it has been decided that an algorithm to find peaks on the forward and back detector bank spectra and apply a symmetric shift in x such that the peak centres are at the same point is the way to go about this.
comment:18 Changed 6 years ago by Dan Nixon
comment:19 Changed 6 years ago by Dan Nixon
- Description modified (diff)
- Summary changed from IDR ET: TOSCA Sample Position Option to TOSCA sample position correction algorithm
comment:22 Changed 6 years ago by Dan Nixon
Added documentation and error handing when no peaks found
Refs #6971
Changeset: fe508fd0fad8769dbaaea82eeeec4e9f29573a49
comment:23 Changed 6 years ago by Dan Nixon
comment:24 Changed 6 years ago by Dan Nixon
Work in progress commit
Adding peak position option
Refs #6971
Changeset: 7709ae6b9f2c2ad5c21a1beb1d860c44bd1a86be
comment:25 Changed 6 years ago by Dan Nixon
comment:26 Changed 6 years ago by Dan Nixon
comment:27 Changed 6 years ago by Dan Nixon
Merge branch 'master' into 6971_tosca_sample_position_correction
Refs #6971
Changeset: 6918ddcd5d8e5333c669df0648ba86d533b303ce
comment:28 Changed 6 years ago by Dan Nixon
comment:29 Changed 6 years ago by Dan Nixon
Add doc test for correction algo
And usage data note for some that were missing it
Refs #6971
Changeset: b088792c191bdff1ba893cc69e91391153ea4ec5
comment:30 Changed 6 years ago by Dan Nixon
Merge branch 'master' into 6971_tosca_sample_position_correction
Refs #6971
Changeset: 36428ba2fa37c91dead10ca7558a73396dab1855
comment:31 Changed 6 years ago by Dan Nixon
comment:32 Changed 5 years ago by Nick Draper
- Milestone changed from Release 3.4 to Release 3.5
Moved to R3.5 at the R3.4 code freeze
comment:33 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7817