Ticket #6978 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Muon: time zero and first good bin

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: blocker Milestone: Release 2.5
Component: MantidPlot Keywords:
Cc: stephen.cottrell@… Blocked By:
Blocking: Tester: Gesner Passos

Description

From feedback from Steve.

A few improvements to fit in for this release. Better description to follow.

Change History

comment:1 Changed 7 years ago by Anders Markvardsen

Allowed time zero to 'reset'. re #6978

Changeset: 2ccfeb32f034c29ff1bff4280edfe832e38e22d8

comment:2 Changed 7 years ago by Anders Markvardsen

Allowed time zero to 'reset'. re #6978

Changeset: 2ccfeb32f034c29ff1bff4280edfe832e38e22d8

comment:3 Changed 7 years ago by Anders Markvardsen

  • Status changed from new to accepted
  • Component changed from Mantid to MantidPlot

Here dealt with the most pressing feedback related to the time zero issue. I have moved the first good bin issue to the next release #6990

To test:

1 Open MuonAnalysis interface

2 Load any muon data, e.g. browse to AutoTestdata and select MUSR00015189.nxs

3 Take a noticed of this plot (depending on your setttings in the settings it may be overwritten in the next step)

4 Change 'Time Zero' from 0.55 to 1.55 for example and press the plot button you should see plot change

5 Change 'Time zero' back to 0.55 and you should see the same plot as plotted from step 3

comment:4 Changed 7 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:5 Changed 7 years ago by Nick Draper

Compiles successfully, passes suggested test.

Crash found if text in the box, new ticket #6998

I'm on a promise from Anders that this will be properly tested for usage by Stephen tomorrow.

comment:6 Changed 7 years ago by Anders Markvardsen

Allowed time zero to 'reset'. re #6978

Changeset: 2ccfeb32f034c29ff1bff4280edfe832e38e22d8

comment:7 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:8 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to verify
  • Tester Andrei Savici deleted

Did not notice that someone wants to do a better check

comment:9 Changed 7 years ago by Anders Markvardsen

Testing done by Steve:

Hi,

I’ve downloaded the latest build and things look to be working well for adjusting time zero forwards and backwards

comment:10 Changed 7 years ago by Gesner Passos

  • Status changed from verify to verifying
  • Tester set to Gesner Passos

comment:11 Changed 7 years ago by Gesner Passos

  • Status changed from verifying to closed

It has been tested by Steve and it is already at master. So, I will just close it.

comment:12 Changed 7 years ago by Anders Markvardsen

Allowed time zero to 'reset'. re #6978

Changeset: 2ccfeb32f034c29ff1bff4280edfe832e38e22d8

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7824

Note: See TracTickets for help on using tickets.