Ticket #7053 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Completely remove old python API for ORNL SANS

Reported by: Mathieu Doucet Owned by: Mathieu Doucet
Priority: critical Milestone: Release 3.0
Component: Python Keywords:
Cc: Blocked By:
Blocking: #7690 Tester: Andrei Savici

Description (last modified by Nick Draper) (diff)

The ORNL SANS reduction code is currently able to produce script for both the old and the new python API. The new API will be turned used be default with release 2.6. The old API should be removed for release 2.7.

This includes:

  • Remove old API option from the Tools menu
  • Remove the script generation code for the old API
  • Remove checks for the API version (it will always be v2)
  • Remove old API SANS reducer code

Change History

comment:1 Changed 7 years ago by Mathieu Doucet

  • Priority changed from major to critical

comment:2 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.7 to Backlog

comment:3 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:4 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Python API
  • Description modified (diff)

comment:5 Changed 7 years ago by Mathieu Doucet

  • Milestone changed from Backlog to Release 3.0

comment:6 Changed 7 years ago by Mathieu Doucet

  • Status changed from new to inprogress

Re #7053 Remove old API scripts for ORNL SANS

Changeset: 9730c4ec34df7a898feec247735ce94ceba0843d

comment:7 Changed 7 years ago by Mathieu Doucet

  • Status changed from inprogress to verify
  • Resolution set to fixed

Only API v1 reduction code that is no longer in use has been removed. UI changes to remove API v1 code have been made as part of ticket #7633.

To test:

  • Make sure all EQSANS and HFIR system tests pass
  • Make sure all ISIS SANS tests pass
  • Test EQSANS reduction using the UI
  • Test the ISIS SANS reduction using the UI

comment:8 Changed 7 years ago by Andrei Savici

  • Status changed from verify to verifying
  • Tester set to Andrei Savici

comment:9 Changed 7 years ago by Mathieu Doucet

  • Blocking 7690 added

(In #7690) Creating a ticket for the REFL work: #7855 The SANS work was done in #7633 and #7053 but needs to be tested.

comment:10 Changed 7 years ago by Andrei Savici

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/7053_remove_old_api_ornl_reducer'

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​7899

Note: See TracTickets for help on using tickets.