Ticket #7064 (assigned)

Opened 7 years ago

Last modified 5 years ago

Investigate if the beam centre is being used correctly at sans isis

Reported by: Gesner Passos Owned by: Peter Parker
Priority: critical Milestone: Backlog
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester:

Description (last modified by Gesner Passos) (diff)

While I was looking in detail to the sans isis reduction code, i found strange the relationship between set_beam_finder, get_beam_find_centre, the reduction steps: _beam_finder and _front_beam_finder, and the pre_process inside sans_reducer that is called at the reducer.

I'm afraid, we are not correctly centering the HAB/front bank detector when this parameter is different from the defined for the rear/main.

Besides, the code inside WavRangeReduction after "for the LOQ instrument, if the beam centers are different, we have to reload the data." is to be properly explained and tested as well.

This ticket must, at least, define a proper systemtest.py to double check this issues. If they are correct beter ;)

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:2 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to the Backlog after R2.6

comment:3 Changed 7 years ago by Gesner Passos

  • Component changed from Framework to SANS
  • Description modified (diff)

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:5 Changed 7 years ago by Nick Draper

  • Owner changed from Gesner Passos to Peter Parker

Ownership handed over to Peter

comment:6 Changed 5 years ago by Peter Parker

This is for Richard to investigate the code (he wrote the parts responsible for this). Talk in a SANS Group meeting centred around whether or not the HAB in LOQ is connected to the rear detector.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7910

Note: See TracTickets for help on using tickets.