Ticket #7065 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Load to run LoadEmptyInstrument when applied to an IDF file

Reported by: Karl Palmen Owned by: Karl Palmen
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: anders.markvardsen@… Blocked By: #7263
Blocking: Tester: Anders Markvardsen

Description (last modified by Nick Draper) (diff)

I think this would be desirable.

It presently interprets it as an invalid ASCII data file.

This should be as simple as making LoadEmpty Instrument into a proper load algorithm and writing quick file check and filecheck for it.

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Priority changed from minor to major
  • Owner set to Karl Palmen
  • Status changed from new to assigned
  • Description modified (diff)

comment:2 Changed 7 years ago by Karl Palmen

  • Status changed from assigned to accepted

comment:3 Changed 7 years ago by Karl Palmen

  • Blocked By 7263 added

comment:4 Changed 7 years ago by Karl Palmen

Make LoadEmptyInstrument into a file loader re #7065

Signed-off-by: Karl Palmen <karl.palmen@…>

Changeset: 689a2c4210ab78c424aaad5a01ec28cbd7a900c1

comment:5 Changed 7 years ago by Karl Palmen

  • Status changed from accepted to verify
  • Resolution set to fixed

To test, run Mantid run Load and select an IDF file. These can be found in the ...\Code\Mantid\instrument folder. Check that it loads an instrument that can be viewed just like LoadEmptyInstrument does.

Also check load on other loadable files to see that they load appropriately. If you find or know of any such file with 'Definition' in its name, check the file.

comment:6 Changed 7 years ago by Karl Palmen

The IDF files (see http://www.mantidproject.org/InstrumentDefinitionFile ) have 'Definition' in their names. Those files in ...\Code\Mantid\instrument with "Parameter" in their name should not load.

comment:7 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:8 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Tested on a number of files and LoadEmptyInstrument now used to load IDF files

comment:9 Changed 7 years ago by Anders Markvardsen

Merge remote-tracking branch 'origin/feature/7065_load_IDF'

comment:10 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7911

Note: See TracTickets for help on using tickets.