Ticket #7066 (assigned)
Limit the scope of Fit functions in IDF and parameter files
| Reported by: | Owen Arnold | Owned by: | Anders Markvardsen |
|---|---|---|---|
| Priority: | major | Milestone: | Backlog |
| Component: | Framework | Keywords: | |
| Cc: | nick.draper@… | Blocked By: | |
| Blocking: | Tester: |
Description (last modified by Anders Markvardsen) (diff)
See http://www.mantidproject.org/NormaliseByDetector, which uses IDF type="fitting" to associate an equation with a detector. However, for this case the scope of this type="fitting" parameter is that particular algorithm only.
See http://www.mantidproject.org/NormaliseByDetector, which uses type="fitting" associate an equation with a detector. What we really want is to avoid confusion by being able to say that a particular equation in the parameter file belongs to a specific algorithm. i.e. type="Algorithm:NormaliseByDetector", and make it incompatible with fit functions so that it doesn't get automatically applied (for the wrong purpose) in the fitting framework.
Please talk to me about this if it doesn't make sense.
Change History
comment:2 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:3 Changed 7 years ago by Anders Markvardsen
- Description modified (diff)
- Milestone changed from Backlog to Release 3.0
comment:4 Changed 7 years ago by Anders Markvardsen
- Milestone changed from Release 3.0 to Release 3.1
comment:5 Changed 7 years ago by Anders Markvardsen
- Summary changed from Using Fit functions for Non fitting to Limit the scope of Fit functions in IDF and parameter files
comment:6 Changed 7 years ago by Anders Markvardsen
- Description modified (diff)
Discussing this with Owen.
http://www.mantidproject.org/NormaliseByDetector rely on IDF fitting parameters being specified - although for this case fitting parameters that can benefit from being limited to the scope this algorithm.
One suggestion to introduce scope, here to a fitting parameter, but it could be to any parameter is:
<parameter name="IkedaCarpenterPV:Alpha0" type="fitting">
<scope-list>
<scope>DetectorEfficiency</scope> <scope>General</scope>
</scope-list> <formula eq="100.0+10*centre+centre2" unit="TOF" result-unit="1/dSpacing2"/>
</parameter>
i.e. allow an optional <scope-list>. If not specified the default could be <scope>General</scope>. For the particular case of a fitting parameter the behavior could be that if <scope>General</scope> not part of scope then such a fitting parameter would not be used as part of (default) Mantid fitting.
Perhaps a better name <tag> or <category> rather than <scope>.
The number of allowed <scope> values should be limited by the XSD (i.e. schema)
comment:7 Changed 7 years ago by Nick Draper
- Milestone changed from Release 3.1 to Backlog
Moved to backlog at the end of Release 3.1
