Ticket #7118 (closed: fixed)
ISIS SANS: Crash when clicking "Clear I Derived"
Reported by: | Martyn Gigg | Owned by: | Gesner Passos |
---|---|---|---|
Priority: | major | Milestone: | Release 3.0 |
Component: | SANS | Keywords: | |
Cc: | Blocked By: | ||
Blocking: | Tester: | Michael Reuter |
Description (last modified by Gesner Passos) (diff)
When testing #6226 I opened the ISIS SANS interface went straight to the 1D Analysis tab and clicked "Clear I Derived" and it crash immediately. I guess it is because there is nothing in the table.
Top of stack trace from debug build:
#0 0x00000000006d944b in QTableWidgetItem::setText (this=0x0, atext=...) at /usr/include/qt4/QtGui/qtablewidget.h:192 #1 0x00007fffb887c510 in MantidQt::CustomInterfaces::SANSPlotSpecial::clearInterceptDerived (this=0x42d3000) at /home/dmn58364/Code/mantid/Code/Mantid/MantidQt/CustomInterfaces/src/SANSPlotSpecial.cpp:223 #2 0x00007fffb891246e in MantidQt::CustomInterfaces::SANSPlotSpecial::qt_static_metacall (_o=0x42d3000, _c=QMetaObject::InvokeMetaMethod, _id=7, _a=0x7fffffffc660) at /home/dmn58364/Builds/mantid/debug/MantidQt/CustomInterfaces/inc/MantidQtCustomInterfaces/moc_SANSPlotSpecial.cxx:71
Change History
comment:2 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:3 Changed 7 years ago by Gesner Passos
- Description modified (diff)
- Milestone changed from Backlog to Release 3.0
comment:5 Changed 7 years ago by Gesner Passos
- Status changed from new to inprogress
Solve the crash with Clear I derived
Check pointer before calling the setText method.
re #7118
Changeset: 0ef525b031c1a08893f86f6e81710557c558b0be
comment:6 Changed 7 years ago by Gesner Passos
- Status changed from inprogress to verify
- Resolution set to fixed
Tester:
open the ISIS SANS interface and go straight to the 1D Analysis tab and click "Clear I Derived"
It must not crash.
comment:7 Changed 7 years ago by Gesner Passos
- Status changed from verify to reopened
- Resolution fixed deleted
comment:9 Changed 7 years ago by Gesner Passos
- Status changed from inprogress to verify
- Resolution set to fixed
comment:10 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:11 Changed 7 years ago by Michael Reuter
Doesn't crash on that tab when pressing the button. Tried a few others too, and nothing crashed.
comment:12 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/7118_sans_crash'
comment:13 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 7964