Ticket #7148 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Add probe mode to Splatterplot view

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 2.6
Component: GUI Keywords:
Cc: Blocked By:
Blocking: #7224 Tester: Owen Arnold

Description

The Splatterplot view needs to have a way to trigger the VTK probe filter. This will be used to pick peaks in the display and retrieve the coordinates. Those coordinates will be passed onto a service that will then handle the information in an appropriate manner.

Attachments

Screen Shot 2013-05-30 at 09.59.37.png (200.8 KB) - added by Owen Arnold 7 years ago.

Change History

comment:1 Changed 7 years ago by Michael Reuter

Refs #7148. Adding pick mode for Splatterplot

Can currently add and remove the VTK probe filter, but nothing else.

Changeset: f6ece22a6ec973b2630871b41540ccf2cf7409a6

comment:2 Changed 7 years ago by Michael Reuter

Refs #7148. Switching on orthographic projection in pick mode.

Changeset: 9504285f6f562897770569b104729f61600c31b9

comment:3 Changed 7 years ago by Michael Reuter

Refs #7148. Trying to hook up pick mode with coord retrieval.

This doesn't seem to work yet as I can't find the way to get the coordinates. Also, the event filter seems to trip off if you switch away from the window and go back.

Changeset: ae39cf7aba17ce04ab7df63183a6b5b1a8c6fc78

comment:4 Changed 7 years ago by Michael Reuter

  • Status changed from new to accepted

comment:5 Changed 7 years ago by Michael Reuter

Refs #7148. Destroy probe filter if present on view switch.

Changeset: e34ea97246dbdc26a43d00d7db40b900e7121b29

comment:6 Changed 7 years ago by Michael Reuter

Refs #7148. Getting coordinates and passing them onto service.

Changeset: aafcd5519ab0d9600c1e3b4e0b5b01e2a5be62af

comment:7 Changed 7 years ago by Michael Reuter

Refs #7148. Fixing event filter issue.

Changeset: f9967a9049b1cd52951a2222fdd5e4481c731131

comment:8 Changed 7 years ago by Michael Reuter

Refs #7148. Handling possible source inputs.

Changeset: 503e2629a0a165cb2030260e7ae800673e841582

comment:9 Changed 7 years ago by Michael Reuter

Merge branch 'feature/7148_splatterplot_pick_mode' into develop

comment:10 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/bugfix/7138_globtestfix' into 6856_ConvertToDiffractionMDWS_v2

comment:11 Changed 7 years ago by Peter Peterson

Merge remote branch 'origin/bugfix/7112_powder_redux' into 6856_ConvertToDiffractionMDWS_v2

comment:12 Changed 7 years ago by Karl Palmen

Merge branch 'feature/5225_flat_background' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:13 Changed 7 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/bugfix/7138_globtestfix' into 6856_ConvertToDiffractionMDWS_v2

comment:14 Changed 7 years ago by Peter Peterson

Merge remote branch 'origin/bugfix/7112_powder_redux' into 6856_ConvertToDiffractionMDWS_v2

comment:15 Changed 7 years ago by Karl Palmen

Merge branch 'feature/5225_flat_background' into develop into 6856_ConvertToDiffractionMDWS_v2

comment:16 Changed 7 years ago by Michael Reuter

Refs #7148. Fixing keyboard focus issue.

Changeset: 52913935410121dc9d09834f6cb041b5c20efa2a

comment:17 Changed 7 years ago by Michael Reuter

Merge branch 'feature/7148_splatterplot_pick_mode' into develop

comment:18 Changed 7 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

Branch is here.

To test:

  1. Start MantidPlot and load a TOPAZ run, such as TOPAZ_3132_event.nxs, and convert it to an MD workspace. The quickest way to do this is to bring up the Interface: SCD Event Data Reduction (SEDR), and use the Browse button on the first form to select the event nexus file. Set the Max |Q| to Map to MD to 25, and turn on the Lorentz Correction. Press the Apply button to both load the file and convert it (properly) to an MD workspace.
  2. Switch to the Find Peaks tab and hit Apply
  3. Switch to the Point Info tab and move window aside
  4. Open MDEventWorkspace in VSI and switch to SplatterPlot view
  5. Enter pick mode by clicking the Pick Mode button
  6. Place the mouse over peak and hit the p key
  7. Observe that information is displayed in the SEDR Point Info tab
  8. Exit pick mode by clicking the Pick Mode button

comment:19 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:20 Changed 7 years ago by Owen Arnold

Apparently this branch has not been merged into develop. This is probably because Martyn recreated Develop from Master since you merged the branch in last time.

Could you please run git checkbuild (or equivalent git commands) to merge this branch into develop so that I can continue with testing.

Changed 7 years ago by Owen Arnold

comment:21 Changed 7 years ago by Owen Arnold

So I merged this branch into Master anyway to test it, and it's very nice. I did however manage to trip-over an exception that I think we could be better handled (see attachement). Pressing continue is OK, but the dialog is not desirable.

comment:22 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:23 Changed 7 years ago by Michael Reuter

  • Status changed from reopened to accepted

comment:24 Changed 7 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

Please open another ticket on this issue because the probe mode is actually decoupled from the thing (SEDR) that is handling the data. The VSI just throws the coordinates over the wall.

comment:25 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying

comment:26 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

comment:27 Changed 7 years ago by Owen Arnold

  • Blocking 7224 added

comment:28 Changed 7 years ago by Nick Draper

  • Component changed from VATES to User Interface

comment:29 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 7994

Note: See TracTickets for help on using tickets.