Context Navigation

Ticket #7157 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Make CalculateFlatBackground work without using a deprecated child algorithm

Reported by:	Karl Palmen	Owned by:	Arturs Bekasovs
Priority:	major	Milestone:	Release 2.6
Component:	Framework	Keywords:	Student
Cc:		Blocked By:	#5225
Blocking:		Tester:	Wenduo Zhou

Description

CalculateFlatBackground currently uses a child algorithm of Linear, which is deprecated. The code that does this needs replacing with code that does the same thing without using any deprecated child algorithm.

Change History

comment:1 Changed 7 years ago by Nick Draper

Owner set to Anyone
Status changed from new to assigned
Keywords Student added; maintenance removed

This should be able to be replaced by a call to Fit

comment:2 Changed 7 years ago by Martyn Gigg

Owner changed from Anyone to Arturs Bekasovs

comment:3 Changed 7 years ago by Arturs Bekasovs

Status changed from assigned to accepted

comment:4 Changed 7 years ago by Arturs Bekasovs

Updated LinearFit to use Fit algorithm

Refs #7157

Changeset: c407fbc6b2a01d805dea32fdda566d5a176b9a2d

comment:5 Changed 7 years ago by Arturs Bekasovs

Extract results properly, use Levenberg-MarquardtMD as minimizer

Refs #7157

Changeset: 1c4d8091628d3d59601eeb733fb914e01ca9190f

comment:6 Changed 7 years ago by Arturs Bekasovs

Explained why the other minimizer is used, improved commeting

Refs #7157

Changeset: 143d9bd337cd3d687f03829904d7a517ce87a4db

comment:7 Changed 7 years ago by Arturs Bekasovs

Status changed from accepted to verify
Resolution set to fixed

Branch: feature/7157_replace_linear

Tester: (Should probably be Roman, to make sure I am doing the right thing with the minimizer.)

To test, create some data with a script:

dataX = [1,2,3,4,5,6,7]
dataY = [5.5,4.0,6.0,4.2,5.8,4.7]

ws = CreateWorkspace(DataX=dataX, DataY=dataY)

Then apply CalculateFlatBackground algorithm with Linear Fit mode and check that the background value is sensible and the plot with extracted background looks like the the one expected. Additionally, notice that the warning regarding Linear algorithm being deprecated is not shown any more.