Ticket #7157 (closed: fixed)
Make CalculateFlatBackground work without using a deprecated child algorithm
Reported by: | Karl Palmen | Owned by: | Arturs Bekasovs |
---|---|---|---|
Priority: | major | Milestone: | Release 2.6 |
Component: | Framework | Keywords: | Student |
Cc: | Blocked By: | #5225 | |
Blocking: | Tester: | Wenduo Zhou |
Description
CalculateFlatBackground currently uses a child algorithm of Linear, which is deprecated. The code that does this needs replacing with code that does the same thing without using any deprecated child algorithm.
Change History
comment:1 Changed 7 years ago by Nick Draper
- Owner set to Anyone
- Status changed from new to assigned
- Keywords Student added; maintenance removed
comment:4 Changed 7 years ago by Arturs Bekasovs
Updated LinearFit to use Fit algorithm
Refs #7157
Changeset: c407fbc6b2a01d805dea32fdda566d5a176b9a2d
comment:5 Changed 7 years ago by Arturs Bekasovs
Extract results properly, use Levenberg-MarquardtMD as minimizer
Refs #7157
Changeset: 1c4d8091628d3d59601eeb733fb914e01ca9190f
comment:6 Changed 7 years ago by Arturs Bekasovs
Explained why the other minimizer is used, improved commeting
Refs #7157
Changeset: 143d9bd337cd3d687f03829904d7a517ce87a4db
comment:7 Changed 7 years ago by Arturs Bekasovs
- Status changed from accepted to verify
- Resolution set to fixed
Branch: feature/7157_replace_linear
Tester: (Should probably be Roman, to make sure I am doing the right thing with the minimizer.)
To test, create some data with a script:
dataX = [1,2,3,4,5,6,7] dataY = [5.5,4.0,6.0,4.2,5.8,4.7] ws = CreateWorkspace(DataX=dataX, DataY=dataY)
Then apply CalculateFlatBackground algorithm with Linear Fit mode and check that the background value is sensible and the plot with extracted background looks like the the one expected. Additionally, notice that the warning regarding Linear algorithm being deprecated is not shown any more.
comment:8 Changed 7 years ago by Wenduo Zhou
- Status changed from verify to verifying
- Tester set to Wenduo Zhou
comment:9 Changed 7 years ago by Arturs Bekasovs
Updated LinearFit to use Fit algorithm
Refs #7157
Changeset: 83f7e527eab5a00d339bf8f4ba0516e2cd7f9e5e
comment:10 Changed 7 years ago by Arturs Bekasovs
Extract results properly, use Levenberg-MarquardtMD as minimizer
Refs #7157
Changeset: 8908fa185c940f549b0fbe234eaeb833a154a4b8
comment:11 Changed 7 years ago by Arturs Bekasovs
Explained why the other minimizer is used, improved commeting
Refs #7157
Changeset: 53eaa1644385be35bcdc50c9bc693f37cdd78fe9
comment:12 Changed 7 years ago by Wenduo Zhou
- Status changed from verifying to closed
CalculateFlatBackground works correctly. So the test is passed.
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8003
This should be able to be replaced by a call to Fit