Context Navigation

Ticket #7209 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

MonitorLiveData on transition from NoRun to Run should observe requested 'End of Run' behaviour

Reported by:	Russell Taylor	Owned by:	Ross Miller
Priority:	minor	Milestone:	Release 3.2
Component:	Framework	Keywords:	LiveData
Cc:		Blocked By:
Blocking:	#9163	Tester:	Russell Taylor

Description (last modified by Russell Taylor) (diff)

Currently, if you start live data reading when outside a run the reading just carries on uninterrupted when a new run starts. I think this is the case regardless, though I actually observed it with the End of Run option set to 'Restart'.

We should treat the NoRun->Run transition the same as ending a run as otherwise it's not possible to start listening prior to the start of a run and isolate the data belonging to that run from that recorded between runs.

This was observed using the SNS live listener.

Change History

comment:1 Changed 7 years ago by Nick Draper

Component changed from Mantid to Framework

comment:2 Changed 7 years ago by Nick Draper

Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:3 Changed 7 years ago by Russell Taylor

Milestone changed from Backlog to Release 3.0

comment:4 Changed 7 years ago by Russell Taylor

Priority changed from major to minor

comment:5 Changed 7 years ago by Russell Taylor

Milestone changed from Release 3.0 to Backlog

comment:6 Changed 7 years ago by Russell Taylor

Description modified (diff)
Milestone changed from Backlog to Release 3.1

comment:7 Changed 7 years ago by Russell Taylor

Milestone changed from Release 3.1 to Backlog

comment:8 Changed 7 years ago by Russell Taylor

Milestone changed from Backlog to Release 3.2

comment:9 Changed 7 years ago by Nick Draper

Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:10 Changed 7 years ago by Ross Miller

Blocking 9163 added

(In #9163) Strictly speaking, the code changes for this ticket will compile and run without #7209, but in most cases the data will be incorrect.

comment:11 Changed 7 years ago by Ross Miller

Status changed from assigned to inprogress

Perform 'End of Run' behavior on all run transitions

Perform the requested end of run behavior on NoRun => BeginRun transitions (in addition to the EndRun => NoRun transitions we've been performing it on).

This change is just the beginning and only works for the SNS live listener. Haven't looked at ISIS yet. Also haven't updated the GUI, yet.

Refs #7209

Changeset: 476c32cb13063d19f9e7d39cef166fbb7554db17

comment:12 Changed 6 years ago by Russell Taylor

Owner changed from Russell Taylor to Ross Miller

comment:13 Changed 6 years ago by Ross Miller

Property name and GUI cleanups

Changed the property name from EndRunBehavior to RunTransitionBehavior which is now a better description. Updated all the references to the old behavor (including test and GUI code). Also changed the label in the StartLiveData dialog window.

Refs #7209

Changeset: 5622e3b127158370c3fee23b374f0bbcdf9243b9