Ticket #7210 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Exception thrown without Peaks workspace for VSI splatterplot pick mode

Reported by: Michael Reuter Owned by: Dennis Mikkelson
Priority: major Milestone: Release 2.6
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

If you create a MD workspace with the SCD Event Data Reduction interface but no peaks workspace, view the MD workspace with the VSI in SplatterPlot view and then use the pick mode, the following exception occurs:

Unexpected exception: Data Object search object TOPAZ_3132_peaks

A warning dialog preceeds the exception saying that no peaks workspace was found, but then the other exception is uncaught. The exception needs to be dealt with properly.

Change History

comment:1 Changed 7 years ago by Dennis Mikkelson

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Dennis Mikkelson

RE 7210_MantidEV exception without peaks workspace

If the peaks workspace named on the MantidEV Find Peaks tab does not exist, an error message will now be shown AND the specified Q-vector will be displayed in the table. If the peaks workspace does exist, the PointInfo() method the the workspace will be used, as before.

refs #7210

Changeset: d6bd7d753ea75037156f1042a77052d8bc4868d7

comment:3 Changed 7 years ago by Dennis Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

NOTES TO TESTER:

The branch name is bugfix/7210_MantidEV_exception_without_peaks_workspace. To test the fix:

  1. Start MantidEV from the MantidPlot Interfaces menu: "SCD Event Data Reduction"
  1. Use the Browse button on the first Select Data form to choose a TOPAZ event NeXus file, such as TOPAZ_3132_event.nxs in the systemtests/Data directory. Press Apply to actually load the file and convert to an MD workspace.
  1. When the event data has been loaded and converted to an MD workspace, select the Point Info tab and enter three components for Qx,Qy,Qz such as 1 2 3 at the bottom of the page. If you then press the "Show Info" button, an error message will say that the peaks workspace does not exist, but the Q values that you entered will be displayed. This "loop back test" uses the same SelectionNotificationService routine as the pick mode of the VSI splatter plot.
  1. Next, choose the Find Peaks tab, select the "Find Peaks", rather than loading or using an existing peaks workspace. Specify the Estimated Max of a,b,c to be 15, the Number of Peaks to Find to be 400, and the Min Intensity to be 1000. If you then press Apply on the Find Peaks tab, 400 peaks will be found and the peaks workspace will be created.
  1. Again switch to the Point Info tab and again enter values for Qx,Qy,Qz. This time no error message should pop up and the Selected Point Info table will have more information about the specified Q and the peak that is closest to the specified Q.

comment:4 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:5 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

I tried the above procedure as well as checking the pick mode in the SplatterPlot. I found that without the PeaksWorkspace, Mantid did not have any uncaught exceptions.

comment:6 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8056

Note: See TracTickets for help on using tickets.