SliceViewer from VSI MultiSlice view no longer works

[Michael Reuter]

When doing shift-click on a slice in the VSI MultiSlice view, the resulting SliceViewer view does not match the expectations. This works in the 2.5.0 release.

[Michael Reuter]

This seems to occur only when a rebinner is used.

[Michael Reuter]

I'm going to have to take it back. This got through on the 2.5.0 release when the rebinner is involved.

[Michael Reuter]

This looks to be a very particular case where the rebinner is used to reorient the axes. The SliceViewer seems to get confused by this.

[Nick Draper]

Moved to release 2.6 pending acceptance into the patch

[Michael Reuter]

Refs #7212. Forcing display update to set plot axes.

Due to the mechanism used to generate the SliceViewer views from the VSI MultiSlice view, when a rebinner was used to reorient the axes, a mismatch arose between the cached dimensions and the workspace dimensions. I've forced an axis update to ensure that things are commensurate. The change is done in a function that is ONLY called by the shift-click mechanism in the MultiSlice view. This limits the side effects to this change.

Changeset: 1056e0bac06163bd32d0fa1732ad469344012e25

[Michael Reuter]

Refs #7212. Fixing issue with integrated "time" dimension in VSI.

This fix was necessary to handle an annoying issue with the SEQ_MDEW.nxs file. When the SliceViews were generated by the shift-click mechanism, they kept coming out blank. I traced this due to a bad time value being handed to the SliceViewer. Datasets with an integrated time axis need to be treated slightly more carefully.

Changeset: ded2416632d6b5db239be1ed223039fb695df0cc

[Michael Reuter]

The branch is ​here and is not merged anywhere. It was branched off the release-2.5.x branch.

To Test:

1. Open the SEQ_MDEW.nxs file in MantidPlot
2. Open the resulting workspace in the VSI
3. Add a rebinner, move the [Ql,0,0] to the T-Axis and integrate it, move the DeltaE to the Y-Axis and hit Apply
4. Switch to the MultiSlice view and add a slice
5. Do shift-click on the indicator and a SliceViewer will come up

The SV view should match the view on the slice in the MultiSlice view.

[Michael Reuter]

You may have to play with the color scaling on the SliceViewer to be sure.

[Owen Arnold]

So I've tested this and it works, only problem is that the branches have got a bit messed up.

Might I suggest.

1) Create a new Branch from the current state of master

2) Cherry pick your two new commits onto that branch

3) Checkbuild and push the branch to origin

I can't follow the usual test procedure on this branch because it's been created from an intermediate state of the release branch.

[Michael Reuter]

Refs #7212. Forcing display update to set plot axes.

Due to the mechanism used to generate the SliceViewer views from the VSI MultiSlice view, when a rebinner was used to reorient the axes, a mismatch arose between the cached dimensions and the workspace dimensions. I've forced an axis update to ensure that things are commensurate. The change is done in a function that is ONLY called by the shift-click mechanism in the MultiSlice view. This limits the side effects to this change. (cherry picked from commit 1056e0bac06163bd32d0fa1732ad469344012e25)

Changeset: 212928f3022b758416e31a740798292985e0cb1c

[Michael Reuter]

Refs #7212. Fixing issue with integrated "time" dimension in VSI.

This fix was necessary to handle an annoying issue with the SEQ_MDEW.nxs file. When the SliceViews were generated by the shift-click mechanism, they kept coming out blank. I traced this due to a bad time value being handed to the SliceViewer. Datasets with an integrated time axis need to be treated slightly more carefully. (cherry picked from commit ded2416632d6b5db239be1ed223039fb695df0cc)

Changeset: 8ae5a9bdd75e8311a759df6923331be8888854a1

[Michael Reuter]

New branch is ​here and has been push and built on develop.

[Owen Arnold]

I've done some detailed testing of these changes and I saw no unexpected behaviour.

[Stuart Campbell]

This ticket has been transferred to github issue ​8058