Ticket #7213 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Sorting in splatter plot point generation

Reported by: Peter Peterson Owned by: Michael Reuter
Priority: major Milestone: Release 3.0
Component: GUI Keywords: Maintenance
Cc: Blocked By: #7675
Blocking: Tester: Peter Peterson

Description

Since the factory is a property of the splatter plot itself, cache the sorting of the box structure so when people play with the threshold the sorting is not repeated.

Change History

comment:1 Changed 7 years ago by Dennis Mikkelson

  • Status changed from new to accepted

This should be done and should be fairly straightforward. It was not done initially, since "premature optimization is the root of all evil".

comment:2 Changed 7 years ago by Dennis Mikkelson

RE 7213_Sort once in splatterplot

Added instance variables to hold the sorted list of boxes and the workspace name. The list sorted list will now only be made if it was not previously made, or if the MD workspace name changes. NOTE: This does not yet solve the problem, since the whole splatter plot factory is rebuilt everytime the user changes the number of points or percent. One possible solution would be for the higher level class to only construct a new splatter plot factory in case the workspace changes, and just call the doCreate() method on that factory when the user changes the number of points or percent.

refs #7213

Changeset: 7771162aa815148df6188919e052366104f20469

comment:3 Changed 7 years ago by Dennis Mikkelson

  • Owner changed from Dennis Mikkelson to Peter Peterson
  • Status changed from accepted to assigned

The change to keep a sorted list requires more extensive modification to the VSI, as described in the previous comment on this ticket. In addition, since the time when work was done on this ticket, the SplatterPlotFactory code has been changed to create VTK data structures that are precisely the correct size. Consequently, if the work in this branch is to be continued, together with more extensive changes to the higher level classes in the VSI, a thoughtful, manual merge of the changes here with the new code should be done.

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from assigned to new

comment:5 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:6 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:7 Changed 7 years ago by Michael Reuter

  • Blocked By 7675 added

comment:8 Changed 7 years ago by Michael Reuter

  • Keywords Maintenance added
  • Owner changed from Peter Peterson to Michael Reuter
  • Component changed from Framework to User Interface
  • Milestone changed from Backlog to Release 3.0

comment:9 Changed 7 years ago by Michael Reuter

  • Status changed from new to verify
  • Resolution set to fixed

This work has been translated into #7728. When that ticket is closed, you can close this one for free.

comment:10 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:11 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

I verified the other and deleting both branches.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 8059

Note: See TracTickets for help on using tickets.