Ticket #7224 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Undesired behaviour with Pick Mode in VSI

Reported by: Owen Arnold Owned by: Ruth Mikkelson
Priority: major Milestone: Release 2.6
Component: GUI Keywords:
Cc: reuterma@…, owen.arnold@…, mikkelsonr@… Blocked By: #7148
Blocking: Tester: Peter Peterson

Description

Undesired behaviour. Exception thrown. See my comment in #7148. Seems to continue as normal if 'continue' is pressed. But not nice for the user.

Change History

comment:1 Changed 7 years ago by Michael Reuter

  • Owner changed from Michael Reuter to Dennis Mikkelson
  • Status changed from new to assigned

This is actually a problem in the SCD Event Data Reduction interface since the VSI just throws the coordinates over the wall. It does no searching of the PeaksWorkspace.

comment:2 Changed 7 years ago by Dennis Mikkelson

  • Status changed from assigned to accepted
  • Cc reuterma@…, owen.arnold@…, mikkelsonr@… added

By looking at closed ticket #7148, I see the problem reported by Owen, with the out of range peak number in PeaksWorkspace::getPeak(). I will catch this exception and handle it cleanly.

comment:3 Changed 7 years ago by Dennis Mikkelson

  • Owner changed from Dennis Mikkelson to Ruth Mikkelson
  • Status changed from accepted to assigned

comment:4 Changed 7 years ago by Ruth Mikkelson

  • Status changed from assigned to accepted

comment:5 Changed 7 years ago by Ruth Mikkelson

Refs #7224 Fixed a problems and more catches

It is possible( very unlikely) for a peak to be deleted from another thread

Changeset: 9ec34ae093892662e3510f4e2ea5fddfaa7b1357

comment:6 Changed 7 years ago by Ruth Mikkelson

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester:

The last peak in the peaksWorkspace probably caused this problem. Also check if this works if a peak is removed from the PeaksWorkspace.

comment:7 Changed 7 years ago by Peter Peterson

  • Status changed from verify to verifying
  • Tester set to Peter Peterson

comment:8 Changed 7 years ago by Peter Peterson

  • Status changed from verifying to closed

comment:9 Changed 7 years ago by Nick Draper

  • Component changed from VATES to User Interface

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8070

Note: See TracTickets for help on using tickets.