Ticket #7243 (closed: fixed)
Make MonitorLiveData test faster
| Reported by: | Russell Taylor | Owned by: | Russell Taylor |
|---|---|---|---|
| Priority: | trivial | Milestone: | Release 3.0 |
| Component: | Framework | Keywords: | LiveData,Maintenance |
| Cc: | Blocked By: | #7746 | |
| Blocking: | Tester: | Stuart Campbell |
Description (last modified by Russell Taylor) (diff)
Once we're confident that the issues from #7218 are definitely resolved, make this test go faster. The last 2 tests are the slowest and we could:
- Reduce the update time below the current 0.15s
- Reduce the number of 'chunks' below 7
- Find a way to remove the hard 0.5s wait at the end (Poco::Thread::sleep(500))
Change History
comment:3 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to the Backlog after the code freeze for R2.6
comment:5 Changed 7 years ago by Russell Taylor
- Keywords LiveData,Maintenance added; LiveData removed
comment:7 Changed 7 years ago by Russell Taylor
- Status changed from new to inprogress
Re #7243. Try to speed up MonitorLiveDataTest.
For the slowest test methods, reduce the time between updates, the number of times the algorithm is run and exit the methods as soon as the algorithm ends (while guarding against an infinite loop if it gets doens't cancel for some reason).
Changeset: 7d0caaefec04b5186f8af4bbc8b1dcfa1facaae0
comment:8 Changed 7 years ago by Russell Taylor
- Status changed from inprogress to verify
- Resolution set to fixed
Tester: Branch is feature/7243_speedup_monitorlivedatatest
Observe in a Jenkins timing history (e.g. here) that this test got a good deal faster at the point these changes went in.
Then it's good so long as the test isn't and hasn't been failing anywhere (even sporadically) and the changes haven't significantly decreased the rigour with which the algorithm is tested.
comment:9 Changed 7 years ago by Stuart Campbell
- Status changed from verify to verifying
- Tester set to Stuart Campbell
comment:10 Changed 7 years ago by Stuart Campbell
- Status changed from verifying to closed
Looks like it's faster to me!
comment:11 Changed 7 years ago by Stuart Campbell
Merge remote branch 'origin/feature/7243_speedup_monitorlivedatatest'
comment:12 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8089
(In #7218) Branch is feature/7218_monitorlivedata_occasional_test_failures
Test by checking for any failures of this test after today (4 June) here and here.
I'm pretty sure I've fixed the first problem in the description, but not so confident on the second one - my best guess is the last commit above. If one is fixed but not the other, please create a new ticket for the still-broken one so that we can get at least one fix into master.