Ticket #7258 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

ParaView plugins warning on clamping progress

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 2.6
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Owen Arnold

Description

Warnings are being generated by ParaView from invalid progress information being given to it by certain plugins.

Attachments

ProgressWarnings.tiff​ (169.4 KB) - added by Michael Reuter 7 years ago.
Progress warnings generated in ParaView.
ProgressWarnings.png​ (112.8 KB) - added by Michael Reuter 7 years ago.
Progress warnings generated in ParaView.

Change History

Changed 7 years ago by Michael Reuter

Progress warnings generated in ParaView.

Changed 7 years ago by Michael Reuter

Progress warnings generated in ParaView.

comment:1 Changed 7 years ago by Michael Reuter

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Michael Reuter

Refs #7258. Ensuring all progress values less or equal to 1.

ParaView really doesn't like progress values greater than 1 and that's what was happening. I think we didn't see this issue more frequently due to the shear volume of progress updates being thrown at the system.

Changeset: 6540ae7ce7893e70c96e39a3fac78b928552d324

comment:3 Changed 7 years ago by Michael Reuter

  • Status changed from accepted to verify
  • Resolution set to fixed

The branch is ​here.

To test:

This one is a bit tricky as the warning shows up infrequently, seemingly randomly, but enough that it's annoying. The best thing to do is follow this procedure before starting the testing phase to see if you can trigger the warning. Otherwise, you can look at the code diffs to see that all progress reporting values are now less than 1 to make ParaView happy.

  1. Find a sizeable (~2 GB) MDEventWorkspace file and open it in the VSI
  2. Click the Rebin button and adjust the parameters to suit the dataset.
  3. Click Apply and hope the warning appears during the rebinning process.

Once you've found a dataset that generates the warning, do the exact same procedure using the branch fix.

Last edited 7 years ago by Michael Reuter (previous) (diff)

comment:4 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:5 Changed 7 years ago by Owen Arnold

I can reproduce the generation of these warnings using a file on my computer. Warning generated is: 

Warning: In /Users/spu92482/Documents/ParaView-3.98.1-source/ParaViewCore/ClientServerCore/Core/vtkPVProgressHandler.cxx, line 261
vtkPVProgressHandler (0x7ff117d30870): vtkMDEWRebinningCutter reported invalid progress (15). Value must be between [0, 1]. Clamping to this range.

Just making a note about this, because I haven't yet applied the fix, but I may need to compare warning outputs.

comment:6 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

Applying the bugfix fixed the issue. Code changes look like what I would expect.

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from VATES to User Interface

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8104

Note: See TracTickets for help on using tickets.