Ticket #7280 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SNSPowderReduction and filterWall

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: major Milestone: Release 2.6
Component: Diffraction Keywords: PatchCandidate
Cc: Blocked By:
Blocking: Tester: Mathieu Doucet

Description

In the current release version there is an error generated if FilterCharacterizations=True. Fix the bug.

Change History

comment:1 Changed 7 years ago by Peter Peterson

  • Owner set to Peter Peterson
  • Status changed from new to accepted

comment:2 Changed 7 years ago by Peter Peterson

Re #7280. It was a not fully renamed variable.

Changeset: e36680b2e423f27421b20f7d603529fa3719bc3b

comment:3 Changed 7 years ago by Peter Peterson

  • Status changed from accepted to verify
  • Resolution set to fixed

This is on ​bugfix/7280_filterwall.

To test:

  1. Before merging, try out SNSPowderReduction on some data with FilterCharacterizations=True. See how it errors.
  2. Merge and rerun the same thing.

comment:4 Changed 7 years ago by Mathieu Doucet

  • Status changed from verify to verifying
  • Tester set to Mathieu Doucet

comment:5 Changed 7 years ago by Peter Peterson

Here is a list of parameters that break it (before the change). Everything not mentioned is blank:

  • Instrument=NOM
  • RunNumber=14526
  • Extension=_event.nxs
  • PreserveEvents=True
  • Sum=False
  • PushDataPositive=None
  • BackgroundNumber=14527
  • VanadiumNumber=14528
  • VanadiumBackgroundNumber=14529
  • CalibrationFile=/SNS/NOM/IPTS-8607/shared/NOM_calibrate_d14526_2013_05_18.cal
  • CharacterizationRunsFile=/SNS/users/pf9/NOM_characterizations.txt
  • RemovePromptPulse=50
  • MaxChunkSize=16
  • FilterCharacterizations=True
  • ResampleX=-3000
  • BinInDspace=True
  • StripVanadiumPeaks=True
  • FilterBadPulses=False
  • SaveAs=gsas
  • OutputDirectory=/tmp
  • NormalizeByCurrent=True
  • FinalDataUnits=MomentumTransfer

comment:6 Changed 7 years ago by Mathieu Doucet

  • Status changed from verifying to closed

Works.

comment:7 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Release 2.5.4

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5.4 to Release 2.6

Returned to Release 2.6 as patch release 2.5.4 will now not happen.

comment:9 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:10 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Diffraction

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8126

Note: See TracTickets for help on using tickets.