Ticket #7318 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Replace getDetectorTwoTheta with getTwoTheta

Reported by: Dereck Kachere Owned by: Dereck Kachere
Priority: major Milestone: Release 2.6
Component: Indirect Inelastic Keywords:
Cc: spencer.howells@… Blocked By:
Blocking: Tester: Michael Reuter

Description

Modify the IndirectCommon script to replace getDetectorTwoTheta, which has been removed after being deprecated.

Attachments

irs26176_graphite002_red.nxs​ (1.5 MB) - added by Dereck Kachere 7 years ago.
irs26176_graphite002_iqt.nxs​ (298.8 KB) - added by Dereck Kachere 7 years ago.
irs26173_graphite002_res.nxs​ (148.2 KB) - added by Dereck Kachere 7 years ago.

Change History

comment:1 Changed 7 years ago by Dereck Kachere

  • Status changed from new to accepted

comment:2 Changed 7 years ago by Dereck Kachere

refs #7318 Replaced getDetectorTwoTheta

Changeset: 4225e7571e77d6e481903e9227d8d67dce3e83bc

comment:3 Changed 7 years ago by Dereck Kachere

  • Status changed from accepted to verify
  • Resolution set to fixed

Tester:

branch is feature/7318_replace_get_detector_two_theta

Though it is not prominent, if you run FuryFit and ConvFit in the IndirectDataAnalysis interface in a recent version of Mantid, you will get the following message in the Results Log:

C:/MantidInstall/scripts/Inelastic\IndirectCommon.py:87: DeprecationWarning: getTwotheta is deprecated, use getTwoTheta instead (Note the case variation) return detector.getTwotheta(samplePos, beamPos)

The changes made in this ticket replace the deprecated method so when you run FuryFit and ConvFit, this message is no longer displayed.

Changed 7 years ago by Dereck Kachere

Changed 7 years ago by Dereck Kachere

Changed 7 years ago by Dereck Kachere

comment:4 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:5 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

I tried before the change and saw the deprecation warning. After the applying the change, the warning is now gone.

comment:6 Changed 7 years ago by Nick Draper

  • Component changed from Mantid to Framework

comment:7 Changed 7 years ago by Nick Draper

  • Component changed from Framework to Indirect Inelastic

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8164

Note: See TracTickets for help on using tickets.