Ticket #7330 (closed: duplicate)
MinValues and MaxValues should be optional in ConvertToMD
| Reported by: | Peter Peterson | Owned by: | Alex Buts |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.0 |
| Component: | Direct Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description (last modified by Alex Buts) (diff)
Three smallish changes in a single ticket:
- Since these are only used in limiting the range of events, a valid default would be to just use everything.
- For things like Q-sample, Q-lab, and hkl, making a user specify the same thing three times is a little silly. The single crystal diffractometers at SNS would find it easier to just specify MinValues=-20, MaxValues=20 and have the algorithm just duplicate that for all dimensions
- Add an implementation of validateInputs which checks that the dimensionality of these parameters match and error before the start of exec.
Change History
comment:2 Changed 7 years ago by Andrei Savici
In #5875 I created an algorithm to calculate Min values and Max values. You can call it as child algorithm if not set.
comment:4 Changed 7 years ago by Nick Draper
- Milestone changed from Release 2.6 to Backlog
Moved to backlog at the code freeze for R2.6
comment:5 Changed 7 years ago by Alex Buts
- Status changed from new to inprogress
- Description modified (diff)
comment:6 Changed 7 years ago by Alex Buts
- Status changed from inprogress to verify
- Resolution set to duplicate
It looks like the duplicate for #7529
comment:8 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:9 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
Yes, this does look like a duplicate.
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 8176
Note: See
TracTickets for help on using
tickets.
It sounds like the duplicate for #5875