Ticket #7393 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Create Mcstas event loader

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: critical Milestone: Release 2.6
Component: Framework Keywords:
Cc: torben.nielsen@… Blocked By:
Blocking: Tester: Karl Palmen

Description (last modified by Anders Markvardsen) (diff)

Can load a new McStas format that can weighted events

Change History

comment:1 Changed 7 years ago by Martyn Gigg

Merge branch 'master' of ​git://github.com/trnielsen/mantid into feature/7393_mcstas_event

Refs #7393 Conflicts:

Code/Mantid/Framework/DataHandling/CMakeLists.txt

Changeset: a2cfaaf8626ce5f74521379ba738ef02f9577640

comment:2 Changed 7 years ago by Anders Markvardsen

uncomment loadill. re #7393

Changeset: c51e9797cc51c7edaab35bc15853cb64f1c63a66

comment:3 Changed 7 years ago by Anders Markvardsen

Remove reference to doneAddingEventLists. re #7393

No longer needed see #7176

Changeset: a7d604ab9069cb28817048db41e8fff33267f2d3

comment:4 Changed 7 years ago by Anders Markvardsen

Use new hdf loader approach. re #7393

and changed some formatting

Changeset: 963e608afa94ef8c374327a3570eca4c18140a16

comment:5 Changed 7 years ago by Anders Markvardsen

removed headers not used. re #7393

Changeset: b493cca8d1a3d9a974e1baaf435795a9d9f5766c

comment:6 Changed 7 years ago by Anders Markvardsen

  • Status changed from new to accepted
  • Description modified (diff)
  • Summary changed from mcstas/mantid work to Create Mcstas event loader

To test

  1. check that unit test for LoadMcStasEventNexus pass on build server
  1. In MantidPlot press the Load button and select from AutoTestData mcstas.h5 - this should create a workspace
  1. In MantidPlot press the Load button and select from AutoTestdata mcstas_event.h5 - this should fail
  1. In Mantidplot run the algorithm LoadMcstasEventNexus and select mcstas_event.hf - this should create a workspace

comment:7 Changed 7 years ago by Anders Markvardsen

  • Status changed from accepted to verify
  • Resolution set to fixed

comment:8 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:9 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to closed

I pass on the assumption that mcstas_event.hf was meant to be mcstas_event.h5. If mcstas_event.hf is correct, you must supply that file and support *.hf files.

comment:10 Changed 7 years ago by Russell Taylor

There are a bunch of gcc compiler warnings coming from this (see e.g. ​http://download.mantidproject.org/jenkins/view/Develop%20Clean%20Builds%20and%20Tests/job/is_clean_rhel6_develop/warnings19). Can these be fixed please?

comment:11 Changed 7 years ago by Karl Palmen

I see that shortestTOF and longestTOF may be used unitialised, WorkspaceCount count is unused and there is a comparison between signed and unsigned integer expressions on line 218.

comment:12 Changed 7 years ago by Anders Markvardsen

#7414 created to handle warnings

comment:13 Changed 7 years ago by Karl Palmen

When doing a git checkbuild for another ticket, I noticed that my test of this ticket generated a VTP file in the Autotest folder and this caused the checkbuild to fail. It worked after I removed this file.

comment:14 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​8239

Note: See TracTickets for help on using tickets.